[Bug 17310] New: Broken URLs in 'Item renewed' / 'Cannot renew' messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Bug ID: 17310 Summary: Broken URLs in 'Item renewed' / 'Cannot renew' messages Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: arouss1980@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Description of the problem: In the Staff client, under Circulation > Renew, the message shown after successful renewal of an item contains broken URLs like these: /cgi-bin/koha/catalogue/detail.pl?biblionumber=Koha::Schema::Result::Biblio=HASH(0x7714d88) /cgi-bin/koha/catalogue/moredetail.pl?itemnumber=7&biblionumber=Koha::Schema::Result::Biblio=HASH(0x7714d88)&bi=1286#item7 This is also true for the message shown when you try to renew an item that is not checked out. Valid in latest stable (v16.05.03) and in the current master (0254fd7). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |arouss1980@gmail.com |ity.org | URL| |/cgi-bin/koha/circ/renew.pl Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 --- Comment #1 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 55630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55630&action=edit Bug 17310 - Broken URLs in 'Item renewed' / 'Cannot renew' messages In the Staff client, under Circulation > Renew, the message shown after successful renewal of an item contains broken URLs. This is also true for the message shown when you try to renew an item that is not checked out. This patch fixes that. Test plan: 1) Go to Circulation > Renew, and search for the barcode of a checked-out item. In the 'Item renewed:' confirmation message, notice how the URLs for the title and the barcode are broken. 2) Now search for the barcode of an item that is not checked out. In the 'Cannot renew:' message, notice how the URLs are broken here too. 3) Apply the patch. 4) Repeat steps 1) and 2). This time the URLs work fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55630|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 55743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55743&action=edit [SIGNED-OFF]Bug 17310: Broken URLs in 'Item renewed' / 'Cannot renew' messages In the Staff client, under Circulation > Renew, the message shown after successful renewal of an item contains broken URLs. This is also true for the message shown when you try to renew an item that is not checked out. This patch fixes that. Test plan: 1) Go to Circulation > Renew, and search for the barcode of a checked-out item. In the 'Item renewed:' confirmation message, notice how the URLs for the title and the barcode are broken. 2) Now search for the barcode of an item that is not checked out. In the 'Cannot renew:' message, notice how the URLs are broken here too. 3) Apply the patch. 4) Repeat steps 1) and 2). This time the URLs work fine. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good catch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55743|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55797&action=edit [PASSED QA] Bug 17310: Broken URLs in 'Item renewed' / 'Cannot renew' messages In the Staff client, under Circulation > Renew, the message shown after successful renewal of an item contains broken URLs. This is also true for the message shown when you try to renew an item that is not checked out. This patch fixes that. Test plan: 1) Go to Circulation > Renew, and search for the barcode of a checked-out item. In the 'Item renewed:' confirmation message, notice how the URLs for the title and the barcode are broken. 2) Now search for the barcode of an item that is not checked out. In the 'Cannot renew:' message, notice how the URLs are broken here too. 3) Apply the patch. 4) Repeat steps 1) and 2). This time the URLs work fine. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November Release 16.11 - Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org