http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36950|0 |1 is obsolete| | --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 37002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37002&action=edit Bug 13852 - Manage C4::VirtualShelves in C4::Auth for performance In C4::Auth there is a use C4::VirtualShelves. Virtualshelves are displayed in all OPAC pages, but not in intranet. For performance, we should move this into a require only for opac pages. This patch adds a condition to fetch virtualshelves only if opac and moves the dependancy on C4::VirtualShelves into require calls. On my desktop, I have those compilation times for C4/Auth.pm : - Without patch : 0,41 seconds - With patch : 0,22 seconds This performance improvement is very usefull for pages that only use a few as dependancy, like errors/404.pl Test plan : - Be sure there are some public lists - Apply patch - Go to opac (not logged-in) - Click on "Lists" - Check you see the public lists - Login with a user - Be sure this user has some private lists - Click on "Lists" - Check you see the public and private lists - Logout - Go to /cgi-bin/koha/opac-reserve.pl - You see the loggin page - Click on "Lists" - Check you see the public lists - Go to intranet - Check you can loggin Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37002|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37315&action=edit [PASSED QA] Bug 13852 - Manage C4::VirtualShelves in C4::Auth for performance In C4::Auth there is a use C4::VirtualShelves. Virtualshelves are displayed in all OPAC pages, but not in intranet. For performance, we should move this into a require only for opac pages. This patch adds a condition to fetch virtualshelves only if opac and moves the dependancy on C4::VirtualShelves into require calls. On my desktop, I have those compilation times for C4/Auth.pm : - Without patch : 0,41 seconds - With patch : 0,22 seconds This performance improvement is very usefull for pages that only use a few as dependancy, like errors/404.pl Test plan : - Be sure there are some public lists - Apply patch - Go to opac (not logged-in) - Click on "Lists" - Check you see the public lists - Login with a user - Be sure this user has some private lists - Click on "Lists" - Check you see the public and private lists - Logout - Go to /cgi-bin/koha/opac-reserve.pl - You see the loggin page - Click on "Lists" - Check you see the public lists - Go to intranet - Check you can loggin Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Ok, found you! This is crazy but... this patch breaks opac-ratings-ajax.pl, see bug 13998 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7923 Depends on|7923 | -- You are receiving this mail because: You are watching all bug changes.