[Bug 20084] New: Patron card creator: layout: Industrial2of5 broken with "Invalid Characters" error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Bug ID: 20084 Summary: Patron card creator: layout: Industrial2of5 broken with "Invalid Characters" error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: victor.grousset@biblibre.com QA Contact: testopia@bugs.koha-community.org ## Reproduction ## This is an oversimplification of a full patron card setup used in production. 1. Create a batch with 1 patron 2. Create a layout and set the name "Print card number as barcode" "Barcode type:" to "Code 39" 3. Create a card template without filling anything 4. Export the batch using the layout and template 5. You should have a white page with a barcode This show that this setup isn't completely bogus (although Code 39 is the only type working) 6. Export the batch 7. You should have a white page with a barcode And no errors in the relevant log file 8. Layout: set "Barcode type:" to Industrial2of5 9. Export the batch 10. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" ## Going further ## COOP2of5 fails also with the same error TODO: Fix at the same time or open another bug -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |victor.grousset@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 --- Comment #1 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- ## Reproduction ## This is an oversimplification of a full patron card setup used in production. 1. Create a batch with 1 patron 2. Create a layout and set the name "Print card number as barcode" "Barcode type:" to "Code 39" 3. Create a card template without filling anything 4. Export the batch using the layout and template 5. You should have a white page with a barcode And no errors in the relevant log file This show that this setup isn't completely bogus (although Code 39 is the only type working) 6. Layout: set "Barcode type:" to Industrial2of5 7. Export the batch 8. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" ## going further ## COOP2of5 fails also with the same error TODO: Fix at the same time or open another bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I looked at http://manpages.org/pdfreusebarcode/3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 --- Comment #3 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Thanks Fridolin :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron card creator: |Patron card creator: |layout: Industrial2of5 |layouts Industrial2of5 and |broken with "Invalid |COOP2of5 broken with error |Characters" error |"Invalid Characters" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 --- Comment #4 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 70913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70913&action=edit Bug 20084: fix Industrial2of5 and COOP2of5 patron card layouts == Test plan == This is an oversimplification of a full patron card setup used in production. 1. Create a batch with 1 patron 2. Create a layout and set the name "Print card number as barcode" "Barcode type:" to "Code 39" 3. Create a card template without filling anything 4. Export the batch using the layout and template 5. You should have a white page with a barcode And no errors in the relevant log file This show that this setup isn't completely bogus (although Code 39 is the only type working...) 6. Layout: set "Barcode type:" to Industrial2of5 7. Export the batch 8. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 9. Layout: set "Barcode type:" to COOP2of5 10. Export the batch 11. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 12. Apply this patch 13. Retry with both non-working patches 1. You should have a white page with a barcode 2. And no errors in the relevant log file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- == Going further, not confirmed or not fixed here == Someone interested might want to check issues with 2 other types. 1. "Code 39 + Modulo10" doesn't seem to work Although "Code 39" and "Code 39 + Modulo43" work. Might be my test setup. 2. EAN13 barcodes doesn't seem to work. C4::Patroncards::Patroncard->draw_barcode() has an if-elsif for all types but EAN13. C4/Labels/Label.pm has an elsif for EAN13 This is suspicious! I tried to the copy it to Patroncard but got an Invalid Length error. With the quick solution falling and having no idea what was I doing, Ctrl-Z was spammed and these regretful words were written. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70913|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 70914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70914&action=edit Bug 20084: fix Industrial2of5 and COOP2of5 patron card layouts == Test plan == This is an oversimplification of a full patron card setup used in production. 1. Create a batch with 1 patron 2. Create a layout and set the name "Print card number as barcode" "Barcode type:" to "Code 39" 3. Create a card template without filling anything 4. Export the batch using the layout and template 5. You should have a white page with a barcode And no errors in the relevant log file This show that this setup isn't completely bogus (although Code 39 is the only type working...) 6. Layout: set "Barcode type:" to Industrial2of5 7. Export the batch 8. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 9. Layout: set "Barcode type:" to COOP2of5 10. Export the batch 11. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 12. Apply this patch 13. Retry with both non-working patches 1. You should have a white page with a barcode 2. And no errors in the relevant log file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 --- Comment #7 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Fixed quotes not needed anymore "*$params{barcode_data}" → $params{barcode_data} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76760&action=edit Bug 20084: Fix Industrial2of5 and COOP2of5 patron card layouts == Test plan == This is an oversimplification of a full patron card setup used in production. 1. Create a batch with 1 patron 2. Create a layout and set the name "Print card number as barcode" "Barcode type:" to "Code 39" 3. Create a card template without filling anything 4. Export the batch using the layout and template 5. You should have a white page with a barcode And no errors in the relevant log file This show that this setup isn't completely bogus (although Code 39 is the only type working...) 6. Layout: set "Barcode type:" to Industrial2of5 7. Export the batch 8. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 9. Layout: set "Barcode type:" to COOP2of5 10. Export the batch 11. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 12. Apply this patch 13. Retry with both non-working patches 1. You should have a white page with a barcode 2. And no errors in the relevant log file Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Updating severity too - not being able to print is not good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76760|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 76883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76883&action=edit Bug 20084: Fix Industrial2of5 and COOP2of5 patron card layouts == Test plan == This is an oversimplification of a full patron card setup used in production. 1. Create a batch with 1 patron 2. Create a layout and set the name "Print card number as barcode" "Barcode type:" to "Code 39" 3. Create a card template without filling anything 4. Export the batch using the layout and template 5. You should have a white page with a barcode And no errors in the relevant log file This show that this setup isn't completely bogus (although Code 39 is the only type working...) 6. Layout: set "Barcode type:" to Industrial2of5 7. Export the batch 8. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 9. Layout: set "Barcode type:" to COOP2of5 10. Export the batch 11. You should have a white page with no barcode And errors in the relevant log file "Invalid Characters" This is the bug. 12. Apply this patch 13. Retry with both non-working patches 1. You should have a white page with a barcode 2. And no errors in the relevant log file Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #70914|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Fairly trivial fix, I can't find any regressions and the QA scripts pass.. i'd love to see accompanying tests, but that can wait as we're in C4. Passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x, will be in 17.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Code 39 + Modulo43 is still not working for me in 16.11 and 17.11. Could someone confirm? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Filed a new bug 21123. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 --- Comment #17 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- (In reply to Katrin Fischer from comment #15)
Code 39 + Modulo43 is still not working for me in 16.11 and 17.11. Could someone confirm?
Tried the test plan with "Code 39 + Modulo43" and it doesn't work :( Nor Modulo 10 but that was already the case before. Either I got confused when trying "Code 39 + Modulo43" or something else happened. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21123 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #18 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I choose no to push to 17.05.x Continues on Bug 21123. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org