[Bug 43320] New: Don't repeat a quoted search with more quotes when no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 Bug ID: 43320 Summary: Don't repeat a quoted search with more quotes when no results Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- On bug 31213 we added a fallback quoted search when no results were found. A side effect here is that a quoted phrase that has no results, will then repeat the search quoted, which has the effect of an unquoted search, and will return items that have the terms, but not the phrase. Before repeating the search, we should check if the search is already quoted, and not search again if so. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31213 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213 [Bug 31213] When performing a basic search with no results, repeat the search with term quoted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 203737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203737&action=edit Bug 43320: Don't quoted already quoted searches and add feedback Bug 31213 added a quoted search when no results were found, this patch builds on that to: 1 - Notify the user when their search is repeated quoted 2 - Not repeat a search when already quoted To test: 0 - Set system preferences RedirectToSoleResult to 'Don't redirect' IntranetAddMastheadLibraryPulldown to Show IntranetCatalogSearchPulldown to Show 1 - Add the sample records to your catalog 2 - Search for the quoted phrase "happy family big" in the 'title' index 3 - Note you get a result 4 - Check the record - the phrase is not found, but the record contains all the terms 5 - Search for the unquoted phrase: 6:20 man 6 - Confirm search is quoted and result found 7 - Apply patch, restart all 8 - Repeat 5 9 - Confirm you are now told search was quoted and result found 10 - Repeat 2 11 - Confirm no result found, no notice of repeated search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 203738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203738&action=edit Bug 43320: OPAC adjustments Similar test plan, but on the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 203739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203739&action=edit Test records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203737|0 |1 is obsolete| | Attachment #203738|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 204785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204785&action=edit Bug 43320: Don't quoted already quoted searches and add feedback Bug 31213 added a quoted search when no results were found, this patch builds on that to: 1 - Notify the user when their search is repeated quoted 2 - Not repeat a search when already quoted To test: 0 - Set system preferences RedirectToSoleResult to 'Don't redirect' IntranetAddMastheadLibraryPulldown to Show IntranetCatalogSearchPulldown to Show 1 - Add the sample records to your catalog 2 - Search for the quoted phrase "happy family big" in the 'title' index 3 - Note you get a result 4 - Check the record - the phrase is not found, but the record contains all the terms 5 - Search for the unquoted phrase: 6:20 man 6 - Confirm search is quoted and result found 7 - Apply patch, restart all 8 - Repeat 5 9 - Confirm you are now told search was quoted and result found 10 - Repeat 2 11 - Confirm no result found, no notice of repeated search Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 204786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204786&action=edit Bug 43320: OPAC adjustments Similar test plan, but on the OPAC Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@openfifth.c |y.org |o.uk Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204785|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204786|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 204842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204842&action=edit Bug 43320: Don't quoted already quoted searches and add feedback Bug 31213 added a quoted search when no results were found, this patch builds on that to: 1 - Notify the user when their search is repeated quoted 2 - Not repeat a search when already quoted To test: 0 - Set system preferences RedirectToSoleResult to 'Don't redirect' IntranetAddMastheadLibraryPulldown to Show IntranetCatalogSearchPulldown to Show 1 - Add the sample records to your catalog 2 - Search for the quoted phrase "happy family big" in the 'title' index 3 - Note you get a result 4 - Check the record - the phrase is not found, but the record contains all the terms 5 - Search for the unquoted phrase: 6:20 man 6 - Confirm search is quoted and result found 7 - Apply patch, restart all 8 - Repeat 5 9 - Confirm you are now told search was quoted and result found 10 - Repeat 2 11 - Confirm no result found, no notice of repeated search Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 204843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204843&action=edit Bug 43320: OPAC adjustments Similar test plan, but on the OPAC Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 204844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204844&action=edit Bug 43320: (QA follow-up) Add html filter and fix translatability Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 --- Comment #9 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43320 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.04 released in| | Status|Pushed to main |Pushed to stable Keywords|rel_26_05_candidate | CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- backported to 26.05.x for upcoming 26.05.04 Thanks all! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org