https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68855&action=edit Bug 19549 - Reserve Slip prints first found hold when patron has multiple holds on a biblio In C4/Reserves.pm the ReserveSlip function uses this call to get the reserve: 1982 my $hold = Koha::Holds->search({biblionumber => $biblionumber, borrowernumber => $borrowernumber })->next; If a patron has multiple holds there is no way to know if we have the correct one. This function should be updated to take an itemnumber as well and all calls updated. Test Plan: 1) Apply this patch 2) Capture some holds, ensure the correct hold was caught and printed in the notice 3) prove t/db_dependent/Reserves.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549 Jason Palmer <jpalmer@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpalmer@switchinc.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549 --- Comment #3 from Jason Palmer <jpalmer@switchinc.org> --- (In reply to Caroline Cyr La Rose from comment #2)

Is this for multiple holds on the same biblio?

Yes. Multiple holds for same bib. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Testing this with a library at the moment, will sign off if it works. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |victor.grousset@biblibre.co | |m --- Comment #5 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Conflicts: Bug 19549 - Reserve Slip prints first found hold when patron has multiple holds on a biblio 68855 - Bug 19549 - Reserve Slip prints first found hold when patron has multiple holds on a biblio Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19549 - Reserve Slip prints first found hold when patron has multiple holds on a biblio Using index info to reconstruct a base tree... M C4/Reserves.pm M circ/circulation.pl M circ/hold-transfer-slip.pl M circ/returns.pl M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt M koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt M t/db_dependent/Reserves.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Reserves.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging circ/returns.pl CONFLICT (content): Merge conflict in circ/returns.pl Auto-merging circ/hold-transfer-slip.pl Auto-merging circ/circulation.pl Auto-merging C4/Reserves.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 19549 - Reserve Slip prints first found hold when patron has multiple holds on a biblio The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19549---Reserve-Slip-prints-first-found-hold-w-T4NFp1.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68855|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72700&action=edit Bug 19549 - Reserve Slip prints first found hold when patron has multiple holds on a biblio In C4/Reserves.pm the ReserveSlip function uses this call to get the reserve: 1982 my $hold = Koha::Holds->search({biblionumber => $biblionumber, borrowernumber => $borrowernumber })->next; If a patron has multiple holds there is no way to know if we have the correct one. This function should be updated to take an itemnumber as well and all calls updated. Test Plan: 1) Apply this patch 2) Capture some holds, ensure the correct hold was caught and printed in the notice 3) prove t/db_dependent/Reserves.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Upping severity, would be nice to get some attention on this -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 17561 *** -- You are receiving this mail because: You are watching all bug changes.