[Bug 12915] New: Convert checkouts table to ajax datatable [3.16.x], AllowRenewalLimitOverride crashes datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 Bug ID: 12915 Summary: Convert checkouts table to ajax datatable [3.16.x], AllowRenewalLimitOverride crashes datatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: olli-antti.kivilahti@jns.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 31570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31570&action=edit hotfix to this permission non-testing issue! when user doesn't have the permission. TO REPLICATE:: load circ/circulate.pl with a user with only the following permissions: circulate_remaining_permissions catalogue observe checkouts and holds not loading. Actually this crashes all javascript on the page! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31570|0 |1 is obsolete| | --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 31571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31571&action=edit hotfix to this permission non-testing issue! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Assignee|koha-bugs@lists.koha-commun |olli-antti.kivilahti@jns.fi |ity.org | Severity|enhancement |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11703 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 31575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31575&action=edit [Signed-off] Bug 12915 - Convert checkouts table to ajax datatable [3.16.x], AllowRenewalLimitOverride crashes datatable when user doesn't have the permission. TO REPLICATE:: load circ/circulate.pl with a user with only the following permissions: circulate_remaining_permissions catalogue observe checkouts and holds not loading. Actually this crashes all javascript on the page! Reproduced bug without patch. Applied patch, page displays as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12878 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12811 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 --- Comment #3 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- There is another similar issue in members/moremember.tt template (I'm not 100% sure it does affect 3.16.x branch as well - it most likely does, but I only eyeballed 3.16.x code to confirm this, without doing any actual tests in that branch). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31571|0 |1 is obsolete| | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this is almost a duplicate to bug 12878, but solving it differently. Kyle, could you take a look please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 12878 *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #4)
I think this is almost a duplicate to bug 12878, but solving it differently. Kyle, could you take a look please?
It is a duplicate. This patch only fixes circulation.pl while the other patch fixes both circulation.pl and moremember.pl. Kyle -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Furthermore, I know there is a third duplicate on bugzilla somewhere that is also signed off. It will probably be the one to make it into master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Any chance to clear up that mess a bit? :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 --- Comment #9 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Don't push this push the other one. Clear enough? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, it appears we have 3 patches for this - bug 12811 (pqa), bug 12920 and bug 12915) - and are probably going with 12811 plus follow-up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 --- Comment #11 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- Hmm, Bug 12915 seems to be not an exact duplicate (triplicate? ;) for Bug 12811 / Bug 12878; it has some additional good stuff in it, which is not included in 12811 nor in the followup in Bug 12920 (= fix for missing semicolon in koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc). Could we get strings.inc fix moved somewhere else (maybe to the separate bug report, if that would not be too much trouble ?) - I allready tested this fix, but after 12915 got marked as duplicate, there is no longer any place to sign it off.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12915 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jacek - thx for noticing :) Could you file a separate bug maybe? and link it to bug 12811 and the one we want to take the fix from? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org