[Bug 32103] New: Can't focus on content field in HTML customizations with mouse click ( CodeMirror )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Bug ID: 32103 Summary: Can't focus on content field in HTML customizations with mouse click ( CodeMirror ) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Go to HTML customization, News, or Pages and make a new entry using the text editor ( CodeMirror ) 2. Trying using your mouse to focus on the content field. You cannot gain focus. 3. I can use my tab key to focus on the field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- I can focus with my mouse but it is difficult the CodeMirror-wrap is only as wide as the content, so when there is no content it is very small. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Ahh, it's because the list element now uses flex. Perhaps this particular content should not do that. We can remedy it by removing the rows class. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 143153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143153&action=edit Bug 32103: Remove flex from tab-content list elements To test: 1. Go to HTML customization, News, or Pages and make a new entry using the text editor ( CodeMirror ) 2. It is hard to focus on the Content field because the wrapper width is very small. 3. Apply patch and try again 4. The CodeMirror wrapper width should be normal again. 5. Check the other language tabs. 6. Also test the WYSIWYG editor, it should also be normal. Note: I added some CSS to make the labels appear bold. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't focus on content |Content field in HTML |field in HTML |customizations is too |customizations with mouse |narrow ( CodeMirror ) |click ( CodeMirror ) | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143153|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143736&action=edit Bug 32103: Remove flex from tab-content list elements To test: 1. Go to HTML customization, News, or Pages and make a new entry using the text editor ( CodeMirror ) 2. It is hard to focus on the Content field because the wrapper width is very small. 3. Apply patch and try again 4. The CodeMirror wrapper width should be normal again. 5. Check the other language tabs. 6. Also test the WYSIWYG editor, it should also be normal. Note: I added some CSS to make the labels appear bold. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143736|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143827&action=edit Bug 32103: Remove flex from tab-content list elements To test: 1. Go to HTML customization, News, or Pages and make a new entry using the text editor ( CodeMirror ) 2. It is hard to focus on the Content field because the wrapper width is very small. 3. Apply patch and try again 4. The CodeMirror wrapper width should be normal again. 5. Check the other language tabs. 6. Also test the WYSIWYG editor, it should also be normal. Note: I added some CSS to make the labels appear bold. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32103 Bug 32103 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org