https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30422 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30419 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30419 [Bug 30419] Convert authority detail page tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30422 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 132800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132800&action=edit Bug 30422: Authorities editor update broke the feature added by Bug 20154 This patch corrects JavaScript in authorities templates so that clicking "Edit" on the authority detail page will take you to the authority edit page while keeping the same tab open. This patch also corrects the JavaScript which should have been automatically moving the cursor focus to the first form field when switching tabs in the editor. To test, apply the patch and locate an authority record in your catalog. - Click any of the numbered tabs besides tab 0. - Choose "Edit record" from the "Edit" dropdown menu. - When the authorities edit page loads the same tab should be preselected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30422 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #2 from David Nind <david@davidnind.com> --- A couple of things noted when testing: - If you are on tab 0 and go to edit, it opens in tab 8 (without the tab 8 highlighted) - It jumps to the first field used in the tab for the record (for example: tab 6 for authority record #98 - it jumps down to field 667, but it is not focused on that field) - There is a noticeable delay for me when you click edit: it jumps to the first field with a value for the tab, then hides the fields not in that tab (not sure that is the best way to describe this) - When switching tabs and if the first fields are collapsed, then it looks slightly odd having the focus on the indicator field. But I guess there is no better way to do this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30422 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132800|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134822&action=edit Bug 30422: Authorities editor update broke the feature added by Bug 20154 This patch corrects JavaScript in authorities templates so that clicking "Edit" on the authority detail page will take you to the authority edit page while keeping the same tab open. This patch also corrects the JavaScript which should have been automatically moving the cursor focus to the first form field when switching tabs in the editor. This patch also adds the "Section" headings which are present in the basic cataloging editor but were not added here at the time of the page's tabs revision. To test, apply the patch and locate an authority record in your catalog. - Without changing tabs, choose "Edit record" from the "Edit" dropdown menu." - The authorities editor should load and display the "Section 0" tab. - Return to the authority detail page and select a tab besides tab 0. - Click back to tab 0. Editing the record at this point should open the editor to Section 0. - Return to the authority detail page. - Click any of the numbered tabs besides tab 0. - Choose "Edit record" from the "Edit" dropdown menu. - When the authorities edit page loads the same tab should be preselected. - Test that when you switch tabs in the authority editor the cursor focus is automatically moved to the first visible input. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30422 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134822|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 134835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134835&action=edit Bug 30422: Authorities editor update broke the feature added by Bug 20154 This patch corrects JavaScript in authorities templates so that clicking "Edit" on the authority detail page will take you to the authority edit page while keeping the same tab open. This patch also corrects the JavaScript which should have been automatically moving the cursor focus to the first form field when switching tabs in the editor. This patch also adds the "Section" headings which are present in the basic cataloging editor but were not added here at the time of the page's tabs revision. To test, apply the patch and locate an authority record in your catalog. - Without changing tabs, choose "Edit record" from the "Edit" dropdown menu." - The authorities editor should load and display the "Section 0" tab. - Return to the authority detail page and select a tab besides tab 0. - Click back to tab 0. Editing the record at this point should open the editor to Section 0. - Return to the authority detail page. - Click any of the numbered tabs besides tab 0. - Choose "Edit record" from the "Edit" dropdown menu. - When the authorities edit page loads the same tab should be preselected. - Test that when you switch tabs in the authority editor the cursor focus is automatically moved to the first visible input. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30422 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134835|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134956&action=edit Bug 30422: Authorities editor update broke the feature added by Bug 20154 This patch corrects JavaScript in authorities templates so that clicking "Edit" on the authority detail page will take you to the authority edit page while keeping the same tab open. This patch also corrects the JavaScript which should have been automatically moving the cursor focus to the first form field when switching tabs in the editor. This patch also adds the "Section" headings which are present in the basic cataloging editor but were not added here at the time of the page's tabs revision. To test, apply the patch and locate an authority record in your catalog. - Without changing tabs, choose "Edit record" from the "Edit" dropdown menu." - The authorities editor should load and display the "Section 0" tab. - Return to the authority detail page and select a tab besides tab 0. - Click back to tab 0. Editing the record at this point should open the editor to Section 0. - Return to the authority detail page. - Click any of the numbered tabs besides tab 0. - Choose "Edit record" from the "Edit" dropdown menu. - When the authorities edit page loads the same tab should be preselected. - Test that when you switch tabs in the authority editor the cursor focus is automatically moved to the first visible input. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30422 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.