[Bug 40792] New: Do not fill hold requests when issuing non-holdable items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Bug ID: 40792 Summary: Do not fill hold requests when issuing non-holdable items Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andreas.jonsson@kreablo.se QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com It is a regression from bug 38650 that issuing non-holdable items now fills holds. The subroutine C4::Reserves::MoveReserve would previously only do anything if there where a hold that had been filled with the specified item, which mean that the item issued was holdable. But bug 38650 opened up the possibility to fill the borrowers hold even if the issued item is not holdable. I suggest a check that the item issued is holdable if the biblio is reserved by the borrower. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Hans Pålsson <hans.palsson@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hans.palsson@hkr.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Stefan Berndtsson <stefan.berndtsson@ub.gu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stefan.berndtsson@ub.gu.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Depends on| |38650 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38650 [Bug 38650] We should only fill title level or specific item holds when a patron checks out an item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 --- Comment #1 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 186376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186376&action=edit Bug 40792: Do not fill holds with non-reservable items. Verify that the item issued is reservable before filling the patron's hold. 1. Go to circulation and fine rules and add a rule for an itemtype that can be issued, for instance "Maps" in koha-testing-docker, with 0 in the column "Holds per record (count)". 2. Go to any biblio where there are items that may be reserved. Create an item with the above created item type and give it a barcode, e.g., 'tempbarcode'. 3. Place a hold for any patron (for instance 23529000120056 in koha-testing-docker). 4. Issue the item 'tempbarcode' to the patron with the hold. 5. Make sure the hold remains. 6. Create a new hold to another borrower (for instance 23529000197047), and make sure this new hold has priority 2. 7. Return the item 'tempbarcode' and issue it to the second patron. 8. Make sure both holds remain. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Hans Pålsson <hans.palsson@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Hans Pålsson <hans.palsson@hkr.se> --- Tested in production environment, works as expected. Great work! Note: this is to enable patrons to have a title level reservation on a title that has multiple item types, one type that is allowed to fill a hold (normal loan) and one type that is not allowed to fill a hold (might be short-time loan etc). Patrons must be able to keep their title level reservation on normal loan item type while they can check out the short-time item type. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- There are several conflicts. CONFLICT (content): Merge conflict in C4/Reserves.pm Please rebase. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186376|0 |1 is obsolete| | --- Comment #4 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 186565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186565&action=edit Bug 40792: Do not fill holds with non-reservable items. Verify that the item issued is reservable before filling the patron's hold. 1. Go to circulation and fine rules and add a rule for an itemtype that can be issued, for instance "Maps" in koha-testing-docker, with 0 in the column "Holds per record (count)". 2. Go to any biblio where there are items that may be reserved. Create an item with the above created item type and give it a barcode, e.g., 'tempbarcode'. 3. Place a hold for any patron (for instance 23529000120056 in koha-testing-docker). 4. Issue the item 'tempbarcode' to the patron with the hold. 5. Make sure the hold remains. 6. Create a new hold to another borrower (for instance 23529000197047), and make sure this new hold has priority 2. 7. Return the item 'tempbarcode' and issue it to the second patron. 8. Make sure both holds remain. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 --- Comment #5 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Rebased on main. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hi, This patch changes a module (Reserves) and does not add tests. Please add unit tests. And verify that your change does not break other tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andreas.jonsson@kreablo.se |ity.org | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- And please fill Assignee next time :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Steve, OSLRI, USA <sspohn@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bywater@oslri.net, | |sspohn@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 rpalermo@oslri.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rpalermo@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I believe this also needs a system preference or a switch in the circulation rules. The intention on 38650 was to fill the hold regardless of the item's holdability. We have some libraries who maintain a 'lucky day' collection of popular books which cannot have holds placed directly, however, a patron having a 'lucky day' can find the book they want on the shelf and check it out - when doing so, the hold is expected to be filled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 --- Comment #9 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- (In reply to Nick Clemens (kidclamp) from comment #8)
I believe this also needs a system preference or a switch in the circulation rules. The intention on 38650 was to fill the hold regardless of the item's holdability.
We have some libraries who maintain a 'lucky day' collection of popular books which cannot have holds placed directly, however, a patron having a 'lucky day' can find the book they want on the shelf and check it out - when doing so, the hold is expected to be filled
Maybe a boolean parameter on the itemtype: "may fill reservations"? Or even a circulation rule? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 --- Comment #10 from Steve, OSLRI, USA <sspohn@oslri.net> --- I could see both sides of this... that is wanting to satisfy the hold and not wanted to satisfy the hold. I think the most elegant way to do this would be at the itemtype level. Just a true/false that allows an itemtype to fill a hold. That would allow a library or consortia to take a more nuanced, situational approach. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Ilona R <hattara@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hattara@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Sarah Cornell <sbcornell@cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell@cityofportsmouth. | |com --- Comment #11 from Sarah Cornell <sbcornell@cityofportsmouth.com> --- I can also see both behaviors being desirable, depending on the library. My library does NOT want our short term loans on a special item item to fill the title-level hold. The library decides whether the item type is holdable in the circulation rule, so I think the obvious place to put the option to fill or not fill title-level holds is right there in the circulation rule. Terminology will have to be selected carefully, though! Something like Andreas says: "May fill holds"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41267 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 --- Comment #12 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Filed bug 41267 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 --- Comment #13 from carthur@slolibrary.org <carthur@slolibrary.org> --- +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #14 from David Cook <dcook@prosentient.com.au> --- Sounds like this is the opposite of bug 20955 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20955 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #14)
Sounds like this is the opposite of bug 20955 ?
Or maybe not. Holds is fun... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to David Cook from comment #15)
(In reply to David Cook from comment #14)
Sounds like this is the opposite of bug 20955 ?
Or maybe not. Holds is fun...
Related to 20955, certainly. Getting overly detailed for any passing reader: I've found it helpful in these bugs to think about holds as having three steps: placing a hold, triggering the hold at checkin to capture an item, and then fulfilling the hold at checkout. Bug 20955 is about when we should or should not trigger a hold and capture an item at checkin. Currently we check the holds rules/policies at checkin and will not trigger a hold that violates those rules/policies (even though one may be able to place a hold that violates those rules/policies if AllowHoldPolicyOverride is enabled). This bug is about whether or not a hold gets fulfilled when an item gets checked out. As far as I know, currently a hold will always get fulfilled at checkout if there is a waiting item attached. This is good and should not change. But there's some difference of opinion among libraries about what should happen when a patron has a bib-level hold with no item waiting and checks out a non-holdable item attached to that bib. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin.carnes@ub.lu.se --- Comment #17 from Kevin Carnes <kevin.carnes@ub.lu.se> --- In testing we found that item-level holds would not be filled nor would records where only one hold per a record was allowed, even though the patron could reserve the item. CanItemBeReserved has an option for ignore_hold_counts that will allow these to be filled. I'm not sure if this sufficient or if each status need to be handled separately. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40792 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org