[Bug 33048] New: Empty email link on error page when opac login not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 Bug ID: 33048 Summary: Empty email link on error page when opac login not allowed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Steps to reproduce: 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=opacuserlogin 2. Set to "Don't allow" 3. In an incognito window, go to http://localhost:8080/cgi-bin/koha/opac-reportproblem.pl 4. Note that the "mailto" link for "Email" is empty. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 147186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147186&action=edit Bug 33048: Fix email link on error page when opac login not allowed This change replaces a non-existent variable with the KohaAdminEmailAddress syspref. Test plan: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=opacuserlogin 2. Set to "Don't allow" 3. In an incognito window, go to http://localhost:8080/cgi-bin/koha/opac-reportproblem.pl 4. Note that the "mailto" link for "Email" has the value from KohaAdminEmailAddress syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147186|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 147227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147227&action=edit Bug 33048: Fix email link on error page when opac login not allowed This change replaces a non-existent variable with the KohaAdminEmailAddress syspref. Test plan: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=opacuserlogin 2. Set to "Don't allow" 3. In an incognito window, go to http://localhost:8080/cgi-bin/koha/opac-reportproblem.pl 4. Note that the "mailto" link for "Email" has the value from KohaAdminEmailAddress syspref Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #3 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described. Thanks! The only thing I noticed was that it isn't decoded, so on mouseover it shows the email address as %40 instead of @. I'm not convinced it matters as all of the functionality is there. Clicking on the link launches a new email to the correct recipient. If you don't use a default mail client, copying/pasting the link also works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147227|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147401&action=edit Bug 33048: Fix email link on error page when opac login not allowed This change replaces a non-existent variable with the KohaAdminEmailAddress syspref. Test plan: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=opacuserlogin 2. Set to "Don't allow" 3. In an incognito window, go to http://localhost:8080/cgi-bin/koha/opac-reportproblem.pl 4. Note that the "mailto" link for "Email" has the value from KohaAdminEmailAddress syspref Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.11 released in| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04,22.05.11 |23.05.00,22.11.04,22.05.11, released in| |21.11.19 Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |arthur.suzuki@biblibre.com --- Comment #8 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.19 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Empty email link on error |Empty email link on error |page when opac login not |page when OPAC login not |allowed |allowed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org