https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123579&action=edit Bug 28824: Unit test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm confused.. I can't seem to get the unit test to fail.. but in real life testing it does fail without the fix. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- And this one might change the game under Plack: unless ($sth = C4::Context->dbh->prepare($query)) { -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #7)

Even when I do:

- 'aqbasket' => $basketno, + # 'aqbasket' => $basketno,

I still have the basket name in the test output?

I had a library claim once the wrong notice would be sent, if the basket name was the same... now I wonder...? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #7)

Even when I do:

- 'aqbasket' => $basketno, + # 'aqbasket' => $basketno,

I still have the basket name in the test output?

Debugging Letters :) The info is in the $repeat and is filled in when reaching the repeat no enclosing tags block. my vendor|John Smith|<<aqbasket.basketname>>|<order>Ordernumber <<aqorders.ordernumber>> (<<biblio.title>>) (<<aqorders.quantity>> ordered)</order>my vendor|J ohn Smith|Named basket|<order>Ordernumber 114 (Silence in the library) (1 ordered)</order> In that block basketname is replaced. And not via $tables ! This essentially means that the second patch does nothing for the orderacquistion notice. The unit test shows that you can fill basketname via $repeat but actually has no real added value. FQA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #3)

I'm confused.. I can't seem to get the unit test to fail.. but in real life testing it does fail without the fix.

Can you detail how you get the problem "in real life testing"? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #12)

Hit by this again at our most recent upgrade...

If you want to use aqbasket in the title of the email without this patch you can't.

Martin, status is still FQA. And patch does not apply: Bug 28824 - Errant variable declaration in C4::Letters 123579 - Bug 28824: Unit test 123580 - Bug 28824: Fix for variable declaration scope Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 28824: Unit test Using index info to reconstruct a base tree... M t/db_dependent/Letters.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Letters.t CONFLICT (content): Merge conflict in t/db_dependent/Letters.t error: Failed to merge in the changes. Patch failed at 0001 Bug 28824: Unit test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28824 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** This bug has been marked as a duplicate of bug 31587 *** -- You are receiving this mail because: You are watching all bug changes.