https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34135 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152768&action=edit Mockup Like this, but better -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34135 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34135 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I wanted to offer this patch for testing to see if other agreed with this change. I think it could be helpful for quick recognition of context for circulation desk users especially. If folks don't like the additional icons, an alternative would be to show the icon only if the browser width was narrow enough that the form label text is hidden. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34135 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- I love it! Leaving NSO for another opinion, but adding my support -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34135 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152788|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 153108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153108&action=edit Bug 34135: Show the icons for selected tab to the left of the search bar in the staff interface This patch modifies header search forms so that the form label has the same icon used by the "tab" link. The patch also improves the responsive behavior of the header search by using the icon as the form label when the browser window is narrow enough to hide the label text. I've added the "aria-hidden" attribute to other icons in the modified templates and made the "fa-fw" class consistent for all tab icons. To test, apply the patch and rebuild the staff interface CSS. Clear your browser cache if necessary. View the header search form at various browser sizes to confirm that content is shown and hidden correctly. Test at least one page which uses each of the modified header search includes: - Staff client home page - Acquisitions -> Acquisitions home - Vendor -> - Basket -> Add to basket -> From suggestion - Contracts - Administration -> - Budgets - Currencies - Desks (with UseCirculationDesks enabled) - System preferences - Z39.50/SRU servers - Catalog advanced search - Search results - Authorities -> Authorities home - Cataloging -> Cataloging home - Circulation -> Check out - E-resource management (with ERMModule enabled) - Patrons -> Patrons home - Serials -> Serials home - Tools -> Notices Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34135 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153108|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155079&action=edit Bug 34135: Show the icons for selected tab to the left of the search bar in the staff interface This patch modifies header search forms so that the form label has the same icon used by the "tab" link. The patch also improves the responsive behavior of the header search by using the icon as the form label when the browser window is narrow enough to hide the label text. I've added the "aria-hidden" attribute to other icons in the modified templates and made the "fa-fw" class consistent for all tab icons. To test, apply the patch and rebuild the staff interface CSS. Clear your browser cache if necessary. View the header search form at various browser sizes to confirm that content is shown and hidden correctly. Test at least one page which uses each of the modified header search includes: - Staff client home page - Acquisitions -> Acquisitions home - Vendor -> - Basket -> Add to basket -> From suggestion - Contracts - Administration -> - Budgets - Currencies - Desks (with UseCirculationDesks enabled) - System preferences - Z39.50/SRU servers - Catalog advanced search - Search results - Authorities -> Authorities home - Cataloging -> Cataloging home - Circulation -> Check out - E-resource management (with ERMModule enabled) - Patrons -> Patrons home - Serials -> Serials home - Tools -> Notices Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34135 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34135 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.