[Bug 18606] New: Move rotating collections code to Koha::Object

newer
[Bug 19470] New: Add information...

older
[Bug 3150] Move emails for sending...

bugzilla-daemon＠bugs.koha-community.org

15 May 2017 15 May '17

1:47 p.m.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Bug ID: 18606 Summary: Move rotating collections code to Koha::Object Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

Show replies by date

bugzilla-daemon＠bugs.koha-community.org

15 May 15 May

1:48 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |josef.moravec@gmail.com Blocks| |15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:48 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 May 17 May

12:21 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17202 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:31 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

11:24 a.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #22 from Josef Moravec <josef.moravec@gmail.com> --- Not 100% ready, but I need some feedback. Note that the transfers subtesto to RotatingCollections.t is not passsing. I don't know how to implement item transfering in Koha::RotatingCollection module yet. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 Jun 2 Jun

12:36 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17202 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17202 [Bug 17202] Deleting a rotating collection with items should either be prohibited or items should be removed -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

10:27 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #53 from Josef Moravec <josef.moravec@gmail.com> --- I've rebased this on top of master, squashed few commits, fix issues, now it should be working and ready to test. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

28 Aug 28 Aug

12:14 a.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Needs Signoff |Failed QA --- Comment #54 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hi Josef I have one test failing in t/db_dependent/Circulation.t. I've pasted the output here: http://paste.koha-community.org/621 All other tests pass. Some notes from following the rest of your test plan: When deleting a collection, two different confirmation boxes pop up. (i know this is the behaviour before your patches) Deleting a collection with items was no different from deleting a collection without items (no error message to say the collection had items). No difference when returning an item in an untransferred collection and returning an item in a transferred collection I know the first point is the original behaviour before your patches. Unfortunately I can't test whether the second and third points are the expected behaviour because rotating collections appears to be broken for me without your patches! :) If the behaviour I've described is expected, then everything looks good. Setting to Failed QA for the failed test. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

...

Hi Josef

I have one test failing in t/db_dependent/Circulation.t. I've pasted the output here: http://paste.koha-community.org/621

All other tests pass.

Some notes from following the rest of your test plan: When deleting a collection, two different confirmation boxes pop up. (i know this is the behaviour before your patches) Deleting a collection with items was no different from deleting a collection without items (no error message to say the collection had items). No difference when returning an item in an untransferred collection and returning an item in a transferred collection

I know the first point is the original behaviour before your patches. Unfortunately I can't test whether the second and third points are the expected behaviour because rotating collections appears to be broken for me without your patches! :) If the behaviour I've described is expected, then everything looks good.

Setting to Failed QA for the failed test.

Thanks for testing! I did another rebase today. Test t/db_dependent/Circulation.t is passing form me. The double confirmation dialog was easy to fix, I am doing it in followup Ability to delete a collection with items is current behavior in master, I will fix it on another report Returning from transferred and untransferred collection is not diferrentiate in in current master too. Setting back to needs signoff -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:19 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #72 from Josef Moravec <josef.moravec@gmail.com> ---

...

Ability to delete a collection with items is current behavior in master, I will fix it on another report

It is Bug 17202 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Oct 16 Oct

7:33 a.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19470 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19470 [Bug 19470] Add information about item being in rotating collection on detail page -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

6:22 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #105 from Owen Leonard <oleonard@myacpl.org> --- Testing functionality goes without any problem, but running "prove t/db_dependent/Koha/Items.t t/db_dependent/Circu lation.t" gave this result: t/db_dependent/Circulation.t (Wstat: 65280 Tests: 42 Failed: 1) Failed test: 41 Non-zero exit status: 255 Parse errors: Bad plan. You planned 112 tests but ran 42. Also, running the QA tool highlighted some issues. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

13 Dec 13 Dec

7:44 a.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #106 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69759&action=edit Bug 18606: (followup) Make QA tools happy -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:48 a.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #107 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #105)

...

Testing functionality goes without any problem, but running "prove t/db_dependent/Koha/Items.t t/db_dependent/Circu lation.t" gave this result:

t/db_dependent/Circulation.t (Wstat: 65280 Tests: 42 Failed: 1) Failed test: 41 Non-zero exit status: 255 Parse errors: Bad plan. You planned 112 tests but ran 42.

Also, running the QA tool highlighted some issues.

Thanks for testing! I added a followup, test are passing now and QA tools return just one "warning" about pod coverage on Koha/RotatingCollection/Tracking.pm, but that is new file with no added methods, so there is nothing more to add to pod IMO. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5 Mar 5 Mar

13 Mar 13 Mar

9:52 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #141 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72816&action=edit Bug 18606: (Follow-up) Remove lines from collections_tracking referencing non existant objects -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:53 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #142 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Kyle M Hall from comment #140)

...

QA question, should you not delete 'orphaned' collections_tracking rows before adding the foreign key constraints?

Thank for testing Kyle! I added a follow-up for this -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6 Apr 6 Apr

3:15 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |alex.arnaud@biblibre.com |y.org | CC| |alex.arnaud@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:54 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #143 from Alex Arnaud <alex.arnaud@biblibre.com> --- Comment on attachment 72574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72574 Bug 18606: Database changes - Add foreign keys to collections_tracking Review of attachment 72574: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18606&attachment=72574) ----------------------------------------------------------------- ::: installer/data/mysql/kohastructure.sql @@ +969,5 @@

...

+ PRIMARY KEY (collections_tracking_id) +) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; + +ALTER TABLE `collections_tracking` + ADD CONSTRAINT `collections_tracking_ibfk_1` FOREIGN KEY (`colId`) REFERENCES `collections` (`colId`) ON DELETE CASCADE ON UPDATE CASCADE;

Why did add constraints separatly from the table creation? It seems to me that it is less readable for people wanting to quickly get the structure of the table. @@ +973,5 @@

...

+ ADD CONSTRAINT `collections_tracking_ibfk_1` FOREIGN KEY (`colId`) REFERENCES `collections` (`colId`) ON DELETE CASCADE ON UPDATE CASCADE; + +ALTER TABLE `collections_tracking` + ADD CONSTRAINT `collections_tracking_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE ON UPDATE CASCADE; +

idem -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:59 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #144 from Alex Arnaud <alex.arnaud@biblibre.com> --- Also, we lost the "reason" in error messages when adding/removing items. - Failed to add item with barcode <barcode>: Item is already in this collection => Failed to add item with barcode <barcode> - Failed to add item with barcode unknown_barcode: No item with matching barcode found => Failed to add item with barcode unknown_barcode - Failed to remove item with barcode unknown_barcode: No item with matching barcode found => Failed to remove item with barcode unknown_barcode -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:28 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

20 Sep 20 Sep

1:19 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #163 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Alex Arnaud from comment #143)

...

Comment on attachment 72574 [details] [review] Bug 18606: Database changes - Add foreign keys to collections_tracking

Review of attachment 72574 [details] [review]: -----------------------------------------------------------------

::: installer/data/mysql/kohastructure.sql @@ +969,5 @@

...
+ PRIMARY KEY (collections_tracking_id) +) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; + +ALTER TABLE `collections_tracking` + ADD CONSTRAINT `collections_tracking_ibfk_1` FOREIGN KEY (`colId`) REFERENCES `collections` (`colId`) ON DELETE CASCADE ON UPDATE CASCADE;

Why did add constraints separatly from the table creation? It seems to me that it is less readable for people wanting to quickly get the structure of the table.

No strong reason from me, fixed in follow-up. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:20 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #164 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Alex Arnaud from comment #144)

...

Also, we lost the "reason" in error messages when adding/removing items. - Failed to add item with barcode <barcode>: Item is already in this collection => Failed to add item with barcode <barcode> - Failed to add item with barcode unknown_barcode: No item with matching barcode found => Failed to add item with barcode unknown_barcode - Failed to remove item with barcode unknown_barcode: No item with matching barcode found => Failed to remove item with barcode unknown_barcode

I rebased the patches on master and now I am working on the error messages, follow-up will come soon - hopefully -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:58 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #165 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79161&action=edit Bug 18606: Fix TT filters -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

27 Oct 27 Oct

2:08 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #166 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Josef, looking through some older bugs - should this still be FQA? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 Jul 23 Jul

2:47 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 Dec 23 Dec

10:28 a.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #167 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Still hoping to move this one forward Josef? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

14 Apr 14 Apr

8:49 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17202 | Depends on| |17202 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17202 [Bug 17202] Deleting a rotating collection with items should either be prohibited or items should be removed -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10 Jan 10 Jan

2:37 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29842 [Bug 29842] Item should be removed from rotating collection when item is deleted -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

26 Apr 26 Apr

3:49 p.m.

New subject: [Bug 18606] Move rotating collections code to Koha::Object

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.

1541

Age (days ago)

3348

Last active (days ago)

List overview

Download

182 comments

1 participants

participants (1)

bugzilla-daemon＠bugs.koha-community.org