[Bug 40847] New: OAuth endpoint missing some validations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40847 Bug ID: 40847 Summary: OAuth endpoint missing some validations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com I found the endpoint would benefit from more validations on: * Provider * Interface This is not properly tested either. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40847 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40847 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40847 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 186690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186690&action=edit Bug 40847: Add input validation tests for OAuth login This patch adds tests to document the current behavior of OAuth login endpoint with missing or invalid parameters. Valitation is added for the interface parameter on the spec. Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass! Current behavior documented 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40847 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au Status|Needs Signoff |Failed QA --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I was going crazy over this one. The unit tests were passing, but I couldn't reproduce in the browser... But that's because I was going to /api/v1/public/oauth/login/test/invalid instead of /api/v1/oauth/login/test/invalid I think for api/v1/swagger/paths/oauth.yaml it can only be "staff" and for api/v1/swagger/paths/public_oauth.yaml it should only be "opac"? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org