[Bug 21058] New: Missing class for results_summary spans
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Bug ID: 21058 Summary: Missing class for results_summary spans Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: david.bourgault@inlibro.com Reporter: david.bourgault@inlibro.com QA Contact: testopia@bugs.koha-community.org Some results_summary spans have other CSS class which can be annoying when doing CSS customization. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 --- Comment #1 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 76813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76813&action=edit Bug 21058: Added HTML classes in MARC21slim2_Detail.xsl This is a very small patch. I've simply added the following classes to their respective spans in the detail XSLs for both interfaces. - in_note (773$n) - preceeding_entry_note (780$n) - succeeding_entry_note (785$n) To test: 0. Apply patch 1. Open details page of notice with a 773$n, 780$n or 785$n field 2. Inspect element. The class should be visible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 --- Comment #2 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 76814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76814&action=edit Bug 21058: Added HTML class to showRDAtag264 Adds the HTML class "rda264" to the span generated by the XSLT function showRDAtag264. To test, same as previous, using a notice with a 264 tag. Both patches only apply to MARC21. I was unsure how to name the class, so I've chose the simplest, most explicit name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Sorry to report that this patch no longer applies. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76813|0 |1 is obsolete| | Attachment #76814|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92052&action=edit Bug 21058: Added HTML classes in MARC21slim2_Detail.xsl This is a very small patch. I've simply added the following classes to their respective spans in the detail XSLs for both interfaces. - in_note (773$n) - preceeding_entry_note (780$n) - succeeding_entry_note (785$n) To test: 1. Apply patch 2. Open details page of notice with a 773$n, 780$n or 785$n field 3. Inspect element. The class should be visible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92053&action=edit Bug 21058: Added HTML class to showRDAtag264 Adds the HTML class "rda264" to the span generated by the XSLT function showRDAtag264. To test, same as previous, using a notice with a 264 tag. Both patches only apply to MARC21. I was unsure how to name the class, so I've chose the simplest, most explicit name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I re-implemented the patches but kept the original authorship. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92052|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92340&action=edit Bug 21058: Added HTML classes in MARC21slim2_Detail.xsl This is a very small patch. I've simply added the following classes to their respective spans in the detail XSLs for both interfaces. - in_note (773$n) - preceeding_entry_note (780$n) - succeeding_entry_note (785$n) To test: 1. Apply patch 2. Open details page of notice with a 773$n, 780$n or 785$n field 3. Inspect element. The class should be visible. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92053|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92341&action=edit Bug 21058: Added HTML class to showRDAtag264 Adds the HTML class "rda264" to the span generated by the XSLT function showRDAtag264. To test, same as previous, using a notice with a 264 tag. Both patches only apply to MARC21. I was unsure how to name the class, so I've chose the simplest, most explicit name. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92340|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 92723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92723&action=edit Bug 21058: Added HTML classes in MARC21slim2_Detail.xsl This is a very small patch. I've simply added the following classes to their respective spans in the detail XSLs for both interfaces. - in_note (773$n) - preceeding_entry_note (780$n) - succeeding_entry_note (785$n) To test: 1. Apply patch 2. Open details page of notice with a 773$n, 780$n or 785$n field 3. Inspect element. The class should be visible. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92341|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 92724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92724&action=edit Bug 21058: Added HTML class to showRDAtag264 Adds the HTML class "rda264" to the span generated by the XSLT function showRDAtag264. To test, same as previous, using a notice with a 264 tag. Both patches only apply to MARC21. I was unsure how to name the class, so I've chose the simplest, most explicit name. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.04 released in| | --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Small enhancement, I choose to backport Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org