http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- I'm trying to understand the purpose of this permission, myself. It seems there is no documentation on it. What I would assume it means is if it is checked, the patron can borrow. However, if this actually worked, it would mean all regular patrons would need this permission turned on. I would propose that the nature of this switch be change and read (cannot_borrow). This switch should limit the account so that it cannot be borrowed on. So, for example, if the account were a general circulation staff account, one could not check out items to this account if the permission were selected. Christopher -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|3.6 |master --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It appears that there are some references to the borrow permission in the codebase, but I am not sure about the intended functionality either: Some examples: ... basket/basket.pl: flagsrequired => { borrow => 1 }, basket/downloadcart.pl: flagsrequired => { borrow => 1 }, basket/sendbasket.pl: flagsrequired => { borrow => 1 }, basket/sendbasket.pl: flagsrequired => { borrow => 1 }, ... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Borrow Permission" is not |"Borrow Permission" is not |functional |useless and can be removed -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37382|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 37914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37914&action=edit [SIGNED OFF] Bug 7976: Remove the borrow permission The borrow permission was used but uselessly. For instance, at the opac, the flagsrequired parameter was set to 'borrow' but the 'authnotrequired' was set also (which means no auth required). At the end, this permission was used at only 1 place: for the basket, intranet side. This can be replaced with the catalogue permission (which is used to search). Test plan: 1/ Confirm that you are able to show/download/sent the cart (intranet side) with the catalogue permission. 2/ At the OPAC, you should be able to access the same pages as before with any other permissions. Concretely it is quite difficult to test this patch, you should have a look at the code. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should we also adjust the borrowres.flags for staff users who had borrows permission? Any negative side effects if we don't? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37944&action=edit Bug 7976: Update borrowers.flags The borrowers.flags values need to be updated to prevent side effects. Test plan: Set the borrow permission flags for some borrowers Execute the updatedb entry and verify the flags has been updated (-128) only for borrowers with this permission set. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37944|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 38900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38900&action=edit [SIGNED-OFF] Bug 7976: Update borrowers.flags The borrowers.flags values need to be updated to prevent side effects. Test plan: Set the borrow permission flags for some borrowers Execute the updatedb entry and verify the flags has been updated (-128) only for borrowers with this permission set. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Moved updatedatabase entry (was in wrong position) to atomicupdate with commented copy of orignal No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38900|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 38901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38901&action=edit [SIGNED-OFF] Bug 7976: Update borrowers.flags The borrowers.flags values need to be updated to prevent side effects. Test plan: Set the borrow permission flags for some borrowers Execute the updatedb entry and verify the flags has been updated (-128) only for borrowers with this permission set. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Moved updatedatabase entry (was in wrong position) to atomicupdate with commented copy of orignal No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38901|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38974&action=edit [PASSED QA] Bug 7976: Update borrowers.flags The borrowers.flags values need to be updated to prevent side effects. Test plan: Set the borrow permission flags for some borrowers Execute the updatedb entry and verify the flags has been updated (-128) only for borrowers with this permission set. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Moved updatedatabase entry (was in wrong position) to atomicupdate with commented copy of orignal No koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.