[Bug 37050] New: Add select2 to SQL report multi select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Bug ID: 37050 Summary: Add select2 to SQL report multi select Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: blawlor@clamsnet.org QA Contact: testopia@bugs.koha-community.org Bug 36545 adds select2 to improve the user experience when making multiple selections in item search. Bug 35746 adds the ability to reports to make multiple selections for SQL parameters. It would be nice for consistency and ux for the report multiselect to use select2. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 167555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167555&action=edit Bug 37050: Add select2 to SQL reports multi select This patch adds select 2 to modifies multi-select parameter fields in SQL reports to use the select2 framework. If no selections are made for a multi select parameter all values will be used by default. To test: 1. Apply patch 2. Go to Reports and create a report from SQL select * from items where homebranch in <<Libraries|branches:in>> and itype in <<Item type|itemtypes:in>> 3. Run the report making multiple selections for each parameter 4. Run the report making multiple selections for one parameter and no selections in another parameter 5. Check that the results are as you would expect 6. On the results page click 'Show SQL code' 7. Confirm that the codes are included according to your selections 8. Note that when no selections are made for a parameter all codes are used by defaut. This allows the query to run when no selections are made instead of causing an error. It allows reports to be written where a multi select parameter is optional. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 167659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167659&action=edit Run report screen Something seems wrong with the UI. This is what I'm seeing even after yarn css:build. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for looking at this Pedro! I think there is some css needed to make the little chips appear fit to the value and in line, like they do in the new item search, but I haven't been able to look much into it yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167555|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167838&action=edit Bug 37050: Add select2 to SQL reports multi select This patch adds select 2 to modifies multi-select parameter fields in SQL reports to use the select2 framework. If no selections are made for a multi select parameter all values will be used by default. To test: 1. Apply patch 2. Go to Reports and create a report from SQL select * from items where homebranch in <<Libraries|branches:in>> and itype in <<Item type|itemtypes:in>> 3. Run the report making multiple selections for each parameter 4. Run the report making multiple selections for one parameter and no selections in another parameter 5. Check that the results are as you would expect 6. On the results page click 'Show SQL code' 7. Confirm that the codes are included according to your selections 8. Note that when no selections are made for a parameter all codes are used by defaut. This allows the query to run when no selections are made instead of causing an error. It allows reports to be written where a multi select parameter is optional. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167839&action=edit Bug 37050: (follow-up) CSS and configuration tweak This follow-up tweaks the Select2 CSS so that the selected choices don't display with 100% width. The patch also removes the "closeOnSelect: false" configuration from Select2. In discussing this option for Bug 36545 more people preferred the default behavior and I think we should be consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Brendan Lawlor from comment #3)
I think there is some css needed to make the little chips appear fit
It was necessary to override some of the CSS inherited from fieldset.rows li. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167838|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 167840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167840&action=edit Bug 37050: Add select2 to SQL reports multi select This patch adds select 2 to modifies multi-select parameter fields in SQL reports to use the select2 framework. If no selections are made for a multi select parameter all values will be used by default. To test: 1. Apply patch 2. Go to Reports and create a report from SQL select * from items where homebranch in <<Libraries|branches:in>> and itype in <<Item type|itemtypes:in>> 3. Run the report making multiple selections for each parameter 4. Run the report making multiple selections for one parameter and no selections in another parameter 5. Check that the results are as you would expect 6. On the results page click 'Show SQL code' 7. Confirm that the codes are included according to your selections 8. Note that when no selections are made for a parameter all codes are used by defaut. This allows the query to run when no selections are made instead of causing an error. It allows reports to be written where a multi select parameter is optional. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167839|0 |1 is obsolete| | --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 167841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167841&action=edit Bug 37050: (follow-up) CSS and configuration tweak This follow-up tweaks the Select2 CSS so that the selected choices don't display with 100% width. The patch also removes the "closeOnSelect: false" configuration from Select2. In discussing this option for Bug 36545 more people preferred the default behavior and I think we should be consistent. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167840|0 |1 is obsolete| | Attachment #167841|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169750&action=edit Bug 37050: Add select2 to SQL reports multi select This patch adds select 2 to modifies multi-select parameter fields in SQL reports to use the select2 framework. If no selections are made for a multi select parameter all values will be used by default. To test: 1. Apply patch 2. Go to Reports and create a report from SQL select * from items where homebranch in <<Libraries|branches:in>> and itype in <<Item type|itemtypes:in>> 3. Run the report making multiple selections for each parameter 4. Run the report making multiple selections for one parameter and no selections in another parameter 5. Check that the results are as you would expect 6. On the results page click 'Show SQL code' 7. Confirm that the codes are included according to your selections 8. Note that when no selections are made for a parameter all codes are used by defaut. This allows the query to run when no selections are made instead of causing an error. It allows reports to be written where a multi select parameter is optional. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169751&action=edit Bug 37050: (follow-up) CSS and configuration tweak This follow-up tweaks the Select2 CSS so that the selected choices don't display with 100% width. The patch also removes the "closeOnSelect: false" configuration from Select2. In discussing this option for Bug 36545 more people preferred the default behavior and I think we should be consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |pedro.amorim@ptfs-europe.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169750|0 |1 is obsolete| | --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 169818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169818&action=edit Bug 37050: Add select2 to SQL reports multi select This patch adds select 2 to modifies multi-select parameter fields in SQL reports to use the select2 framework. If no selections are made for a multi select parameter all values will be used by default. To test: 1. Apply patch 2. Go to Reports and create a report from SQL select * from items where homebranch in <<Libraries|branches:in>> and itype in <<Item type|itemtypes:in>> 3. Run the report making multiple selections for each parameter 4. Run the report making multiple selections for one parameter and no selections in another parameter 5. Check that the results are as you would expect 6. On the results page click 'Show SQL code' 7. Confirm that the codes are included according to your selections 8. Note that when no selections are made for a parameter all codes are used by defaut. This allows the query to run when no selections are made instead of causing an error. It allows reports to be written where a multi select parameter is optional. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169751|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 169819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169819&action=edit Bug 37050: (follow-up) CSS and configuration tweak This follow-up tweaks the Select2 CSS so that the selected choices don't display with 100% width. The patch also removes the "closeOnSelect: false" configuration from Select2. In discussing this option for Bug 36545 more people preferred the default behavior and I think we should be consistent. PA amended commit message: `yarn css:build` is required to test these CSS changes Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am unsure about the small conflict here. It's about this line: <option value="null" hidden></option> Previously changed by bug 37077. Can you please have a look and rebase yourself since you wrote the other patch too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #15 from Brendan Lawlor <blawlor@clamsnet.org> --- *** Bug 37886 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169818|0 |1 is obsolete| | --- Comment #16 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 171340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171340&action=edit Bug 37050: Add select2 to SQL reports multi select This patch adds select 2 to multi-select parameter fields in SQL reports. If no selections are made for a multi-select all authorised values will be used by default. This allows reports to be written where a multi select parameter is optional. To test: 1. Apply patch 2. Go to Reports and create a report from SQL select * from items where homebranch in <<Libraries|branches:in>> and itype in <<Item type|itemtypes:in>> 3. Run the report making multiple selections for each parameter and making single selections for each parameter 4. Run the report making multiple selections for one parameter and no selections in another parameter 5. Check that the results are as you would expect 6. On the results page click 'Show SQL code' 7. Confirm that the codes are included according to your selections 8. Note that when no selections are made for a parameter all codes are used by defaut Sponsored-by: CLAMS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169819|0 |1 is obsolete| | --- Comment #17 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 171341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171341&action=edit Bug 37050: (follow-up) CSS and configuration tweak This follow-up tweaks the Select2 CSS so that the selected choices don't display with 100% width. The patch also removes the "closeOnSelect: false" configuration from Select2. In discussing this option for Bug 36545 more people preferred the default behavior and I think we should be consistent. PA amended commit message: `yarn css:build` is required to test these CSS changes Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #18 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 171342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171342&action=edit Bug 37050: (follow-up) Add select2 to SQL reports multiselect Rebase for changes made on bug 37077 This patch removes some javascript in favor of an update to the template. The default value for multi select parameter's is a newline separated list so that report results are not limited when no selections are made. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171340|0 |1 is obsolete| | --- Comment #19 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 171957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171957&action=edit Bug 37050: Add select2 to SQL reports multi select This patch adds select 2 to multi-select parameter fields in SQL reports. If no selections are made for a multi-select all authorised values will be used by default. This allows reports to be written where a multi select parameter is optional. To test: 1. Apply patch 2. Go to Reports and create a report from SQL select * from items where homebranch in <<Libraries|branches:in>> and itype in <<Item type|itemtypes:in>> 3. Run the report making multiple selections for each parameter and making single selections for each parameter 4. Run the report making multiple selections for one parameter and no selections in another parameter 5. Check that the results are as you would expect 6. On the results page click 'Show SQL code' 7. Confirm that the codes are included according to your selections 8. Note that when no selections are made for a parameter all codes are used by defaut Sponsored-by: CLAMS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171341|0 |1 is obsolete| | --- Comment #20 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 171958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171958&action=edit Bug 37050: (follow-up) CSS and configuration tweak This follow-up tweaks the Select2 CSS so that the selected choices don't display with 100% width. The patch also removes the "closeOnSelect: false" configuration from Select2. In discussing this option for Bug 36545 more people preferred the default behavior and I think we should be consistent. PA amended commit message: `yarn css:build` is required to test these CSS changes Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171342|0 |1 is obsolete| | --- Comment #21 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 171959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171959&action=edit Bug 37050: (follow-up) Add select2 to SQL reports multiselect Rebase for changes made on bug 37077 This patch removes some javascript in favor of an update to the template. The default value for multi select parameter's is a newline separated list so that report results are not limited when no selections are made. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Taking another look here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #23 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Observations: It feels a bit weird to allow for an empty selection (causing an empty box with an x), and have that empty option behave the same as if no option was selected at all. Should we just not show an empty option in this case? The user can deselect any selections and submit it empty anyway. Found the following error: A) Follow steps 1 and 2 of the test plan, submit the empty form -> all good B) Follow steps 1 and 2 of the test plan, pick a single library, then remove, submit the empty form -> BOOM This may have been caused by bug 35746 and not the patches here. For the reasons above I'm not comfortable putting this back to PQA, but I don't think they're strong enough reasons to FQA either (1 is an observation, the other a bug that I don't relates to patches here). @Brendan, what do you think of the comments above? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #24 from Brendan Lawlor <blawlor@clamsnet.org> --- Hi Pedro, thanks for finding these issues! (In reply to Pedro Amorim from comment #23)
Observations: It feels a bit weird to allow for an empty selection (causing an empty box with an x), and have that empty option behave the same as if no option was selected at all. Should we just not show an empty option in this case? The user can deselect any selections and submit it empty anyway.
I hadn't noticed that the hidden select option is selectable in the select2 dropdown. I agree this should be fixed. It seems to be that select2 is not respecting the hidden property on that first option for some reason.
Found the following error: A) Follow steps 1 and 2 of the test plan, submit the empty form -> all good B) Follow steps 1 and 2 of the test plan, pick a single library, then remove, submit the empty form -> BOOM
The template fills all the codes into the hidden option and then every time the user updates selections the value of the hidden option is updated. This error is happening because of an edge case when everything is deselected the value is becoming an empty string when it should revert to a newline delimited list of all codes. I will come back to this and submit a new patch as soon as I can. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- @Pedro and @Brendan: Hi there, reviewing "additional_work_needed" - can you please review and file new bugs if needed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #26 from Brendan Lawlor <blawlor@clamsnet.org> --- (In reply to Katrin Fischer from comment #25)
@Pedro and @Brendan: Hi there, reviewing "additional_work_needed" - can you please review and file new bugs if needed?
Hi Katrin! I added "additional_work_needed" to remind me to come back to this one. Should I have just set it to Failed QA instead? I intend to work on this but haven't had the time recently. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Brendan Lawlor from comment #26)
(In reply to Katrin Fischer from comment #25)
@Pedro and @Brendan: Hi there, reviewing "additional_work_needed" - can you please review and file new bugs if needed?
Hi Katrin!
I added "additional_work_needed" to remind me to come back to this one. Should I have just set it to Failed QA instead?
I intend to work on this but haven't had the time recently.
Hah! That was my mistake, we usually use the additional_work_needed for bugs already pushed that still need something done. Failed QA or back to Assigned is fine if you need to work on it still. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171957|0 |1 is obsolete| | Attachment #171958|0 |1 is obsolete| | Attachment #171959|0 |1 is obsolete| | --- Comment #28 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 177320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177320&action=edit Bug 37050: Add select2 to SQL reports multiselect This patch adds select 2 to multi-select parameter fields in SQL reports. If no selections are made for a multi-select all authorised values will be used by default. This allows reports to be written where a multi select parameter is optional. To test: 1. Apply patch 2. Go to Reports and create a report from SQL select * from items where homebranch in <<Libraries|branches:in>> and itype in <<Item type|itemtypes:in>> 3. Run the report making multiple selections for each parameter and making single selections for each parameter 4. Run the report making multiple selections for one parameter and no selections in another parameter 5. Check that the results are as you would expect 6. On the results page click 'Show SQL code' 7. Confirm that the codes are included according to your selections 8. Note that when no selections are made for a parameter all codes are used by defaut Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177320|0 |1 is obsolete| | --- Comment #29 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 179669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179669&action=edit Bug 37050: Add select2 to SQL reports multiselect This patch adds select 2 to multi-select parameter fields in SQL reports. If no selections are made for a multi-select all authorised values will be used by default. This allows reports to be written where a multi select parameter is optional. To test: 1. Apply patch 2. Go to Reports and create a report from SQL select * from items where homebranch in <<Libraries|branches:in>> and itype in <<Item type|itemtypes:in>> 3. Run the report making multiple selections for each parameter and making single selections for each parameter 4. Run the report making multiple selections for one parameter and no selections in another parameter 5. Check that the results are as you would expect 6. On the results page click 'Show SQL code' 7. Confirm that the codes are included according to your selections 8. Note that when no selections are made for a parameter all codes are used by defaut Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #30 from Brendan Lawlor <blawlor@clamsnet.org> --- rebased for main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179669|0 |1 is obsolete| | --- Comment #31 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 179728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179728&action=edit Bug 37050: Add select2 to SQL reports multiselect This patch adds select 2 to multi-select parameter fields in SQL reports. If no selections are made for a multi-select all authorised values will be used by default. This allows reports to be written where a multi select parameter is optional. To test: 1. Apply patch 2. Go to Reports and create a report from SQL select * from items where homebranch in <<Libraries|branches:in>> and itype in <<Item type|itemtypes:in>> 3. Run the report making multiple selections for each parameter and making single selections for each parameter 4. Run the report making multiple selections for one parameter and no selections in another parameter 5. Check that the results are as you would expect 6. On the results page click 'Show SQL code' 7. Confirm that the codes are included according to your selections 8. Note that when no selections are made for a parameter all codes are used by defaut Sponsored-by: CLAMS Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #32 from Michaela Sieber <michaela.sieber@kit.edu> --- Ready for Pedro ;-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179728|0 |1 is obsolete| | --- Comment #33 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180618&action=edit Bug 37050: Add select2 to SQL reports multiselect This patch adds select 2 to multi-select parameter fields in SQL reports. If no selections are made for a multi-select all authorised values will be used by default. This allows reports to be written where a multi select parameter is optional. To test: 1. Apply patch 2. Go to Reports and create a report from SQL select * from items where homebranch in <<Libraries|branches:in>> and itype in <<Item type|itemtypes:in>> 3. Run the report making multiple selections for each parameter and making single selections for each parameter 4. Run the report making multiple selections for one parameter and no selections in another parameter 5. Check that the results are as you would expect 6. On the results page click 'Show SQL code' 7. Confirm that the codes are included according to your selections 8. Note that when no selections are made for a parameter all codes are used by defaut Sponsored-by: CLAMS Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #34 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Tested and all my previous observations have been answered. Awesome and thank you! My understanding is the new CSS is required or else it inherits the 100% width from fieldset.rows li. This does not cause any regression on existing select2 in item search that I can tell and likely helps future select2 multiple under these fieldset.rows li. It'd be great to DRY this pattern at some point (in itemsearch.tt and guided_reports_start.tt) if at all possible: selectField.style.minWidth = '320px'; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have unhappy QA tool here, can you please check? qa testing 1 commit(s) (applied to fec3b60 '3df Bug 39392: Fix typos in atomicupd') Processing files before patches |========================>| 1 / 1 (100.00%) Processing files after patches [error] VefMXrl4Sg.tt: SyntaxError: Unexpected closing tag "select". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-e... (7:49) [error] 5 | #~569~# [error] 6 | #~574~# [error] > 7 | </select> [error] | ^^^^^^^^^ [error] 8 | </li> [error] 9 | at misc/devel/tidy.pl line 112. FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #36 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 181099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181099&action=edit Bug 37050: (follow-up) fix invalid tt html syntax -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181099|0 |1 is obsolete| | --- Comment #37 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 181100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181100&action=edit Bug 37050: (follow-up) Fix invalid html syntax in tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #38 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks Katrin! I found this error was caused by using an if else block to open the <select> element and then closing it outside that block. I came up with two different solutions. I think the second one is cleaner, but I'm not 100% sure if it's ok with regard to the HTML1 coding guideline with the tt IF inside the html. It passes the QA script now though :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Brendan Lawlor from comment #38)
Thanks Katrin!
I found this error was caused by using an if else block to open the <select> element and then closing it outside that block.
I came up with two different solutions. I think the second one is cleaner, but I'm not 100% sure if it's ok with regard to the HTML1 coding guideline with the tt IF inside the html. It passes the QA script now though :)
HTML1 was recently updated, so you might be OK there (without seeing the code, but having hte QA script pass :) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When writing SQL reports release notes| |with SQL runtime parameters | |for selecting multiple | |items from a list, this is | |now easier with a | |Select2-style pull-down | |that allows for searching | |and displays choices as a | |list with 'x' for easy | |removal of previous | |selections. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40583 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #41 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #42 from Jonathan Druart <jonathan.druart@gmail.com> --- I've just discovered this change. Is this.. expected? https://snipboard.io/1YSj4N.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 --- Comment #43 from Jonathan Druart <jonathan.druart@gmail.com> --- Then you can select option of the right and delete them. But if you open the dropdown they are still there: https://snipboard.io/l2ktKq.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40819 [Bug 40819] Guided reports select column should not be initialized as select2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org