[Bug 6190] New: Custom field removal from patron entry screens
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Bug #: 6190 Summary: Custom field removal from patron entry screens Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Patrons AssignedTo: kyle.m.hall@gmail.com ReportedBy: srdjan@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Implement a mechanism for removing unwanted fields from the entry screens. It will be a syspref, BorrowerUnwantedField, that will have the same format as BorrowerMandatoryField -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-04-14 06:03:34 UTC --- Created attachment 3919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3919 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner@ptfs.com --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-04-14 06:05:52 UTC --- *** Bug 3656 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |katrin.fischer@bsz-bw.de Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-04-26 06:08:08 UTC --- Created attachment 4004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4004 Patch fixed to apply to master I attach a patch that will apply to current master. I had to fix the updatedatabase and the escaping in updatedatabase (patron''s) to make it work. Tested with: cardnumber|surname|firstname|title|othernames|initials|streetnumber|streettype|address|address2|city|state|zipcode|country|email|phone|mobile|fax|emailpro|phonepro|B_streetnumber|B_streettype|B_address|B_address2|B_city|B_state|B_zipcode|B_country|B_email|B_phone|dateofbirth|branchcode|categorycode|dateenrolled|dateexpiry|gonenoaddress|lost|debarred|contactname|contactfirstname|contacttitle|borrowernotes|relationship|sex|password|userid|opacnote|contactnote|sort1|sort2|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone Problems I see: - Salutation (title) can not be hidden - The patch is missing the translated sql files Possible improvements: - It works only for the edit screen, not for the patron details tab. Fields shoud be hidden there too. - When all fields from a block like 'Alternate contact' or 'Alternate address' are hidden, the empty block should not show up. - Patron account flags can not be hidden Note: - Category (categorycode) can not be hidden (probably by design) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3919|0 |1 is obsolete| | Attachment #4004|0 |1 is obsolete| | --- Comment #4 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-05-08 23:54:59 UTC --- Created attachment 4062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4062 patch Corrected title removal. Also added whole group removal when appropriate. Left borrower flags, removal can cause some unpleasant situations. Removal should be specified and scoped separately if needed. Please retest. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-09 06:24:34 UTC --- Hi Srdjan, thx for your work on this :) I agree hiding the flags might cause problems if libraries for example choose to debar patrons automatically. I still have 2 problems with your patch: 1) The translated sql files are missing the system preference. Until we make all languages use the en file this is still needed so people installing in another language are not missing system preferences. 2) The feature to hide whole groups seems not complete and a little inconsistent to me: The condition to hide alternate contact is: + [% UNLESS noaltcontactsurname && noaltcontactfirstname %] So if you choose to hide the names to make it just another address field, the whole block will disappear. And is seems there is no way to hide the main address group. I actually have libraries saving only firstname, surname and email address of a patron, because they rely on another database for address information. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4062|0 |1 is obsolete| | --- Comment #6 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-05-10 00:29:50 UTC --- Created attachment 4071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4071 patch Added translations, better hiding -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #7 from Magnus Enger <magnus@enger.priv.no> 2011-05-11 11:13:38 UTC --- (In reply to comment #6)
Created attachment 4071 [details] patch
Added translations, better hiding
As far as I can see, this patch still misses installer/data/mysql/nb-NO/1-Obligatorisk/sysprefs.sql. It will be a great new feature, though! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #8 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-05-12 03:04:16 UTC --- Created attachment 4080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4080 patch nb-NO sysprefs test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Does not apply --- Comment #9 from Owen Leonard <oleonard@myacpl.org> 2011-06-01 13:33:19 UTC --- The first patch (attachment 4071) did not apply for me: Bug 6190 - Custom field removal from patron entry screens patch Apply? [yn] y Applying: bug_6190: BorrowerUnwantedField syspref and removing fields from the patron entry /home/oleonard/kohaclone/.git/rebase-apply/patch:733: trailing whitespace. $template->param( "no$_" => 1); error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:887 error: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: patch does not apply Patch failed at 0001 bug_6190: BorrowerUnwantedField syspref and removing fields from the patron entry -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4071|0 |1 is obsolete| | Attachment #4080|0 |1 is obsolete| | --- Comment #10 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-06-02 02:33:32 UTC --- Created attachment 4337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4337 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #11 from Magnus Enger <magnus@enger.priv.no> 2011-06-15 13:31:47 UTC --- Marking this as failed QA for two reasons: 1. Hiding all fields in a group does not hide the whole group - see attached screenshot. 2. There is a problem with escaping in updatedatabase.pl - it looks like this: $dbh->do("INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('BorrowerUnwantedField','','Name the fields you don\'t need to store for a patron\'s account',NULL,'free')"); should be this: $dbh->do("INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('BorrowerUnwantedField','','Name the fields you don''t need to store for a patron''s account',NULL,'free')"); ('' instead of \') Can't wait to have this feature in place, though! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #12 from Magnus Enger <magnus@enger.priv.no> 2011-06-15 13:33:30 UTC --- Created attachment 4481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4481 Empty groups still showing title and box This is what the patron entry screen looks like when BorrowerUnwantedField is set to cardnumber|surname|firstname|title|othernames|initials|streetnumber|streettype|address|address2|city|state|zipcode|country|email|phone|mobile|fax|emailpro|phonepro|B_streetnumber|B_streettype|B_address|B_address2|B_city|B_state|B_zipcode|B_country|B_email|B_phone|dateofbirth|branchcode|categorycode|dateenrolled|dateexpiry|gonenoaddress|lost|debarred|contactname|contactfirstname|contacttitle|borrowernotes|relationship|sex|password|userid|opacnote|contactnote|sort1|sort2|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-01 19:28:54 UTC --- Created attachment 4799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4799 Bug 6190: Followup fixing empty groups - fixes quoting in database update - fixes appearance/disappearance of groups with no fields to be shown To test: - Enter database field names separated by | into systempreference BorrowerUnwantedField - Check if group/ box and heading are not displayed when all fields from that group are hidden using the system preference Example: othernames|initials|title|surname|firstname|sex|dateofbirth = Patron identity should be hidden othernames|initials|title|surname|firstname|sex = Group heading and date of birth field are shown -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-01 19:30:57 UTC --- Created attachment 4800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4800 bug_6190: BorrowerUnwantedField syspref and removing fields from the patron entry -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4337|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-01 19:32:51 UTC --- For testing: apply first: bug_6190: BorrowerUnwantedField syspref and removing fields from the patron entry This is the rebased patch from Srdjan. apply second: Bug 6190: Followup fixing empty groups This is a follow up fixing the groups and quoting in the updatedatabase. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #16 from Nicole C. Engard <nengard@gmail.com> 2011-08-01 22:55:03 UTC --- Srdjan, Can you please put notes in your patches about what they do? See Katrin's follow up for an example. This will help get your patches tested properly and signed off on quicker. Thanks a bunch! Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-05 16:31:17 UTC --- Hi Nicole, you can apply both patches together and test as I described on the bug. The feature will allow to hide fields on the patron entry screen without using jquery, but using a syspref instead = BorrowerUnwantedField. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #18 from Nicole C. Engard <nengard@gmail.com> 2011-08-08 19:28:04 UTC --- first patch does not apply: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: bug_6190: BorrowerUnwantedField syspref and removing fields from the patron entry Using index info to reconstruct a base tree... <stdin>:789: trailing whitespace. $template->param( "no$_" => 1); warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/de-DE/mandatory/sysprefs.sql Auto-merging installer/data/mysql/en/mandatory/sysprefs.sql Auto-merging installer/data/mysql/fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql Auto-merging installer/data/mysql/it-IT/necessari/sysprefs.sql Auto-merging installer/data/mysql/nb-NO/1-Obligatorisk/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/nb-NO/1-Obligatorisk/sysprefs.sql Auto-merging installer/data/mysql/pl-PL/mandatory/sysprefs.sql Auto-merging installer/data/mysql/ru-RU/mandatory/system_preferences_full_optimal_for_install_only.sql Auto-merging installer/data/mysql/uk-UA/mandatory/system_preferences_full_optimal_for_install_only.sql Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging members/memberentry.pl Auto-merging xt/syspref.t CONFLICT (content): Merge conflict in xt/syspref.t Failed to merge in the changes. Patch failed at 0001 bug_6190: BorrowerUnwantedField syspref and removing fields from the patron entry When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #19 from Nicole C. Engard <nengard@gmail.com> 2011-08-08 19:28:56 UTC --- PS. I assumed that the first patch was the one that didn't say 'followup' -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-08 20:30:00 UTC --- I remembered a little to late that I should attach the rebased first patch. Seems another syspref has been pushed and it needs to rebased again. There is also one small thing that I think is a mistake - the change to xt/syspref.t. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4799|0 |1 is obsolete| | Attachment #4800|0 |1 is obsolete| | --- Comment #21 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-08-12 03:37:29 UTC --- Created attachment 4976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4976 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-12 05:13:30 UTC --- Looks like Srdjan sqashed in my follow-up, but not entirely sure as it's not easy to compare all changes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #23 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-08-12 05:29:50 UTC --- Yes, I thought it was easier to keep just one patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #24 from Nicole C. Engard <nengard@gmail.com> 2011-08-12 19:17:39 UTC --- So what does this mean - I test the one patch? or does Katrin have to resubmit her follow up? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #25 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-08-13 00:40:40 UTC --- Just one patch, this one contains all relevant changes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Does not apply --- Comment #26 from Nicole C. Engard <nengard@gmail.com> 2011-08-25 00:25:26 UTC --- Applying: bug_6190: BorrowerUnwantedField syspref and removing fields from the patron entry /home/nengard/kohaclone/.git/rebase-apply/patch:348: trailing whitespace. [% END # hide fieldset %] /home/nengard/kohaclone/.git/rebase-apply/patch:522: trailing whitespace. [%END # hide fieldset %] /home/nengard/kohaclone/.git/rebase-apply/patch:841: trailing whitespace. $template->param( "no$_" => 1); error: patch failed: installer/data/mysql/updatedatabase.pl:4399 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 bug_6190: BorrowerUnwantedField syspref and removing fields from the patron entry When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/patch-u_pyV4.patch nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #27 from Nicole C. Engard <nengard@gmail.com> 2011-08-25 01:11:56 UTC --- Tested applying with using git bz and it still doesn't apply: -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: bug_6190: BorrowerUnwantedField syspref and removing fields from the patron entry Using index info to reconstruct a base tree... <stdin>:348: trailing whitespace. [% END # hide fieldset %] <stdin>:522: trailing whitespace. [%END # hide fieldset %] <stdin>:841: trailing whitespace. $template->param( "no$_" => 1); warning: 3 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging members/memberentry.pl Failed to merge in the changes. Patch failed at 0001 bug_6190: BorrowerUnwantedField syspref and removing fields from the patron entry When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4976|0 |1 is obsolete| | --- Comment #28 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-09-05 06:44:41 UTC --- Created attachment 5308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5308 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Patch Pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Does not apply --- Comment #29 from Owen Leonard <oleonard@myacpl.org> 2011-10-07 13:41:52 UTC --- Sorry, this patch needs to be rebased and resubmitted again :( -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5308|0 |1 is obsolete| | --- Comment #30 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-10-10 00:16:20 UTC --- Created attachment 5818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5818 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5818|0 |1 is obsolete| | --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-11 06:49:40 UTC --- Created attachment 5837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5837 [SIGNED-OFF] Bug 6190: BorrowerUnwantedField syspref and removing fields from the patron entry Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with example from bug and by deleting parts of it: cardnumber|surname|firstname|title|othernames|initials|streetnumber|streettype|address|address2|city|state|zipcode|country|email|phone|mobile|fax|emailpro|phonepro|B_streetnumber|B_streettype|B_address|B_address2|B_city|B_state|B_zipcode|B_country|B_email|B_phone|dateofbirth|branchcode|categorycode|dateenrolled|dateexpiry|gonenoaddress|lost|debarred|contactname|contactfirstname|contacttitle|borrowernotes|relationship|sex|password|userid|opacnote|contactnote|sort1|sort2|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone Note: This only affects the edit screen, not the patron detail tab. A nice enhancement would be to make this page follow the system preference too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |Rel_3_8 --- Comment #32 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:40:12 UTC --- Updating version : This ENH could be in Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #33 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:44 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5837|0 |1 is obsolete| | --- Comment #34 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-14 12:44:27 UTC --- Created attachment 6303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6303 Signed patch Rebased signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #35 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-14 12:45:42 UTC --- Some QA remarks (not blocking approval): systempreferences.pl This script is now only used for Local use. Adding a line for Patrons is no longer useful. patrons.pref Just a practical question: How does a user know the name of a field to exclude, e.g. B_address2 ? Could you show the fields in a popup when clicking on a link or so? I realize that the same holds for BorrowerMandatoryField. Maybe a small follow up? memberentry.pl regex, use of o modifier: Perl will not recompile the pattern unless an interpolated variable that it contains changes. You can force Perl to skip the test and never recompile by adding a /o (which stands for "once") after the trailing delimiter. The regex here does not contain a variable. Actually, I wonder if you need this regex at all here. Thank you for work and numerous rebasing! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-14 13:06:20 UTC --- Hi Marcel, thx for QA :) We have the same problem for borrower import - the user does not know which fields correspond to which description in the user interface. Translation makes it even harder. I think the best we can do now is link to the database documentation - http://schema.koha-community.org/tables/borrowers.html -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7167 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Passed QA |Patch Pushed --- Comment #37 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-06 16:32:56 UTC --- Patch pushed, please test Marcel & Katrin: i've added a link to the syspref description: The following <a href:...>database columns</a> will not appear on the patron entry screen it's a great idea ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7559 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Bug 6190 depends on bug 7167, which changed state. Bug 7167 Summary: updatedatabase improvements http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Bug 6190 depends on bug 7167, which changed state. Bug 7167 Summary: updatedatabase improvements http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190 Bug 6190 depends on bug 7167, which changed state. Bug 7167 Summary: updatedatabase improvements http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org