[Bug 7141] New: The biblio details page in the intranet doesn't work if XSLT is activated and the xsl file contains " "
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 Bug #: 7141 Summary: The biblio details page in the intranet doesn't work if XSLT is activated and the xsl file contains " " Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: fcapovilla@live.ca QAContact: koha-bugs@lists.koha-community.org Created attachment 6148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6148 Correct a problem when translations contain in MARC21 XSL file. The problem occurs when XSLTDetailsDisplay is set to use XSLT, marcflavour is set to MARC21 and the fr-FR or fr-CA languages are used. If I then go see the details of a biblio record in the intranet, I get many of the following errors : /home/koha/kohagit/koha-tmpl/intranet-tmpl/prog/fr-FR/xslt/MARC21slim2intranetDetail.xsl:132: parser error : Entity 'nbsp' not defined <span class="results_summary type"><span class="label">Type :</span> ^ /home/koha/kohagit/koha-tmpl/intranet-tmpl/prog/fr-FR/xslt/MARC21slim2intranetDetail.xsl:145: parser error : Entity 'nbsp' not defined <xsl:with-param name="label">Collection :</xsl:with-param> ^ Frederic Demians suggested a fix to add in MARC21slim2intranetDetail.xsl . I tried it and it seems to work. Patch attached. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored AssignedTo|oleonard@myacpl.org |fcapovilla@live.ca --- Comment #1 from Frédérick Capovilla <fcapovilla@live.ca> 2011-11-02 15:17:46 UTC --- Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6148|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> 2011-11-02 15:42:47 UTC --- Created attachment 6149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6149 Signed-off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 --- Comment #3 from Frédérick Capovilla <fcapovilla@live.ca> 2011-11-02 20:57:53 UTC --- Created attachment 6150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6150 Follow-up patch : Corrects other xsl files so doesn't cause problems. Added a follow-up patch : the same problem could potentially affect other xsl files according to the test suite. I added the same line in xsl files containing ":" in their translatable strings, because that's where might be added. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6150|0 |1 is obsolete| | --- Comment #4 from Frédéric Demians <frederic@tamil.fr> 2011-11-03 05:47:42 UTC --- Created attachment 6160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6160 Signed-off follow-up patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |m.de.rooy@rijksmuseum.nl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Version|rel_3_6 |master --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-28 10:59:03 UTC --- QA Comment: Test plan could have been helpful. Now I added somewhere to let Koha break and your patch resolved it. These patches only add the entity definition of nbsp to xsl files. I only came across this warning: [A word of caution: some XML-related tools will try to validate the XSLT stylesheet if they see the DOCTYPE. Since the DTD subset does not include definitions for all the XSLT elements, validation errors will be reported.] Another point is that this patch adds this definition to a selected set of stylesheets. You could ask that if you want to add this definition, why not do it in all stylesheets? The current selection is based on an assumption that might perhaps not cover all cases. Although I would not oppose pushing this patch (with these notes), I am asking Ian as QAM to update the status, if he agrees too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 --- Comment #6 from Frédérick Capovilla <fcapovilla@live.ca> 2011-11-29 14:58:09 UTC --- Created attachment 6456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6456 Second Follow-up : Add nbsb support to all xsl files I didn't do the change on all files because I thought it would be "overkill" to add this line to every file even if the file doesn't have translatable strings of potentially problematic strings. Here is a third patch that adds the line on the xsl files I skipped. If this patch is to be pushed, it will need to be tested thoroughly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6149|0 |1 is obsolete| | Attachment #6160|0 |1 is obsolete| | Attachment #6456|0 |1 is obsolete| | --- Comment #7 from Frédéric Demians <frederic@tamil.fr> 2011-11-30 08:32:27 UTC --- Created attachment 6466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6466 Group the 3 patches Fix a problem when translations contain various XSL files With new 3.6.1 translation files, the lake of 'nbsp' entity definition make fail t/00-valid-xml.t test. This patch applies to HEAD and 3.6.x. and must be applied to 3.6.x to hush up Jenkins. How to test: - checkout 3.6.x branch - generate French templates: cd misc/translator ./translate install fr-FR cd ../.. - run test: prove -v t/00-valid-xml.t you get failing error message - apply this patch - run test again: it passes -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #8 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-01 12:24:58 UTC --- This solution has already been implemented in UNIMARC XSLTs, and MARC21 OPAC XSLT, so implementing it for the rest of the MARC21 style sheets would be consistent. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-06 11:19:40 UTC --- patch pushed, please test (hugin will be happy ;-) ) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-07 20:29:26 UTC --- Created attachment 6641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6641 Bug 7184 : Changing test to match new formatting of xsl style sheet -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6466|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6641|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-07 20:30:34 UTC --- Created attachment 6642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6642 Bug 7141 : Changing test to match new formatting of xsl style sheet -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Patch Pushed |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 --- Comment #12 from Liz Rea <wizzyrea@gmail.com> 2011-12-07 20:42:58 UTC --- Created attachment 6644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6644 Bug 7141 : Changing test to match new formatting of xsl style sheet http://bugs.koha-community.org/show_bug.cgi?id=7141 Signed-off-by: Liz Rea <wizzyrea@gmail.com> verified tests pass -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6642|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-14 13:24:02 UTC --- unless i've missed something, the attached patch has been pushed already -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7141 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Included in the 3.6 branch prior to 3.6.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org