[Bug 11951] New: check for suggestions message pops past real quick
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11951 Bug ID: 11951 Summary: check for suggestions message pops past real quick Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org You'll need to see this video - and probably pause it to see what I mean: http://screencast.com/t/enK0sx5AG When you do a search that gets no results you see a message for a split second that says something like 'not what you were looking for. check for suggestions' with a link in it. Either that doesn't belong there or it should show up for longer than it does - not sure where it goes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11951 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |3.14 Severity|minor |normal --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Nevermind, I caught it - it goes here: http://kohavm/cgi-bin/koha/svc/suggestion?render=standalone&q=32298 Which is an error page for me in Master and on 3.14.3: Software error: Template process failed: file error - cssinclude: not found at /home/nengard/kohaclone/C4/Templates.pm line 132. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11951 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Component|Templates |OPAC Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11951 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|check for suggestions |OPAC search suggestions |message pops past real |template error |quick | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11951 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11951 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 26406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26406&action=edit Bug 11951 - OPAC search suggestions template error If you have search suggestions enabled in the OPAC and click the "Check for suggestions" link before it is replaced with the JS-rendered output you will get a template error. This patch corrects it. To test you must have the bootstrap theme enabled and at least one OPAC plugin enabled in Administration -> Did you mean? - Perform a search in the OPAC. - Look for a box which says "Not what you expected? Check for suggestions" - Click the "Check for suggestions" link before it disappears. If necessary disable JavaScript in your browser so that the link doesn't disappear. - The search suggestions page should render without errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11951 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Nicole C. Engard from comment #0)
Either that doesn't belong there or it should show up for longer than it does - not sure where it goes.
The message isn't really meant to be seen if the user has JavaScript enabled, that's why it disappears. JavaScript loads the content the user is meant to see as soon as it can. The page you see if you do click that link contains the same content which JavaScript loads directly into the search results page. The reason the link appears in the first place is so that users with JavaScript disabled are able to see the same content. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11951 Alex Sassmannshausen <alex.sassmannshausen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26406|0 |1 is obsolete| | --- Comment #4 from Alex Sassmannshausen <alex.sassmannshausen@gmail.com> --- Created attachment 26410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26410&action=edit Bug 11951 - OPAC search suggestions template error If you have search suggestions enabled in the OPAC and click the "Check for suggestions" link before it is replaced with the JS-rendered output you will get a template error. This patch corrects it. To test you must have the bootstrap theme enabled and at least one OPAC plugin enabled in Administration -> Did you mean? - Perform a search in the OPAC. - Look for a box which says "Not what you expected? Check for suggestions" - Click the "Check for suggestions" link before it disappears. If necessary disable JavaScript in your browser so that the link doesn't disappear. - The search suggestions page should render without errors. Signed-off-by: A. Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11951 Alex Sassmannshausen <alex.sassmannshausen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |alex.sassmannshausen@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11951 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11951 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26410|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26433&action=edit [PASSED QA] Bug 11951 - OPAC search suggestions template error If you have search suggestions enabled in the OPAC and click the "Check for suggestions" link before it is replaced with the JS-rendered output you will get a template error. This patch corrects it. To test you must have the bootstrap theme enabled and at least one OPAC plugin enabled in Administration -> Did you mean? - Perform a search in the OPAC. - Look for a box which says "Not what you expected? Check for suggestions" - Click the "Check for suggestions" link before it disappears. If necessary disable JavaScript in your browser so that the link doesn't disappear. - The search suggestions page should render without errors. Signed-off-by: A. Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> The non-Javascript fallback link now works correctly. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11951 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11951 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org