[Bug 25012] New: Fix class on OPAC view link in staff detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012 Bug ID: 25012 Summary: Fix class on OPAC view link in staff detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102026&action=edit Bug 25012: Fix class on OPAC view link in staff detail page Probably a copy & paste error: the OPAC view link on the staff detail page currently has the class succeeding_entry_note. This patch changes it to opac_view to allow for independent styling of the link. Note: The link will only be visible when OPACBaseURL is set. To test: - Use the element inspector or check the source code for the class used on the OPAC view link on the staff detail page - Apply patch - Repeat and verify that the class has changed to opac_view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david.roberts@ptfs-europe.c | |om --- Comment #2 from David Roberts <david.roberts@ptfs-europe.com> --- Test on my test environment - works exactly as promised. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102026|0 |1 is obsolete| | --- Comment #3 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 102045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102045&action=edit Bug 25012: Fix class on OPAC view link in staff detail page Probably a copy & paste error: the OPAC view link on the staff detail page currently has the class succeeding_entry_note. This patch changes it to opac_view to allow for independent styling of the link. Note: The link will only be visible when OPACBaseURL is set. To test: - Use the element inspector or check the source code for the class used on the OPAC view link on the staff detail page - Apply patch - Repeat and verify that the class has changed to opac_view Signed-off-by: David Roberts <david@koha-ptfs.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102045|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102122&action=edit Bug 25012: Fix class on OPAC view link in staff detail page Probably a copy & paste error: the OPAC view link on the staff detail page currently has the class succeeding_entry_note. This patch changes it to opac_view to allow for independent styling of the link. Note: The link will only be visible when OPACBaseURL is set. To test: - Use the element inspector or check the source code for the class used on the OPAC view link on the staff detail page - Apply patch - Repeat and verify that the class has changed to opac_view Signed-off-by: David Roberts <david@koha-ptfs.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x branch for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25012 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org