[Bug 31528] New: Replace scss-lint configuration with one for stylelint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 Bug ID: 31528 Summary: Replace scss-lint configuration with one for stylelint Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 20427 When we switched from LESS to SCSS in the OPAC (Bug 20427) I added a linting configuration, .scss-lint.yml. This could be put to use by configuring a compatible editor to run the linting process during editing. In VS Code I was using scss-lint for this, but it's now deprecated. They suggest stylelint instead: https://stylelint.io. I propose replacing .scss-lint.yml with .stylelintrc.json, transferring most of the same rules. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 [Bug 20427] Convert OPAC LESS to SCSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 140288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140288&action=edit Bug 31528: Replace scss-lint configuration with one for stylelint This patch removes the SCSS linting configuration .scss-lint.yml which was intended to be used with a now-obsolete tool, scss-lint. It is replaced with .stylelintrc.json, for use with stylelint. I've tried to keep the linting rules the same as before. To test, run 'yarn install' to install the new dependencies. You can test stylelint from the command line like so: npx stylelint koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss It should output a list of problems with the file: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss 30:27 ✖ Expected "#e6f0f2" to be "#E6F0F2" color-hex-case 81:31 ✖ Expected single space after "(" function-parentheses-space-inside ...etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31529 [Bug 31529] Fix errors in SCSS files raised by stylelint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140288|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 140316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140316&action=edit Bug 31528: Replace scss-lint configuration with one for stylelint This patch removes the SCSS linting configuration .scss-lint.yml which was intended to be used with a now-obsolete tool, scss-lint. It is replaced with .stylelintrc.json, for use with stylelint. I've tried to keep the linting rules the same as before. To test, run 'yarn install' to install the new dependencies. You can test stylelint from the command line like so: npx stylelint koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss It should output a list of problems with the file: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss 30:27 ✖ Expected "#e6f0f2" to be "#E6F0F2" color-hex-case 81:31 ✖ Expected single space after "(" function-parentheses-space-inside ...etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 140336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140336&action=edit Bug 31528: (follow-up) A few additional rules Adding a few more rules which came up during the correction process in the follow-up bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140336|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 140339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140339&action=edit Bug 31528: (follow-up) A few additional rules Adding a few more rules which came up during the correction process in the follow-up bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140316|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 140500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140500&action=edit Bug 31528: Replace scss-lint configuration with one for stylelint This patch removes the SCSS linting configuration .scss-lint.yml which was intended to be used with a now-obsolete tool, scss-lint. It is replaced with .stylelintrc.json, for use with stylelint. I've tried to keep the linting rules the same as before. To test, run 'yarn install' to install the new dependencies. You can test stylelint from the command line like so: npx stylelint koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss It should output a list of problems with the file: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss 30:27 ✖ Expected "#e6f0f2" to be "#E6F0F2" color-hex-case 81:31 ✖ Expected single space after "(" function-parentheses-space-inside ...etc. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140339|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 140501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140501&action=edit Bug 31528: (follow-up) A few additional rules Adding a few more rules which came up during the correction process in the follow-up bug. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140500|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141182&action=edit Bug 31528: Replace scss-lint configuration with one for stylelint This patch removes the SCSS linting configuration .scss-lint.yml which was intended to be used with a now-obsolete tool, scss-lint. It is replaced with .stylelintrc.json, for use with stylelint. I've tried to keep the linting rules the same as before. To test, run 'yarn install' to install the new dependencies. You can test stylelint from the command line like so: npx stylelint koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss It should output a list of problems with the file: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss 30:27 ✖ Expected "#e6f0f2" to be "#E6F0F2" color-hex-case 81:31 ✖ Expected single space after "(" function-parentheses-space-inside ...etc. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140501|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141183&action=edit Bug 31528: (follow-up) A few additional rules Adding a few more rules which came up during the correction process in the follow-up bug. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 141260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141260&action=edit Bug 31528: (QA follow-up) Exclude .stylelintrc.json in Makefile.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31528 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org