[Bug 21900] New: intranet_catalog_biblio_enhancements_toolbar_button plugin hook broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21900 Bug ID: 21900 Summary: intranet_catalog_biblio_enhancements_toolbar_button plugin hook broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Commit 1a0172a253e5432e5eef862768aaacb3463501f2 broke the display of buttons provided by plugins making use of the intranet_catalog_biblio_enhancements_toolbar_button hook. The addition of the html filter breaks the ability of the browser to parse the HTML provided by the plugin, the $raw filter needs to be used instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21900 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21900 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20968 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 [Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21900 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 82700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82700&action=edit Bug 21900: Fix erroneous filter Swap the filter from html to $raw. We need the browser to be able to parse the HTML supplied by plugins. Test plan: - Apply patch - Install plugin that uses the intranet_catalog_biblio_enhancements_toolbar_button hook, currently only https://github.com/PTFS-Europe/koha-plugin-cla-check_permissions/releases - View the /cgi-bin/koha/catalogue/detail.pl page for an record => TEST: Verify that the "CLA Check Permissions" button is displaying in the record's tool bar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21900 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Bug 21905 also addresses this problem and has a test plan involving the easier to test Kitchen Sink plugin. So I'm closing this one in favour of that one. *** This bug has been marked as a duplicate of bug 21905 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21900 Bug 21900 depends on bug 20968, which changed state. Bug 20968 Summary: Plugins: Add hooks to enable plugin integration into catalogue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21900 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugzilla@warmlight.co.uk |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org