[Bug 16289] New: Abbreviated formatting for numbering patterns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 Bug ID: 16289 Summary: Abbreviated formatting for numbering patterns Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: kholten@switchinc.org QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Our consortium uses abbreviations for our serials formatting. Existing formatting options for numbering patterns use the full month, day and season. Staff would like additional options for abbreviations. This development would create the option to select three letter abbreviations for: Day (Mon, Tue, Wed, Thu, Fri, Sat, Sun) Month (Jan, Feb, Mar, Apr, May, Jun, Jul, Aug, Sep, Oct, Nov, Dec) Season (Spr, Sum, Fal, Win) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 Karl Holten <kholten@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten@switchinc.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 --- Comment #1 from Karl Holten <kholten@switchinc.org> --- Created attachment 50363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50363&action=edit Bug 16289) Abbreviated formatting for numbering patterns This is my first attempt to do some development for Koha, so please take care to make sure I didn't mess anything up :) To test: 1) Go to Serials -> Manage numbering patterns 2) Create ‘New Numbering Pattern’ 3) Type in a name of “Day, Month, Season” and a numbering formula of “{X} {Y} {Z}”. 4) Set up the X field as following: add 1, every 1, set back to 1, when more than 30. 5) Select the formatting for X. There should be six options available instead of the original three. Use the formatting “Name of Day (abbreviated)”. 5) Set up the Y field to add 1 every 30 reset back to 1 when more than 12. Use the formatting “Name of month (abbreviated)” 6) Set up the Z field to add 1 every 90 reset back to 1 when more than 4. Use the formatting “Name of season (abbreviated)”. 8) Select a frequency of “1/day”. 9) Select a first issue publication date of Jan 1, 2016. 10) Set X to begin with 5 and have an inner counter of 5. Set Z to begin with 3 and have an inner counter of 10. 11) Click the “Test Pattern” button. 12) Abbreviated versions of the day, month and season should appear in the test pattern. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 Karl Holten <kholten@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #2 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- yes, it works as describe. Abbreviated versions are well displayed in the test pattern, according to the day, month, and season. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by sonia bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 52058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52058&action=edit Bug 16289: Abbreviated formatting for numbering patterns To test: 1) Go to Serials -> Manage numbering patterns 2) Create .New Numbering Pattern. 3) Type in a name of 'Day, Month, Season' and a numbering formula of '{X} {Y} {Z}'. 4) Set up the X field as following: add 1, every 1, set back to 1, when more than 30. 5) Select the formatting for X. There should be six options available instead of the original three. Use the formatting 'Name of Day (abbreviated)'. 5) Set up the Y field to add 1 every 30 reset back to 1 when more than 12. Use the formatting option 'Name of month (abbreviated)'. 6) Set up the Z field to add 1 every 90 reset back to 1 when more than 4. Use the formatting option 'Name of season (abbreviated)'. 8) Select a frequency of 1/day. 9) Select a first issue publication date of Jan 1, 2016. 10) Set X to begin with 5 and have an inner counter of 5. Set Z to begin with 3 and have an inner counter of 10. 11) Click the 'Test Pattern' button. 12) Abbreviated versions of the day, month and season should appear in the test pattern. Signed-off-by: sonia bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52058|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52098&action=edit Bug 16289: Abbreviated formatting for numbering patterns To test: 1) Go to Serials -> Manage numbering patterns 2) Create .New Numbering Pattern. 3) Type in a name of 'Day, Month, Season' and a numbering formula of '{X} {Y} {Z}'. 4) Set up the X field as following: add 1, every 1, set back to 1, when more than 30. 5) Select the formatting for X. There should be six options available instead of the original three. Use the formatting 'Name of Day (abbreviated)'. 5) Set up the Y field to add 1 every 30 reset back to 1 when more than 12. Use the formatting option 'Name of month (abbreviated)'. 6) Set up the Z field to add 1 every 90 reset back to 1 when more than 4. Use the formatting option 'Name of season (abbreviated)'. 8) Select a frequency of 1/day. 9) Select a first issue publication date of Jan 1, 2016. 10) Set X to begin with 5 and have an inner counter of 5. Set Z to begin with 3 and have an inner counter of 10. 11) Click the 'Test Pattern' button. 12) Abbreviated versions of the day, month and season should appear in the test pattern. Signed-off-by: sonia bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52099&action=edit Bug 16289: Refactore code and add tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.11, thanks Karl, Jonathan! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- I'm tempted to push this enhancement to 16.05 in order to avoid master/stable code divergence, and since template & code modification seems limited. Any objection from anyone? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 --- Comment #9 from Karl Holten <kholten@switchinc.org> --- No objections here! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at this code and some of otherthe code related to seasonal patterns, I believe the abbreviated seasons are not translatable/translated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #10)
Looking at this code and some of otherthe code related to seasonal patterns, I believe the abbreviated seasons are not translatable/translated.
Can you expand on that? Is this due to us not using localized DateTimes? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a problem witht he way seasonal translations are generated - it only applies to that I think - months, days etc. should probably be ok. If you take a look at the templates, you might see what I mean. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 Rafal Kopaczka <rkopaczka@afm.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17245 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17245 [Bug 17245] Untranslatable abbreviated names of seasons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16289 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bug 17245 fixes the problem I meant - thx again Rafal! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org