https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36617 --- Comment #1 from Nicholas van Oudtshoorn <vanoudt@gmail.com> --- Created attachment 164981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164981&action=edit Allow old googleopenidconnect service to redirect to referring page if possible and appropriate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36617 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |vanoudt@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36617 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Status|Needs Signoff |Failed QA --- Comment #3 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Shi Yao Wang from comment #2)

Can we get a test plan in the commit message with this? https://wiki.koha-community.org/wiki/Commit_messages

Yes, please provide a test plan. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36617 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Looking at this and bug 34164... this code should be in its own function in a Perl module. For example: my $koha_referrer = C4::Context::koha_referrer({ interface => $interface, referrer_url => $referrer_url, }); -- Also, the issues Lukas Koszyk mentions on bug 34164 should also be addressed. These will also be easier to address when using a dedicated function in a Perl module. -- I've used the C4::Context module here, since the referrer is specific to the web context. I suppose you could make an argument that it should be in a Koha::Auth:: module instead. Heck... maybe even Koha::Auth::Referrer. -- Anyway, I'm not trying to dictate how it should go. Just that the code should be in its own function in a Perl module so that it's not duplicated and so that it's easily tested :) -- You are receiving this mail because: You are watching all bug changes.