[Bug 30714] New: Checkins from other branches spam the cataloguing log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 Bug ID: 30714 Summary: Checkins from other branches spam the cataloguing log Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When an item from another branch is checked in, the holdingbranch is updated, and this change is logged. We record the checkin in statistics, we do not need the cataloguing update logged To recreate: 1 - Enable cataloguing log 2 - Check in an item with a different holding branch 3 - Check the action logs 4 - There is a cataloguing log for the holdingbranch update -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134763&action=edit Bug 30714: Unit test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134764&action=edit Bug 30714: Do no log update to holdingbranch When an item from another branch is checked in, the holdingbranch is updated, and this change is logged. We record the checkin in statistics, we do not need the cataloguing update logged To recreate: 1 - Enable cataloguing log 2 - Check in an item with a different holding branch 3 - Check the action logs 4 - There is a cataloguing log for the holdingbranch update 5 - Apply patch 6 - Repeate with another item 7 - No log added! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134763|0 |1 is obsolete| | Attachment #134764|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134863&action=edit Bug 30714: Unit test Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134864&action=edit Bug 30714: Do no log update to holdingbranch When an item from another branch is checked in, the holdingbranch is updated, and this change is logged. We record the checkin in statistics, we do not need the cataloguing update logged To recreate: 1 - Enable cataloguing log 2 - Check in an item with a different holding branch 3 - Check the action logs 4 - There is a cataloguing log for the holdingbranch update 5 - Apply patch 6 - Repeate with another item 7 - No log added! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi --- Comment #5 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- I'm a bit unsure about this proposal, as the info in statistics table might be deleted at some point and the CataloguingLog syspref promises to log all item record changes. Why do you propose this change? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We had decided not to add checkins/checkouts to the cataloguing log (they update the onloan column). So I think it seems consequential to say that changes that happen due to circulation actions should not update. Having changes to holding library and onloan not log would personally be ok for me as a rule. But if this is controversial maybe we could have something like a "MarkLostItemsAsReturned" for this log where we list what is logged more clearly? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- To me CataloguingLog implies changes made during cataloging, that is changes to a record by a person - not changes made second-hand as in circulation, and I don't think this is the correct place to maintain this information I could be convinced that 'ReturnLog' should record the return, hence the branch update, even if item not issued, but I think that would be a separate bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134864|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 135100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135100&action=edit Bug 30714: Do no log update to holdingbranch When an item from another branch is checked in, the holdingbranch is updated, and this change is logged. We record the checkin in statistics, we do not need the cataloguing update logged To recreate: 1 - Enable cataloguing log 2 - Check in an item with a different holding branch 3 - Check the action logs 4 - There is a cataloguing log for the holdingbranch update 5 - Apply patch 6 - Repeate with another item 7 - No log added! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Keywords| |rel_22_05_candidate QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- This also rises again the need to separate biblio cataloguing logs from items cataloguing logs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org