http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- The options seem to do their job nicely, but I see one small problem in the man page: <arg>[<option>-v</option>|<option>--verbose</option>]</arg> The literal brackets [] result in double brackets in the man page: koha-translate [-i|--install] [-u|--update] [-r|--remove] [-c|--check] [[-v|--verbose]] {lang_code} Just remove the literal brackets and it should be OK. But while yu are in there, could you also put the two synopsis'es (?) into separate <cmdsynopsis>? From this: <refsynopsisdiv> <cmdsynopsis> <command>koha-translate</command> <arg><option>-i</option>|<option>--install</option></arg> <arg><option>-u</option>|<option>--update</option></arg> <arg><option>-r</option>|<option>--remove</option></arg> <arg><option>-c</option>|<option>--check</option></arg> <arg>[<option>-v</option>|<option>--verbose</option>]</arg> <arg choice="req" rep="norepeat"><replaceable>lang_code</replaceable></arg> <command>koha-translate</command> <arg><option>-l</option>|<option>--list</option></arg> <arg><option>-a</option>|<option>--available</option></arg> </cmdsynopsis> </refsynopsisdiv> To this: <refsynopsisdiv> <cmdsynopsis> <command>koha-translate</command> <arg><option>-i</option>|<option>--install</option></arg> <arg><option>-u</option>|<option>--update</option></arg> <arg><option>-r</option>|<option>--remove</option></arg> <arg><option>-c</option>|<option>--check</option></arg> <arg>[<option>-v</option>|<option>--verbose</option>]</arg> <arg choice="req" rep="norepeat"><replaceable>lang_code</replaceable></arg> </cmdsynopsis> <cmdsynopsis> <command>koha-translate</command> <arg><option>-l</option>|<option>--list</option></arg> <arg><option>-a</option>|<option>--available</option></arg> </cmdsynopsis> </refsynopsisdiv> As it is now, the two lines are run into one, this will put them on separate lines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23954|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 24105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24105&action=edit Bug 10896: Add a --verbose option to koha-translate The -v and --verbose option switches add the --verbose switch to the misc/translator/translate script call in the packages' 'koha-translate' command. The docs are updated accordingly. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24105|0 |1 is obsolete| | --- Comment #4 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 24231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24231&action=edit [SIGNED-OFF] Bug 10896: Add a --verbose option to koha-translate The -v and --verbose option switches add the --verbose switch to the misc/translator/translate script call in the packages' 'koha-translate' command. The docs are updated accordingly. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as expected with and without -v. Man page looks good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24231|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24241&action=edit [PASSED QA] Bug 10896: Add a --verbose option to koha-translate The -v and --verbose option switches add the --verbose switch to the misc/translator/translate script call in the packages' 'koha-translate' command. The docs are updated accordingly. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as expected with and without -v. Man page looks good. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10896 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.4. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.