[Bug 16302] New: Koha::Logger performance tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16302 Bug ID: 16302 Summary: Koha::Logger performance tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: olli-antti.kivilahti@jns.fi QA Contact: testopia@bugs.koha-community.org This test suite proves that Koha::Logger only incurs a ~25% performance hit vs the vanilla Log::Log4perl. When the Log4perl config is defined in the %ENV, then the performance hit is only 9% This is subjective and dependant on how the Logger is deployed in code. Regardless the performance is acceptable in my opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16302 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 50439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50439&action=edit Bug 16302 - Koha::Logger performance tests Tests performance and regression in Koha::Logger -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16302 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 [Bug 14167] Add Koha::Logger based on Log4perl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16302 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16302 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50439|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 50444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50444&action=edit Bug 16302 - Koha::Logger performance tests Tests performance and regression in Koha::Logger -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16302 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |olli-antti.kivilahti@jns.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16302 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16304 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16304 [Bug 16304] Koha::Logger, lazy load loggers so environment has time to get set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16302 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16312 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16312 [Bug 16312] Koha::Logger overload configuration for command line scripts verbosity levels -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16302 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16313 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16313 [Bug 16313] Koha::Logger doesn't forward the Log::Log4perl::Logger return value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16302 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle@bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- t/Koha/Logger_performance.t .. # Subtest: Log4perl vanilla, 10000 errors ok 1 - Test duration 0.740009069442749 < 0.984212062358856 ok 2 - Log writing confirmed 1..2 ok 1 - Log4perl vanilla, 10000 errors # Subtest: Log4perl Koha::Logger from KOHA_CONF, 10000 errors ok 1 - Test duration 0.0620830059051514 < 0.984212062358856 Use of uninitialized value $firstRow in pattern match (m//) at t/Koha/Logger_performance.t line 106. not ok 2 - Log writing confirmed # Failed test 'Log writing confirmed' # at t/Koha/Logger_performance.t line 106. 1..2 # Looks like you failed 1 test of 2. not ok 2 - Log4perl Koha::Logger from KOHA_CONF, 10000 errors # Failed test 'Log4perl Koha::Logger from KOHA_CONF, 10000 errors' # at t/Koha/Logger_performance.t line 60. # Subtest: Log4perl Koha::Logger from ENV, 10000 errors ok 1 - Test duration 0.839640140533447 < 0.984212062358856 ok 2 - Log writing confirmed 1..2 ok 3 - Log4perl Koha::Logger from ENV, 10000 errors 1..3 # Looks like you failed 1 test of 3. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/Koha/Logger_performance.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.80 cusr 0.13 csys = 1.95 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16302 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- If I comment out lines 108 and 109 the tests pass, but I don't think they'd be valid anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16302 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@jns.fi --- Comment #5 from Lari Taskula <lari.taskula@jns.fi> --- Most test runs are passing for me, however, every now and then it fails at the second test: # Subtest: Log4perl vanilla, 10000 errors ok 1 - Test duration 0.710620880126953 < 0.945125770568848 ok 2 - Log writing confirmed 1..2 ok 1 - Log4perl vanilla, 10000 errors # Subtest: Log4perl Koha::Logger from KOHA_CONF, 10000 errors not ok 1 - Test duration 1.00295996665955 < 0.945125770568848 # Failed test 'Test duration 1.00295996665955 < 0.945125770568848' # at t/Koha/Logger_performance.t line 68. ok 2 - Log writing confirmed 1..2 # Looks like you failed 1 test of 2. not ok 2 - Log4perl Koha::Logger from KOHA_CONF, 10000 errors # Failed test 'Log4perl Koha::Logger from KOHA_CONF, 10000 errors' # at t/Koha/Logger_performance.t line 60. # Subtest: Log4perl Koha::Logger from ENV, 10000 errors ok 1 - Test duration 0.792418956756592 < 0.945125770568848 ok 2 - Log writing confirmed 1..2 ok 3 - Log4perl Koha::Logger from ENV, 10000 errors 1..3 # Looks like you failed 1 test of 3. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org