[Bug 8732] New: Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Priority: P5 - low Change sponsored?: --- Bug ID: 8732 Assignee: oleonard@myacpl.org Summary: Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype Severity: enhancement Classification: Unclassified OS: All Reporter: chris@bigballofwax.co.nz Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Often the icon that is generated in XSLT using the MARC control fields is inaccurate or inadequate. This systempreference would allow libraries to use the itemtype icon they have chosen for the biblio level itemtype (942 in MARC21) This is sponsored by 6 New Zealand Libraries -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- How to test: * Switch DisplayOPACiconsXSLT to show * Switch the XSLT templates for the OPAC to default * Test you see the icons generated from the MARC controlfields * Switch OpacResultsItemtypeImage to Information from the Koha biblio level itemtype * You should now see the biblio level itemtype image showing instead -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12029&action=edit Bug 8732 : Allowing biblio level itemtypes to display instead of MARC ones If you switch OpacResultsItemtypeImage to Koha, you will see the Koha itemtypes, if it is Control you will get the ones generated from the MARC control fields. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12029|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12047&action=edit Bug 8732 : Allowing biblio level itemtypes to display instead of MARC ones If you switch OpacResultsItemtypeImage to Koha, you will see the Koha itemtypes, if it is Control you will get the ones generated from the MARC control fields. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Followed the test plan. Everything works as advertised. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Reworking, changing the name of the syspref and extending to do the intranet as well as the OPAC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12047|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12614&action=edit Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones If you switch BiblioItemtypeImage to Koha, you will see the Koha itemtypes, if it is Control you will get the ones generated from the MARC control fields. Squashed commit of the following: commit a36d5fdbfc484639ae7939f14e0363fda79b9323 Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Mon Oct 1 10:56:47 2012 +1300 WR96747, Bug 8732 Finishing staff side commit feff903c77ffc0fcec9459ecffab6c2ee5b1349d Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Mon Oct 1 09:47:07 2012 +1300 Bug 8732 : Now working for staff side too commit 641be286401cf1be54fddb3cc58a53566d80dcca Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Mon Oct 1 09:10:27 2012 +1300 Bug 8732 - generalising syspref Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> commit c4ce95c12a773d84e6f8d0b05664649e170799d8 Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Wed Sep 12 09:19:31 2012 +1200 Bug 8732 : Showing the images on the OPAC detail page commit 105acad0f76628536840577fa96fb0839f9f3e2f Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Thu Sep 6 14:19:37 2012 +1200 Bug 8732 : Allowing biblio level itemtypes to display instead of MARC ones If you switch OpacResultsItemtypeImage to Koha, you will see the Koha itemtypes, if it is Control you will get the ones generated from the MARC control fields. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 --- Comment #7 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 12722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12722&action=edit Screenshot OPAC detail Either there is a problem on my side or something went wrong with the patch(es). I had to manually merge the usual sql files but that should not break anything. Turning on the new feature, I get OPAC detail: "old" info and icon still there, that does not look right. "Itemtype: Books" is added under most of the biblio description. Could have <span class="label"> for 'Itemtype'. No icon for 942 itemtype in the biblio part. (see attached screenshot) OPAC results: Logo for 942 itemtype is shown, placement is different than for the old icon. No itemtype text visible. Staff detail: No icon is shown in the biblio part. 942 itemtype is added at the end of the biblio part, also <no span class="label"> here. Staff results: "old" information is shown, no 942 itemtype. no logo of either one of them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12870&action=edit Bug 8732 Style fixes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #7)
Created attachment 12722 [details] Screenshot OPAC detail
Either there is a problem on my side or something went wrong with the patch(es). I had to manually merge the usual sql files but that should not break anything.
Turning on the new feature, I get
OPAC detail: "old" info and icon still there, that does not look right. "Itemtype: Books" is added under most of the biblio description. Could have <span class="label"> for 'Itemtype'. No icon for 942 itemtype in the biblio part. (see attached screenshot)
Yep, icon wont show on the detail page, just the name, But the old info and icon should not be showing.
OPAC results: Logo for 942 itemtype is shown, placement is different than for the old icon. No itemtype text visible.
Yep,
Staff detail: No icon is shown in the biblio part. 942 itemtype is added at the end of the biblio part, also <no span class="label"> here.
Staff results: "old" information is shown, no 942 itemtype. no logo of either one of them.
Hmm, this seems to work for me. The new icon wont show, but the old ones should not be showing. You are using the default XSLT ? Do you have the icons turned on? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #10 from Mirko Tietgen <mirko@abunchofthings.net> --- Sorry, seems like I was not in the CC list of this bug. I tried again and it looks better: Looks OK: OPAC results: "new" logo OPAC details: "new" text Staff details: "new" text Looks not OK: Staff results: "old" text in my example: Type: Visual Material; Type of visual material: instead of Itemtype: Maps I could not find any occurrences of old and new together. If that is what is supposed to look like at this point I would be willing to signoff, just wondering about the staff results page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch complexity|--- |Medium patch --- Comment #11 from Nicole C. Engard <nengard@gmail.com> --- I wanted to be a on the CC list for this bug, but had to set a patch complexity to do so - update if I was wrong in my assumptions. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 cedric.vita@dracenie.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |cedric.vita@dracenie.com --- Comment #12 from cedric.vita@dracenie.com --- Something went wrong ! Applying: Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/XSLT.pm CONFLICT (content): Merge conflict in C4/XSLT.pm Auto-merging catalogue/detail.pl CONFLICT (content): Merge conflict in catalogue/detail.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl Auto-merging koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl Auto-merging opac/opac-detail.pl Auto-merging opac/opac-search.pl CONFLICT (content): Merge conflict in opac/opac-search.pl Failed to merge in the changes. Patch failed at 0001 Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 8732 - Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones Apply? [yn] Patch left in /tmp/Bug-8732-Allowing-biblio-level-itemtypes-to-displa-sGzn56.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12614|0 |1 is obsolete| | --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 16453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16453&action=edit Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones If you switch BiblioItemtypeImage to Koha, you will see the Koha itemtypes, if it is Control you will get the ones generated from the MARC control fields. Squashed commit of the following: commit a36d5fdbfc484639ae7939f14e0363fda79b9323 Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Mon Oct 1 10:56:47 2012 +1300 WR96747, Bug 8732 Finishing staff side commit feff903c77ffc0fcec9459ecffab6c2ee5b1349d Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Mon Oct 1 09:47:07 2012 +1300 Bug 8732 : Now working for staff side too commit 641be286401cf1be54fddb3cc58a53566d80dcca Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Mon Oct 1 09:10:27 2012 +1300 Bug 8732 - generalising syspref Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> commit c4ce95c12a773d84e6f8d0b05664649e170799d8 Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Wed Sep 12 09:19:31 2012 +1200 Bug 8732 : Showing the images on the OPAC detail page commit 105acad0f76628536840577fa96fb0839f9f3e2f Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Thu Sep 6 14:19:37 2012 +1200 Bug 8732 : Allowing biblio level itemtypes to display instead of MARC ones If you switch OpacResultsItemtypeImage to Koha, you will see the Koha itemtypes, if it is Control you will get the ones generated from the MARC control fields. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12870|0 |1 is obsolete| | --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 16454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16454&action=edit Bug 8732 Style fixes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |christophe.croullebois@bibl | |ibre.com --- Comment #15 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- ok the patch applies, ready to be tested -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 --- Comment #16 from cedric.vita@dracenie.com --- the sandbox patch does not apply Something went wrong ! Applying: Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging catalogue/detail.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging opac/opac-detail.pl Failed to merge in the changes. Patch failed at 0001 Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 8732 - Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones Apply? [yn] Patch left in /tmp/Bug-8732-Allowing-biblio-level-itemtypes-to-displa-2Lh8EY.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16453|0 |1 is obsolete| | --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 21820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21820&action=edit Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones If you switch BiblioItemtypeImage to Koha, you will see the Koha itemtypes, if it is Control you will get the ones generated from the MARC control fields. Squashed commit of the following: commit a36d5fdbfc484639ae7939f14e0363fda79b9323 Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Mon Oct 1 10:56:47 2012 +1300 WR96747, Bug 8732 Finishing staff side commit feff903c77ffc0fcec9459ecffab6c2ee5b1349d Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Mon Oct 1 09:47:07 2012 +1300 Bug 8732 : Now working for staff side too commit 641be286401cf1be54fddb3cc58a53566d80dcca Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Mon Oct 1 09:10:27 2012 +1300 Bug 8732 - generalising syspref Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> commit c4ce95c12a773d84e6f8d0b05664649e170799d8 Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Wed Sep 12 09:19:31 2012 +1200 Bug 8732 : Showing the images on the OPAC detail page commit 105acad0f76628536840577fa96fb0839f9f3e2f Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Thu Sep 6 14:19:37 2012 +1200 Bug 8732 : Allowing biblio level itemtypes to display instead of MARC ones If you switch OpacResultsItemtypeImage to Koha, you will see the Koha itemtypes, if it is Control you will get the ones generated from the MARC control fields. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16454|0 |1 is obsolete| | --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 21821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21821&action=edit Bug 8732 Style fixes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-10-28 last check this| | --- Comment #19 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M opac/opac-detail.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Patch failed at 0001 Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org