[Bug 23012] New: Possibility to mark processing fee by default refund when item is found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Bug ID: 23012 Summary: Possibility to mark processing fee by default refund when item is found Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: patrick.robitaille@collecto.ca QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- Hi, When you indicate a Processing fee and a replacement cost by default for a particular item type, these two fees are charge to users when an item is indicating as lost by the patron in koha. If you indicate that the item is now found, the replacement cost will be refund in the patron’s account if RefundLostOnReturnControl is activate. But, the processing fee is not refund in this situation. It would be nice to have the possibility to decide when the lost item is found that the processing fee by default will be refund ore not. It could be managed by a system preference or something like that. Test plan: -Activate WhenLostChargeReplacementFee -indicate a processing fee and a replacement cost by default for an item type. -check out an item with the same item type to a patron -Active RefundLostOnReturnControl -mark this item as lost by the patron in koha -see that the processing fee and the replacement cost are charge to the patron. -Mark the item as found by a check in -See that the replacement cost is refund and not the Processing fee. It could be a system preference in the same way that WhenLostChargeReplacementFee but for the processing fee. Regards, Patrick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #1 from Donna <bwsdonna@gmail.com> --- +1 Many of the libraries who use processing fees would like it to be automatically refunded when the lost/billed item is returned. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Daniel Gaghan <daniel.gaghan@pueblolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan@pueblolibrary | |.org --- Comment #2 from Daniel Gaghan <daniel.gaghan@pueblolibrary.org> --- Just asked about this on Slack, you can add PCCLD to the list of libraries that would like this enhancement. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown@bywatersolutions.com --- Comment #3 from Sara Brown <sbrown@bywatersolutions.com> --- Agreed - this would be useful for a lot of libraries! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Todd Goatley <tgoatley@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tgoatley@gmail.com --- Comment #4 from Todd Goatley <tgoatley@gmail.com> --- Agreed, this would be very useful. I received another ask for this today. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Michael Spagnuolo <mspagnuolo@nrhtx.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspagnuolo@nrhtx.com --- Comment #5 from Michael Spagnuolo <mspagnuolo@nrhtx.com> --- We have also run into this problem and would like to see the processing fee be able to be refunded when a lost item is returned. It would save staff some time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- We've received sponsorship to write a fix for this, will aim to have that attached in the next week. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Craig Murdoch <craig.murdoch@aut.ac.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |craig.murdoch@aut.ac.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 141627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141627&action=edit Bug 23012: Database updates for PROCESSING_FOUND account credit type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 141628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141628&action=edit Bug 23012: Show the PROCESSING_FOUND account credit type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 141629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141629&action=edit Bug 23012: Set policy for lost item processing fee -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 141630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141630&action=edit Bug 23012: [WIP] Mark processing fee as found when lost item found -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Still working on this, attaching progress here to pick up tomorrow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141627|0 |1 is obsolete| | Attachment #141630|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142046&action=edit Bug 23012: Database updates for PROCESSING_FOUND account credit type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141628|0 |1 is obsolete| | --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142047&action=edit Bug 23012: Show the PROCESSING_FOUND account credit type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141629|0 |1 is obsolete| | --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142048&action=edit Bug 23012: Set policy for lost item processing fee -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142049&action=edit Bug 23012: Apply processing fee return policy when lost item found TEST PLAN TO COME -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142049|0 |1 is obsolete| | --- Comment #16 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142113&action=edit Bug 23012: Apply processing fee return policy when lost item found This enhancement gives the ability to set a policy for the lost item processing fee that may get charged additional to the lost item replacement cost. The processing fee can be: - refunded - refunded if unpaid - kept To test: Set-up 1. Find an item, Item A. Go to Administration -> Item types and edit the item type for Item A. Add a default replacement cost and a processing fee and Save. 2. Go to Administration -> system preferences and set the following: - WhenLostChargeReplacementFee: Charge - BlockReturnOfLostItems: Don't block 3. Scroll down to the default lost item fee refund on return policy. Set the refund lost item replacement fee policy to 'refund lost item charge'. 4. Edit Item A and set a replacement cost. Reproduce 5. Check out Item A to Patron A. 6. Click the barcode to view Item A's information. Edit Item A and set the Lost status to 'lost'. 7. Go back to Patron A's checkouts. The item should now be checked in with two new charges applied - a lost item fee (the item's replacement cost) and a lost item processing fee (set in item types). 8. Check in Item A to mark it as found. 9. Go back to Patron A's account. Notice the lost item fee has been refunded, but the processing fee remains. 10. Manually pay or write off the processing fee. This enhancement removes the need for this manual step. 11. Apply the patch and restart services Test with lost item - refund 12. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'refund lost item processing charge'. 13. Repeat steps 6 to 9. 14. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded. 15. Repeat steps 6 to 8 (do not check it yet). 16. Go back to Patron A's account. Pay the processing fee. 17. Repeat step 9. 18. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded (you'll now be in a credit because the paid processing fee was also refunded). Test with lost item - refund_unpaid 19. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'refund lost item processing charge (only if unpaid)'. 20. Repeat steps 6 to 9. 21. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded. 22. Repeat steps 16 to 19. 23. Go back to Patron A's account. The lost item fee should have been refunded but not the processing fee, as this was already paid. Test with lost item - leave 24. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'leave lost item processing charge'. 25. Repeat steps 6 to 9. 26. Go back to Patron A's account. The lost item fee and processing fee should have been refunded but not the processing fee. Other tests 27. Confirm tests pass - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/CirculationRules.t Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement gives the release notes| |ability to set a policy for | |the lost item processing | |fee that may get charged | |additional to the lost item | |replacement cost. The | |processing fee can be: | |- | |refunded | |- refunded if | |unpaid | |- kept -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142046|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 142123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142123&action=edit Bug 23012: Database updates for PROCESSING_FOUND account credit type Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142047|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 142124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142124&action=edit Bug 23012: Show the PROCESSING_FOUND account credit type Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142048|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 142125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142125&action=edit Bug 23012: Set policy for lost item processing fee Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142113|0 |1 is obsolete| | --- Comment #20 from David Nind <david@davidnind.com> --- Created attachment 142126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142126&action=edit Bug 23012: Apply processing fee return policy when lost item found This enhancement gives the ability to set a policy for the lost item processing fee that may get charged additional to the lost item replacement cost. The processing fee can be: - refunded - refunded if unpaid - kept To test: Set-up 1. Find an item, Item A. Go to Administration -> Item types and edit the item type for Item A. Add a default replacement cost and a processing fee and Save. 2. Go to Administration -> system preferences and set the following: - WhenLostChargeReplacementFee: Charge - BlockReturnOfLostItems: Don't block 3. Scroll down to the default lost item fee refund on return policy. Set the refund lost item replacement fee policy to 'refund lost item charge'. 4. Edit Item A and set a replacement cost. Reproduce 5. Check out Item A to Patron A. 6. Click the barcode to view Item A's information. Edit Item A and set the Lost status to 'lost'. 7. Go back to Patron A's checkouts. The item should now be checked in with two new charges applied - a lost item fee (the item's replacement cost) and a lost item processing fee (set in item types). 8. Check in Item A to mark it as found. 9. Go back to Patron A's account. Notice the lost item fee has been refunded, but the processing fee remains. 10. Manually pay or write off the processing fee. This enhancement removes the need for this manual step. 11. Apply the patch and restart services Test with lost item - refund 12. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'refund lost item processing charge'. 13. Repeat steps 6 to 9. 14. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded. 15. Repeat steps 6 to 8 (do not check it yet). 16. Go back to Patron A's account. Pay the processing fee. 17. Repeat step 9. 18. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded (you'll now be in a credit because the paid processing fee was also refunded). Test with lost item - refund_unpaid 19. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'refund lost item processing charge (only if unpaid)'. 20. Repeat steps 6 to 9. 21. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded. 22. Repeat steps 16 to 19. 23. Go back to Patron A's account. The lost item fee should have been refunded but not the processing fee, as this was already paid. Test with lost item - leave 24. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'leave lost item processing charge'. 25. Repeat steps 6 to 9. 26. Go back to Patron A's account. The lost item fee and processing fee should have been refunded but not the processing fee. Other tests 27. Confirm tests pass - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/CirculationRules.t Sponsored-by: Auckland University of Technology Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #21 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): - Managed to work through the test plan OK. - Step 2: these are the default settings for KTD with the sample data, so no change to system preferences required. - Step 11: updatedatabase required. - Steps 13 + 15 + 20 + 22 + 25: I think a couple of the repeat steps X to should be steps 5 to X? - Step 26 should be: the lost item fee should have been refunded but not the processing fee (as expected with the 'refund lost item processing fee' policy set to 'leave lost item processing charge'). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142123|0 |1 is obsolete| | Attachment #142124|0 |1 is obsolete| | Attachment #142125|0 |1 is obsolete| | Attachment #142126|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142481&action=edit Bug 23012: Database updates for PROCESSING_FOUND account credit type Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142482&action=edit Bug 23012: Show the PROCESSING_FOUND account credit type Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142483&action=edit Bug 23012: Set policy for lost item processing fee Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142484&action=edit Bug 23012: Apply processing fee return policy when lost item found This enhancement gives the ability to set a policy for the lost item processing fee that may get charged additional to the lost item replacement cost. The processing fee can be: - refunded - refunded if unpaid - kept To test: Set-up 1. Find an item, Item A. Go to Administration -> Item types and edit the item type for Item A. Add a default replacement cost and a processing fee and Save. 2. Go to Administration -> system preferences and set the following: - WhenLostChargeReplacementFee: Charge - BlockReturnOfLostItems: Don't block 3. Scroll down to the default lost item fee refund on return policy. Set the refund lost item replacement fee policy to 'refund lost item charge'. 4. Edit Item A and set a replacement cost. Reproduce 5. Check out Item A to Patron A. 6. Click the barcode to view Item A's information. Edit Item A and set the Lost status to 'lost'. 7. Go back to Patron A's checkouts. The item should now be checked in with two new charges applied - a lost item fee (the item's replacement cost) and a lost item processing fee (set in item types). 8. Check in Item A to mark it as found. 9. Go back to Patron A's account. Notice the lost item fee has been refunded, but the processing fee remains. 10. Manually pay or write off the processing fee. This enhancement removes the need for this manual step. 11. Apply the patch and restart services Test with lost item - refund 12. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'refund lost item processing charge'. 13. Repeat steps 6 to 9. 14. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded. 15. Repeat steps 6 to 8 (do not check it yet). 16. Go back to Patron A's account. Pay the processing fee. 17. Repeat step 9. 18. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded (you'll now be in a credit because the paid processing fee was also refunded). Test with lost item - refund_unpaid 19. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'refund lost item processing charge (only if unpaid)'. 20. Repeat steps 6 to 9. 21. Go back to Patron A's account. Both the lost item fee and processing fee should have been refunded. 22. Repeat steps 16 to 19. 23. Go back to Patron A's account. The lost item fee should have been refunded but not the processing fee, as this was already paid. Test with lost item - leave 24. Go to Administration -> circulation and fines rules. Scroll down to the default lost item fee refund on return policy. Notice there is now a refund lost item processing fee policy. Set this to 'leave lost item processing charge'. 25. Repeat steps 6 to 9. 26. Go back to Patron A's account. The lost item fee and processing fee should have been refunded but not the processing fee. Other tests 27. Confirm tests pass - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/CirculationRules.t Sponsored-by: Auckland University of Technology Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142485&action=edit Bug 23012: (QA follow-up) Combine method to get both values The code for get_processingreturn_policy was very similar to get_lostreturn_policy. Combining the two methods allows for use of get_effective_rules which uses get_effective_rule_value which is cached. This should reduce lines of code and improve performance Tests updated and adjusted as well Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142486&action=edit Bug 23012: (QA follow-up) No need to create and delete rules for branch The tests create a new branch to make sure one exists without rules. We then add a rule and delete it. We can simply create the new branch and never assign a rule Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142487&action=edit Bug 23012: (QA follow-up) Add exec flag to db update Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 142575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142575&action=edit Bug 23012: get_lostreturn_policy returns a scalar On commit 4d994773f83468b561896939f16131d0332d9cfc Koha::Item->_set_found_trigger gets the call to get_lostreturn_policy() changed so it expects a hashref instead of the scalar it returns. This patch adjusts it back. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Keywords| |additional_work_needed --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Tests are failing due to this: https://jenkins.koha-community.org/job/Koha_Master_D10/887/ Please provide patches for the tests. Best regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hmm, it feels like Nick's follow-up and mine are to blame. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed |rel_22_05_candidate Status|ASSIGNED |In Discussion --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm reverting this one for now. The reason is the failures in t/db_dependent/Koha/Items.t look problematic or at least complex enough for requiring a new review. With the new method and the changes made, the $processfee_amount of 20 is being charged when it shouldn't so at least the tests need to be adjusted to clear the whole scenario we are testing. I noticed that Nick's follow-up merging the methods introduced a failure in t/db_dependent/Koha/Item.t that I fixed by breaking things as well. Remarkably, with my broken follow-up nothing changed regarding the tests results... I'm adding the rel_22_05_candidate so this dev has the chance to get in beyond the soft freeze, but please hurry. We can go without Nick's little refactoring for now BTW, and think about it later. Looking forward to your comments and follow-ups. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 | released in| | Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142575|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm reverting it tomorrow, if you provide a fix by tomorrow, I won't. It still has the chance to get in either way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 142652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142652&action=edit Bug 23012: Fix t/db_dependent/Koha/Item.t With the follow-up changes, the return value is no longer a scalar, but a hashref, but the tests weren't updated accordingly. This patch fixes this situation. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #36 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Can someone please let me know what work needs to be done here? I wrote the initial patches but I understand the follow-ups caused test failures? A bit hard to follow the commentary :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- TL;DR This patch set broke t/db_dependent/Koha/Items.t Please fix it. I blamed the follow-ups, but that was incorrect as far as I can tell. When you fix it, please verify the Circulation* tests still pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #38 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I will fix this tomorrow! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #39 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142693&action=edit Bug 23012: (follow-up) Fix t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #40 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I believe the latest patch addresses the Circulation.t tests as well. For anyone testing, only the bottom 2 patches need to be applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Aleisha Amohia from comment #40)
I believe the latest patch addresses the Circulation.t tests as well.
Thank you! Will review tomorrow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #42 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This is looking better now. The changes make sense as well. But now t/db_dependent/Koha/Item.t is failing for me because the third message is not being added. Please check. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142652|0 |1 is obsolete| | --- Comment #43 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142736&action=edit Bug 23012: Fix t/db_dependent/Koha/Item.t With the follow-up changes, the return value is no longer a scalar, but a hashref, but the tests weren't updated accordingly. This patch fixes this situation. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => FAIL: Tests fail 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142693|0 |1 is obsolete| | --- Comment #44 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 142737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142737&action=edit Bug 23012: (follow-up) Fix t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #45 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Tomás Cohen Arazi from comment #42)
This is looking better now. The changes make sense as well. But now
t/db_dependent/Koha/Item.t is failing for me because the third message is not being added. Please check.
Squashed the fix into your patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #46 from David Nind <david@davidnind.com> --- Patches no longer applies. Just applying the last two patches to the current master makes the tests pass for t/db_dependent/Koha/Items.t - before applying any patches, the tests were failing. git bz apply 23012 Bug 23012 - Possibility to mark processing fee by default refund when item is found 142481 - Bug 23012: Database updates for PROCESSING_FOUND account credit type 142482 - Bug 23012: Show the PROCESSING_FOUND account credit type 142483 - Bug 23012: Set policy for lost item processing fee 142484 - Bug 23012: Apply processing fee return policy when lost item found 142485 - Bug 23012: (QA follow-up) Combine method to get both values 142486 - Bug 23012: (QA follow-up) No need to create and delete rules for branch 142487 - Bug 23012: (QA follow-up) Add exec flag to db update 142736 - Bug 23012: Fix t/db_dependent/Koha/Item.t 142737 - Bug 23012: (follow-up) Fix t/db_dependent/Koha/Items.t Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23012: Database updates for PROCESSING_FOUND account credit type Using index info to reconstruct a base tree... M installer/data/mysql/mandatory/account_credit_types.sql Falling back to patching base and 3-way merge... Applying: Bug 23012: Show the PROCESSING_FOUND account credit type Using index info to reconstruct a base tree... M Koha/Account.pm M api/v1/swagger/definitions/patron_account_credit.yaml M koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc M koha-tmpl/opac-tmpl/bootstrap/en/includes/accounts.inc Falling back to patching base and 3-way merge... No changes -- Patch already applied. Applying: Bug 23012: Set policy for lost item processing fee Using index info to reconstruct a base tree... M Koha/CirculationRules.pm M admin/smart-rules.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt M t/db_dependent/Koha/CirculationRules.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/CirculationRules.t Auto-merging Koha/CirculationRules.pm Applying: Bug 23012: Apply processing fee return policy when lost item found Using index info to reconstruct a base tree... M C4/Circulation.pm M Koha/Item.pm M circ/returns.pl M koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt M t/db_dependent/Koha/Item.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Item.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt Auto-merging Koha/Item.pm CONFLICT (content): Merge conflict in Koha/Item.pm Auto-merging C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23012: Apply processing fee return policy when lost item found -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #47 from Tomás Cohen Arazi <tomascohen@gmail.com> --- David, you needed to: $ git bz apply 23012 and delete all commits but the last two. You were trying to apply patches that are already in master. I'm already on this one, please move to another ones! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #48 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #49 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Aleisha Amohia from comment #45)
(In reply to Tomás Cohen Arazi from comment #42)
This is looking better now. The changes make sense as well. But now
t/db_dependent/Koha/Item.t is failing for me because the third message is not being added. Please check.
Squashed the fix into your patch.
Thank you, Aleisha. Well done! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #50 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/667 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com --- Comment #51 from Blou <philippe.blouin@inlibro.com> --- This should have had a default value inserted in the DB to maintain the previous behavior. This has ruined some of our users days to discover all fees credited suddenly after update, now their books don't balance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 --- Comment #52 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Here is the insert we did in all our clients' databases `insert into circulation_rules (rule_name, rule_value) values ("processingreturn", 0);` If the rule is not in the circulation_rules table, it automatically refunds. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org