[Bug 12422] New: Javascript error triggered by opacbookbag being disabled while virtualshelves are enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12422 Bug ID: 12422 Summary: Javascript error triggered by opacbookbag being disabled while virtualshelves are enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Having the system preference opacbookbag disabled while having virtualshelves enabled will give the following javascript error: Uncaught ReferenceError: MSG_IN_YOUR_CART is not defined basket.js:414 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12422 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Javascript error triggered |Javascript error triggered |by opacbookbag being |by opacbookbag being |disabled while |disabled while |virtualshelves are enabled |virtualshelves are enabled | |when using Bootstrap -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12422 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12422 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28842&action=edit Bug 12422 - Javascript error triggered by opacbookbag being disabled while virtualshelves are enabled when using Bootstrap Having the system preference opacbookbag disabled while having virtualshelves enabled will give the following javascript error: Uncaught ReferenceError: MSG_IN_YOUR_CART is not defined basket.js:414 Test plan: 1) Set opactheme to bootstrap 2) Disable opacbookbag, enable virtualshelves 3) Open an OPAC page, view the error console 4) Note the javascript error 5) Apply this patch 6) Reload the page, not the error is gone -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12422 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12422 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Is this a duplicate of Bug 11663: fix display of holding tab in Bootstap OPAC when opacbookbag syspref is disabled? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12422 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |cbrannon@cdalibrary.org --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Owen Leonard from comment #2)
Is this a duplicate of Bug 11663: fix display of holding tab in Bootstap OPAC when opacbookbag syspref is disabled?
I'm not seeing this behavior in master. I'm thinking it may have been addressed in that bug. Kyle, can you confirm if the problem still exists? Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12422 Mayank <mayanksri1989@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mayanksri1989@gmail.com --- Comment #4 from Mayank <mayanksri1989@gmail.com> --- I was facing the same problem. Your patch solved it! Thanks! :) (In reply to Kyle M Hall from comment #1)
Created attachment 28842 [details] [review] Bug 12422 - Javascript error triggered by opacbookbag being disabled while virtualshelves are enabled when using Bootstrap
Having the system preference opacbookbag disabled while having virtualshelves enabled will give the following javascript error:
Uncaught ReferenceError: MSG_IN_YOUR_CART is not defined basket.js:414
Test plan: 1) Set opactheme to bootstrap 2) Disable opacbookbag, enable virtualshelves 3) Open an OPAC page, view the error console 4) Note the javascript error 5) Apply this patch 6) Reload the page, not the error is gone
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12422 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- *** This bug has been marked as a duplicate of bug 11663 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org