[Bug 17364] New: branchcode should not be allowed in BorrowerUnwantedField , PatronSelfRegistrationBorrowerUnwantedField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Bug ID: 17364 Summary: branchcode should not be allowed in BorrowerUnwantedField, PatronSelfRegistrationBorrowerUnwantedField Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If branchcode is among the fields in BorrowerUnwantedField, saving the borrower record in members/memberentry.pl will generate an Internal Server Error because there is a foreign key constraint on borrowers.branchcode. To replicate the issue: 1/ Set the syspref BorrowerUnwantedField so that it contains branchcode 2/ Create a patron on members/memberentry.pl 3/ Save the patron, you will get "Internal Server Error". It follows that PatronSelfRegistrationBorrowerUnwantedField should not contain branchcode either -- it's necessary to create a record in the borrowers table, so we shouldn't be able to exclude it. Details for those who like that sort of thing: If you're watching the plack error logs,you'll see something like this: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_salinas`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) [for Statement "INSERT INTO `borrowers` ( `address`, `address2`, `borrowernotes`, `cardnumber`, `categorycode`, `city`, `contactnote`, `country`, `dateenrolled`, `dateexpiry`, `dateofbirth`, `debarred`, `email`, `emailpro`, `fax`, `firstname`, `initials`, `mobile`, `opacnote`, `othernames`, `password`, `phone`, `phonepro`, `privacy`, `sex`, `sort1`, `sort2`, `state`, `surname`, `title`, `userid`, `zipcode`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="1234 MAIN ST", 1="", 2="", 3="TESTYTESTERSON", 4="STAFF", 5="Bradley, CA", 6="", 7="", 8='2016-09-27', 9='2024-12-27', 10=undef, 11=undef, 12="", 13="", 14="", 15="TESTY", 16="", 17="", 18="", 19="", 20='!', 21="555 555 1212", 22="", 23=1, 24="", 25="C", 26="", 27="", 28="TESTERSON", 29="", 30='testy.testerson', 31="93426"] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a foreign key constraint fails (`koha_salinas`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) at /usr/share/koha/lib/C4/Members.pm line 769 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|branchcode should not be |branchcode in |allowed in |BorrowerUnwantedField |BorrowerUnwantedField, |causes software error when |PatronSelfRegistrationBorro |saving patron record. |werUnwantedField | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16865 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113238&action=edit Bug 17364: Add ability to exclude some columns from selection for system preferences Bug 22844 Added the option to provide a modal for selecting database columns for system preferences Some system preferences are limited to a subset of the columns allowed. For instance, setting branchcode in BorrowerUnwantedFields prevents adding new patrons This patch allows for defining exclusions in the .pref file To test: 1 - Alter BorroweUnwantedFields and select branchcode 2 - Attempt to add a new patron 3 - Get a message like "Something went wrong. Check the logs" 4 - Apply patches 5 - Alter the preference again 6 - Note that branchcode is unchecked and disabled 7 - Save the pref 8 - Add a patron 9 - It succeeds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22844 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |katrin.fischer@bsz-bw.de, | |liz@bywatersolutions.com, | |nick@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 [Bug 22844] Simplify the process of selecting database columns for system preferences -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113238|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113239&action=edit Bug 17364: Add ability to exclude some columns from selection for system preferences Bug 22844 Added the option to provide a modal for selecting database columns for system preferences Some system preferences are limited to a subset of the columns allowed. For instance, setting branchcode in BorrowerUnwantedFields prevents adding new patrons This patch allows for defining exclusions in the .pref file To test: 1 - Alter BorroweUnwantedFields and select branchcode 2 - Attempt to add a new patron 3 - Get a message like "Something went wrong. Check the logs" 4 - Apply patches 5 - Alter the preference again 6 - Note that branchcode is unchecked and disabled 7 - Save the pref 8 - Add a patron 9 - It succeeds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Needs Signoff |Failed QA --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Patch works well :D But : There is a missing html filter in : data-exclusions="[% CHUNK.exclusions %] Most important : Clicking on "Select all" selects the branchcode :O -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114409&action=edit Bug 17364: (follow-up) Add missing filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Fridolin Somers from comment #3)
Most important : Clicking on "Select all" selects the branchcode :O
Do you reproduce this ? Its a major issue no ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Fridolin Somers from comment #5)
(In reply to Fridolin Somers from comment #3)
Most important : Clicking on "Select all" selects the branchcode :O
Do you reproduce this ? Its a major issue no ?
I cannot reproduce this. When I click 'Select All' the branchcode option does appear to be select (it gets a check) but if I load the registration form I am able to complete it. Also if I click 'Select All' and save then immediately reopen the modal you will see that branchcode is not selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Can we do the same for PatronSelfRegistrationBorrowerUnwantedField? With all the hard work Nick did it would not be easy to add easily add the 'exclusions: branchcode' line to opac.pref now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Lucas Gass from comment #7)
Can we do the same for PatronSelfRegistrationBorrowerUnwantedField? With all the hard work Nick did it would not be easy to add easily add the 'exclusions: branchcode' line to opac.pref now
it would be easy* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Lucas Gass from comment #6)
(In reply to Fridolin Somers from comment #5)
(In reply to Fridolin Somers from comment #3)
Most important : Clicking on "Select all" selects the branchcode :O
Do you reproduce this ? Its a major issue no ?
I cannot reproduce this. When I click 'Select All' the branchcode option does appear to be select (it gets a check) but if I load the registration form I am able to complete it. Also if I click 'Select All' and save then immediately reopen the modal you will see that branchcode is not selected.
Indeed, disabled inputs are not posted in forms. But its very disturbing to see it checked in my opinion. I try to create a fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 114470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114470&action=edit Bug 17364: (follow-up) Do not check excluded fields When clicking on "Select all" excluded fields are selected. Even if they are not saved into preference, this is disturbing. Test plan : 1) Edit BorroweUnwantedFields system preference 2) Click "Select all" 3) See that branchcode is not selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Was easy ^^ Maybe we need some CSS on excluded fields name, grey color for example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113239|0 |1 is obsolete| | --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 114471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114471&action=edit Bug 17364: Add ability to exclude some columns from selection for system preferences Bug 22844 Added the option to provide a modal for selecting database columns for system preferences Some system preferences are limited to a subset of the columns allowed. For instance, setting branchcode in BorrowerUnwantedFields prevents adding new patrons This patch allows for defining exclusions in the .pref file To test: 1 - Alter BorroweUnwantedFields and select branchcode 2 - Attempt to add a new patron 3 - Get a message like "Something went wrong. Check the logs" 4 - Apply patches 5 - Alter the preference again 6 - Note that branchcode is unchecked and disabled 7 - Save the pref 8 - Add a patron 9 - It succeeds Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114409|0 |1 is obsolete| | --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 114472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114472&action=edit Bug 17364: (follow-up) Add missing filter Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114470|0 |1 is obsolete| | --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 114473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114473&action=edit Bug 17364: (follow-up) Do not check excluded fields When clicking on "Select all" excluded fields are selected. Even if they are not saved into preference, this is disturbing. Test plan : 1) Edit BorroweUnwantedFields system preference 2) Click "Select all" 3) See that branchcode is not selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- I signed 2 first patches, leaving NSO for my followup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114473|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114475&action=edit Bug 17364: (follow-up) Do not check excluded fields When clicking on "Select all" excluded fields are selected. Even if they are not saved into preference, this is disturbing. Test plan : 1) Edit BorroweUnwantedFields system preference 2) Click "Select all" 3) See that branchcode is not selected Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 [Bug 27321] Make excluded database columns in system preferences more clearly disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|branchcode in |branchcode in |BorrowerUnwantedField |BorrowerUnwantedField |causes software error when |causes software error when |saving patron record. |saving patron record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The option branchcode cannot be selected with this patch, but it's not visually clear. Could we make option appear greyed out or similar the GUI easier to understand? And would it not be easier to not show the option at all if it's not available for a specific preference? Please review! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I found bug 27321 now - hope we can get a quick sign-off as this could solve the issue here! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25029 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #19 from David Nind <david@davidnind.com> --- I've signed off bug 27321 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27321 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 [Bug 27321] Make excluded database columns in system preferences more clearly disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114471|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116114&action=edit Bug 17364: Add ability to exclude some columns from selection for system preferences Bug 22844 Added the option to provide a modal for selecting database columns for system preferences Some system preferences are limited to a subset of the columns allowed. For instance, setting branchcode in BorrowerUnwantedFields prevents adding new patrons This patch allows for defining exclusions in the .pref file To test: 1 - Alter BorroweUnwantedFields and select branchcode 2 - Attempt to add a new patron 3 - Get a message like "Something went wrong. Check the logs" 4 - Apply patches 5 - Alter the preference again 6 - Note that branchcode is unchecked and disabled 7 - Save the pref 8 - Add a patron 9 - It succeeds Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114472|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116115&action=edit Bug 17364: (follow-up) Add missing filter Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114475|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116116&action=edit Bug 17364: (follow-up) Do not check excluded fields When clicking on "Select all" excluded fields are selected. Even if they are not saved into preference, this is disturbing. Test plan : 1) Edit BorroweUnwantedFields system preference 2) Click "Select all" 3) See that branchcode is not selected Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #24 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |A more user friendly release notes| |interface for selecting | |database columns for some | |system preferences (such as | |BorrowerUnwantedField) was | |added in Koha 20.11 (Bug | |22844). | | | |Some database | |columns should be excluded | |from selection as they can | |cause server errors. For | |example, branchcode in | |BorrowerUnwantedField is | |required for adding patrons | |- if selected it causes a | |server error and you can't | |add a patron, so it should | |not be selectable. | | | |This | |big fixes the issue by: | | | |- | |allowing developers to | |define the database columns | |to exclude from selection | |in the .pref system | |preference definition file | |using "exclusions: " | | | |- | |disabling the selection of | |the excluded database | |columns in the staff | |interface when configuring | |system preferences that | |allow selecting database | |columns | | | |- updating the | |BorrowerUnwantedField | |system preference to | |exclude branchcode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #25 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Text to go in the|A more user friendly |A more user friendly release notes|interface for selecting |interface for selecting |database columns for some |database columns for some |system preferences (such as |system preferences (such as |BorrowerUnwantedField) was |BorrowerUnwantedField) was |added in Koha 20.11 (Bug |added in Koha 20.11 (Bug |22844). |22844). | | |Some database |Some database |columns should be excluded |columns should be excluded |from selection as they can |from selection as they can |cause server errors. For |cause server errors. For |example, branchcode in |example, branchcode in |BorrowerUnwantedField is |BorrowerUnwantedField is |required for adding patrons |required for adding patrons |- if selected it causes a |- if selected it causes a |server error and you can't |server error and you can't |add a patron, so it should |add a patron, so it should |not be selectable. |not be selectable. | | |This |This |big fixes the issue by: |bug fixes the issue by: | | |- |- |allowing developers to |allowing developers to |define the database columns |define the database columns |to exclude from selection |to exclude from selection |in the .pref system |in the .pref system |preference definition file |preference definition file |using "exclusions: " |using "exclusions: " | | |- |- |disabling the selection of |disabling the selection of |the excluded database |the excluded database |columns in the staff |columns in the staff |interface when configuring |interface when configuring |system preferences that |system preferences that |allow selecting database |allow selecting database |columns |columns | | |- updating the |- updating the |BorrowerUnwantedField |BorrowerUnwantedField |system preference to |system preference to |exclude branchcode |exclude branchcode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #26 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- *** Bug 16865 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org