[Bug 29684] New: Warning File not found: js/locale_data.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Bug ID: 29684 Summary: Warning File not found: js/locale_data.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Have been seeing this various times, things like: File not found : default/js/locale_data.js at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 84. File not found : ArticleRequestsDisclaimerText_en/js/locale_data.js at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 84. Obviously these are not languages. Default might be a notice language?? And the Disclaimer is a html customization. Still need to find a way to reproduce. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com Assignee|koha-bugs@lists.koha-commun |stalkernoid@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #1 from Andrew Nugged <nugged@gmail.com> --- it's reproducible on some pages: members/memberentry.pl members/paycollect.pl for example, edit some user: /cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=1&step=1 This happens because of mass-assignment of keys for template from DB where occasionally template's "lang" value replaced with trashy one. Petro has fix, will publish it. I still can't find direct reproduction for "ArticleRequestsDisclaimerText_en": (somewhere related to tools/additional-contents.pl or Koha::AdditionalContents probably) but that honeypot code added will help further find other paces where such tricks happen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Andrew Nugged from comment #1)
Petro has fix, will publish it. Great !
I still can't find direct reproduction for "ArticleRequestsDisclaimerText_en": (somewhere related to tools/additional-contents.pl or Koha::AdditionalContents probably) but that honeypot code added will help further find other paces where such tricks happen.
Yeah couldnt find it at first try. Note that additional_contents has a column *lang*. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #3 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 128571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128571&action=edit Bug 29684: fix warn about not found file js/locale_data.js Value of 'lang' unexpectedly was set to 'default', to prevent it, the feature was added to detect 'lang' getting overlaid in template and prevent + warn the developer about it. To reproduce (memberentry.pl): 1) Head over to the patron details page, press edit button to open the memberentry.pl page. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. To reproduce (paycollect.pl): 1) Prepare or use some existing patron with outstanding fines, go to the accounting section and open page where you make payment towards all fines. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128571|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128675&action=edit Bug 29684: fix warn about not found file js/locale_data.js Value of 'lang' unexpectedly was set to 'default', to prevent it, the feature was added to detect 'lang' getting overlaid in template and prevent + warn the developer about it. To reproduce (memberentry.pl): 1) Head over to the patron details page, press edit button to open the memberentry.pl page. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. To reproduce (paycollect.pl): 1) Prepare or use some existing patron with outstanding fines, go to the accounting section and open page where you make payment towards all fines. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is this not more a clash of variables where we should rename one? There is also the preferred language for notices stored in borrowers.lang and it has a "default" setting. It will be visible after activating the TranslateNotices system preferences on opac-messaging.pl, but also memeberenty.pl. With this patch in place, I can no longer set the preferred language to "Default" or any other installed language in the staff interface. It will always store the template language. 1) Activate TranslateNotices 2) Edit any existing patron, set language to Default 3) Save 4) Edit: Template language will show as selected. I haven't verified, but the patch possibly triggering printing slips/notices in the preferred language from paycollect as well. I believe we need to approach this differently. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #5)
Is this not more a clash of variables where we should rename one?
There is also the preferred language for notices stored in borrowers.lang and it has a "default" setting.
It will be visible after activating the TranslateNotices system preferences on opac-messaging.pl, but also memeberenty.pl.
With this patch in place, I can no longer set the preferred language to "Default" or any other installed language in the staff interface. It will always store the template language.
1) Activate TranslateNotices 2) Edit any existing patron, set language to Default 3) Save 4) Edit: Template language will show as selected.
I haven't verified, but the patch possibly triggering printing slips/notices in the preferred language from paycollect as well.
I believe we need to approach this differently.
Thx Katrin for verifying this. I only glanced at the patch and was already afraid for this side effect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The only good way to fix this bug is to remove the ugly line 816 $template->param(%data); And pass the patron object to the template. Lot of changes are needed template-side however. I can do it if there are commitments for quick SO and QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #8 from Andrew Nugged <nugged@gmail.com> --- Great note from Katrin, I agree that the best solution is to replace: in members/paycollect.pl: $template->param(%$borrower); with something like: $template->param(borrower_data => $borrower); and in members/memberentry.pl: $template->param(%data); with something like: $template->param(borrower_data => \%data ); and then we need to update .tt files accordingly with all keys which were used from those %data/%$borrower directly-mapped ones. Jonathan, I can toss this to Petro to do again, and Tomás can SO and you QA then...? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128675|0 |1 is obsolete| | --- Comment #9 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 129532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129532&action=edit Bug 29684: fix warn about not found file js/locale_data.js To reproduce (memberentry.pl): 1) Head over to the patron details page, press edit button to open the memberentry.pl page. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #10 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 129534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129534&action=edit Bug 29684: fix warn about not found file js/locale_data.js To reproduce (paycollect.pl): 1) Prepare or use some existing patron with outstanding fines, go to the accounting section and open page where you make payment towards all fines. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #11 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 129536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129536&action=edit Bug 29684: add honeypot to catch other warnings in the future -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129532|0 |1 is obsolete| | Attachment #129534|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 130184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130184&action=edit Bug 29684: fix warn about not found file js/locale_data.js To reproduce (memberentry.pl): 1) Head over to the patron details page, press edit button to open the memberentry.pl page. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 130185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130185&action=edit Bug 29684: fix warn about not found file js/locale_data.js To reproduce (paycollect.pl): 1) Prepare or use some existing patron with outstanding fines, go to the accounting section and open page where you make payment towards all fines. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129536|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 130186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130186&action=edit Bug 29684: add honeypot to catch other warnings in the future Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130184|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130185|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130186|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130210&action=edit Bug 29684: Fix warn about js/locale_data.js (memberentry.pl) To reproduce (memberentry.pl): 1) Head over to the patron details page, press edit button to open the memberentry.pl page. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130211&action=edit Bug 29684: Fix warn about js/locale_data.js (paycollect.pl) To reproduce (paycollect.pl): 1) Prepare or use some existing patron with outstanding fines, go to the accounting section and open page where you make payment towards all fines. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130212&action=edit Bug 29684: add honeypot to catch other warnings in the future Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Hi, - <span class="label">Relationship:</span> + <span class="label">borrower_data.Relationship:</span> Sure about this change (twice) ? It is a text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #18)
Hi, - <span class="label">Relationship:</span> + <span class="label">borrower_data.Relationship:</span>
Sure about this change (twice) ? It is a text.
Good catch Frido :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #20 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130413&action=edit Bug 29684: (QA follow-up) Remove 2 extra 'borrower_data.' prefixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #21 from Andrew Nugged <nugged@gmail.com> --- Good catch! I also want to participate and add my part: -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #22 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130417&action=edit Bug 29684: (QA follow-up) paycollect.pl don't needs borrower_data at all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #23 from Andrew Nugged <nugged@gmail.com> --- I found that it looks that $borrower in /members/paycollect.pl: my $borrower = $patron->unblessed; used only once even in old code: $template->param(%$borrower); and there all around "patron." used in paycollect.tt like: <input type="hidden" name="borrowernumber" id="borrowernumber" value="[% patron.borrowernumber | html %]" /> but for some reason it was only ONE place (two times) where it was: <input type="hidden" name="title" id="title" value="[% title | html %]" /> how hell it can be so? :) So complicated solution to bring $borrower unblessed through a such number of code lines just to get ... title? :) I assume these are some oooold times refactoring remnants, but - ... so please mates check if my patch to paycollect part is the correct solution (and I see the strong hivemind we have here :) ). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130417|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130421&action=edit Bug 29684: (QA follow-up) paycollect.pl don't needs borrower_data at all Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #25 from Andrew Nugged <nugged@gmail.com> --- I agree it's a very messy and huge template so it's easy to lose variables :)... That's why hivemind is needed. switching the ticket to "Failed QA": I am adding some more lost fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #26 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130477&action=edit Bug 29684: (QA follow-up) add lost borrower_data. prefix in memberentrygen.tt for: - primary_contact_method - autorenew_checkouts - sort1 - sort2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #27 from Andrew Nugged <nugged@gmail.com> --- umph! It's a complicated thing - we have interleaved usage of "patron." for some elements (for a reason?) in memberentrygen.tt, I at least re-checked once more all variables, might miss even, but found +4 more lost (patch above). I propose to re-do "Sign Off" once more, but Fridolin/Jonathan: you say? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130210|0 |1 is obsolete| | Attachment #130211|0 |1 is obsolete| | Attachment #130212|0 |1 is obsolete| | Attachment #130413|0 |1 is obsolete| | Attachment #130421|0 |1 is obsolete| | Attachment #130477|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131510&action=edit Bug 29684: Fix warn about js/locale_data.js (memberentry.pl) To reproduce (memberentry.pl): 1) Head over to the patron details page, press edit button to open the memberentry.pl page. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131511&action=edit Bug 29684: Fix warn about js/locale_data.js (paycollect.pl) To reproduce (paycollect.pl): 1) Prepare or use some existing patron with outstanding fines, go to the accounting section and open page where you make payment towards all fines. 2) The error message should have appeared in your log file about "File not found : default/js/locale_data.js". 3) Apply the patch. 4) Open the edit page again, ensure that the new error massage like that didn't appear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131512&action=edit Bug 29684: add honeypot to catch other warnings in the future Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131513&action=edit Bug 29684: (QA follow-up) Remove 2 extra 'borrower_data.' prefixes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131514&action=edit Bug 29684: (QA follow-up) paycollect.pl don't needs borrower_data at all Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131515&action=edit Bug 29684: (QA follow-up) add lost borrower_data. prefix in memberentrygen.tt for: - primary_contact_method - autorenew_checkouts - sort1 - sort2 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #34 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.05 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25790 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30315 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30315 [Bug 30315] Calendar widget in staff interface no longer translates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe this might be linked to bug 30315 on 20.11, but as we are close to end of life there maybe a backport is too risky? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30868 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30868 [Bug 30868] Modifying a patron - page not found error after fixing validation errors where the message is displayed at the top of the page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Saw this in 21.11: [WARN] Preventing $template->lang='-undef-' to be overwritten by template->{VARS}{lang}='-undef-' at /usr/share/koha/C4/Templates.pm line 118. It comes from the 'honeypot'. Undef overwritten by undef does not make me much wiser. Am I mistaken that this code looks like a bug itself? if(exists $self->{VARS}{lang}) { warn "Preventing \$template->lang='" . ($self->{vars}{lang}//'-undef-') . "' to be overwritten by template->{VARS}{lang}='" . ($self->{VARS}{lang}//'-undef-') . "'"; delete $self->{VARS}{lang}; } Should we replace $self->{vars}{lang} here by $vars->{lang}, which comes from $self->lang ?? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org