[Bug 8057] New: Error when adding a patron with email address
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8057 Priority: P5 - low Change sponsored?: --- Bug ID: 8057 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: Error when adding a patron with email address Severity: major Classification: Unclassified OS: All Reporter: joy@bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Patrons Product: Koha Adding a new patron with an email address results in the following error: Can't use string ("1") as a HASH ref while "strict refs" in use at /home/load02/kohaclone/members/memberentry.pl line 357. Patrons without an email address do not cause this error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8057 --- Comment #1 from Joy Nelson <joy@bywatersolutions.com> --- Patron was added with surname, firstname, primary email address, username, and password. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8057 --- Comment #2 from Joy Nelson <joy@bywatersolutions.com> --- This error does not occur when the "AutoEmailOpacUser" is set to Don't Send. When it is set to Send, the warning appears. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8057 --- Comment #3 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9466&action=edit Bug 8057 - Error when adding a patron with email address Caused by code assuming a the variable $err is a hashref when it is only a hashref if there is an error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8057 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8057 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9466|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 9512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9512&action=edit [SIGNED-OFF] Bug 8057 - Error when adding a patron with email address I was able to reproduce the bug in master. The patch fix it: signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8057 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8057 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * julian, you forgot to add your signature when uploading the [SIGNED-OFF] patch, i've added it * tiny patch, passed QA (note i'm not an addict of the ref($err) eq "HASH", but can't argue more than "i don't like it" so won't refuse pushing) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8057 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8057 --- Comment #6 from Kyle M Hall <kyle.m.hall@gmail.com> --- Paul, if you can recommend a better way to accomplish this, I'd be willing to write a replacement or followup patch. I believe there is a perl module for this type of thing, but I'm having trouble locating it. (In reply to comment #5)
QA comment: * julian, you forgot to add your signature when uploading the [SIGNED-OFF] patch, i've added it * tiny patch, passed QA (note i'm not an addict of the ref($err) eq "HASH", but can't argue more than "i don't like it" so won't refuse pushing)
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8057 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Valid bugfix, fixes a nasty error, pushed to stable will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org