[Bug 14530] New: 856$u URL checker ( check-url.pl ) complains about ftp based URLs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 Bug ID: 14530 Summary: 856$u URL checker ( check-url.pl ) complains about ftp based URLs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The script check-url.pl assumes that any URL not prefixed with http must be a relative URL. This is problematic as the URL could be prefixed with ftp as well. Any 856$u using an ftp url is given the error "400 URL Must be absolute". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41026&action=edit Bug 14530 - 856$u URL checker ( check-url.pl ) complains about ftp based URLs The script check-url.pl assumes that any URL not prefixed with http must be a relative URL. This is problematic as the URL could be prefixed with ftp as well. Any 856$u using an ftp url is given the error "400 URL Must be absolute". Since HTTP::Request cannot handle ftp urls, we should just skip them. I also noticed that check-url-quick.pl checks for prefixes with case insensitivity. That seems like a good idea so I've added that to check-url.pl Test Plan: 1) Apply this patch 2) Find or create a record with an ftp url in 865$u 3) Run check-url.pl 4) Note the ftp url is skipped 5) Run check-url-quick.pl 6) Note the ftp url is skipped -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |In Discussion --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Actually, couldn't you put an http URL for an ftp proxy into host? ./misc/cronjobs/check-url.pl --host=http://this.site.proxies.ftp.requests then it would attempt to go to http://this.site.proxies.ftp.requests/ftp://whatever/whereever/whatever.foo Personally, I'd prefer to see a re-write to allow for other protocols (bring back gopher! :) ). Because skipping the ftp URLs kind of defeats the purpose of the script which is to validate that the URLs exist. This could be a significant problem if a large portion of URLs are not http. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Also, quick says it replaces the non-quick version. Perhaps we should delete the non-quick version? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #4 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to M. Tompsett from comment #2)
Actually, couldn't you put an http URL for an ftp proxy into host?
./misc/cronjobs/check-url.pl --host=http://this.site.proxies.ftp.requests
then it would attempt to go to http://this.site.proxies.ftp.requests/ftp://whatever/whereever/whatever.foo
Personally, I'd prefer to see a re-write to allow for other protocols (bring back gopher! :) ).
Because skipping the ftp URLs kind of defeats the purpose of the script which is to validate that the URLs exist. This could be a significant problem if a large portion of URLs are not http.
That sounds reasonable, but not everyone will want to go to the trouble of setting that up. As a middle ground, I think adding a --skip-ftp parameter should suffice. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 --- Comment #5 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to M. Tompsett from comment #3)
Also, quick says it replaces the non-quick version. Perhaps we should delete the non-quick version?
That sounds good to me. Would you want to file a separate bug report for that? If that bug/patch makes it into master before this one, I'll just have to update it. Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- BTW, I was bored a while back, and actually wrote a forking LWP version. I'll attach it later, once I actually test it in place. :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org