[Bug 26007] New: Warning/ reminder for changes to Koha to MARC mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Bug ID: 26007 Summary: Warning/ reminder for changes to Koha to MARC mapping Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: bibliwho@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The batchRebuildBiblioTables job needs to be run whenever the mapping table is updated. This step is not listed in the manual or on koha2marclinks.pl page. Users may make changes without realizing that these won't take effect until the biblio tables are rebuilt, which in many cases will have to be done by a support company. Suggest adding this step to the manual and also as a reminder at the top of koha2marclinks.pl page. Or perhaps add this as a regular job on a weekly basis? Cab Vinton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- That's a good point, although that could be dangerous to automate for libraries with large collections. You don't want to be doing that every week to 1,000,000+ records. Even doing it 1 time during the upgrade could be dangerous, as it could make an upgrade last for many hours. This is another one of those instances where a temporary pop-up post-upgrade reminding people to run a cleanup job wouldn't be a bad idea. I'd be anti-automation in this case, since this is a job that should be deliberately planned by a human. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #2 from Cab Vinton <bibliwho@gmail.com> --- Thank you, David. Wasn't sure how resource-intensive that process might be. Pop-up and/or reminder would certainly do the trick. Cheers, Cab -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Cab Vinton from comment #2)
Thank you, David. Wasn't sure how resource-intensive that process might be. Pop-up and/or reminder would certainly do the trick.
Unfortunately, I don't know the best way of doing a pop-up and/or reminder. Tomas has mentioned that Koha has done that one or two times before, but I haven't investigated yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #4 from Cab Vinton <bibliwho@gmail.com> --- Above my pay grade as well, David, but easy enough to at least modify the text on that page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Cab, which exact text would you like to be displayed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109301&action=edit Bug 26007: Add/fix warning for changes to the Koha to MARC mappings There are 2 pages where one can change the Koha to MARC mappings in Koha: - When editing the configuration for a MARC subfield - On administration > Koha 2 MARC mappings This patch adds a warning that the batchRebuildBiblioTables script must be run if the mapping is changed. To test: - Go to Administration > MARC bibliographic frameworks > Any framework > MARC structure > Any field > Edit subfield - ÃThe hint about the batchRebuildBiblioTables will be on "Link" instead of "Koha Link". This is wrong as the link doesn't care about the mappings. - Go to Administration > Koha to MARC mappings - Verify there is no hint - Apply patch - Verify both pages now show an appropriate message -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109301|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109302&action=edit Bug 26007: Add/fix warning for changes to the Koha to MARC mappings There are 2 pages where one can change the Koha to MARC mappings in Koha: - When editing the configuration for a MARC subfield - On administration > Koha 2 MARC mappings This patch adds a warning that the batchRebuildBiblioTables script must be run if the mapping is changed. To test: - Go to Administration > MARC bibliographic frameworks > Any framework > MARC structure > Any field > Edit subfield - ÃThe hint about the batchRebuildBiblioTables will be on "Link" instead of "Koha Link". This is wrong as the link doesn't care about the mappings. - Go to Administration > Koha to MARC mappings - Verify there is no hint - Apply patch - Verify both pages now show an appropriate message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Warning/ reminder for |Warning/reminder for |changes to Koha to MARC |changes to Koha to MARC |mapping |mapping Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've also submitted a merge request to the manual to clean up and correct the information about Link and Koha link: https://gitlab.com/koha-community/koha-manual/-/merge_requests/390 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109302|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 109638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109638&action=edit Bug 26007: Add/fix warning for changes to the Koha to MARC mappings There are 2 pages where one can change the Koha to MARC mappings in Koha: - When editing the configuration for a MARC subfield - On administration > Koha 2 MARC mappings This patch adds a warning that the batchRebuildBiblioTables script must be run if the mapping is changed. To test: - Go to Administration > MARC bibliographic frameworks > Any framework > MARC structure > Any field > Edit subfield - The hint about the batchRebuildBiblioTables will be on "Link" instead of "Koha Link". This is wrong as the link doesn't care about the mappings. - Go to Administration > Koha to MARC mappings - Verify there is no hint - Apply patch - Verify both pages now show an appropriate message Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #10 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #8)
I've also submitted a merge request to the manual to clean up and correct the information about Link and Koha link: https://gitlab.com/koha-community/koha-manual/-/merge_requests/390
Caroline has merged the excellent manual changes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx David and Caroline! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy@rijksmuseum.nl --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The manual here needs some attention too ! Link If you enter a field/subfield here (200b), a link appears after the subfield in the MARC Detail view. This view is present only in the staff client, not the OPAC. If the librarian clicks on the link, a search is done on the database for the field/subfield with the same value. This can be used for 2 main topics : on a field like author (200f in UNIMARC), put 200f here, you will be able to see all bib records with the same author. on a field that is a link (4xx) to reach another bib record. For example, put 011a in 464$x, will find the serials that are with this ISSN. Warning This value should not change after data has been added to your catalog. If you need to change this value you must ask your system administrator to run misc/batchRebuildBiblioTables.pl. Koha link Koha is multi-MARC compliant. So, it does not know what the 245$a means, neither what 200$f (those 2 fields being both the title in MARC21 and UNIMARC). So, in this list you can “map” a MARC subfield to its meaning. Koha constantly maintains consistency between a subfield and its meaning. When the user wants to search on “title”, this link is used to find what is searched (245 if you’re MARC21, 200 if you’re UNIMARC). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The manual tells you to insert things like 200f which really should be search index. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Should we also refer to misc/batchRebuildItemsTables.pl on the Koha to MARC mappings page? Scroll to the bottom, you can also change mappings on items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109638|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 109649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109649&action=edit Bug 26007: Add/fix warning for changes to the Koha to MARC mappings There are 2 pages where one can change the Koha to MARC mappings in Koha: - When editing the configuration for a MARC subfield - On administration > Koha 2 MARC mappings This patch adds a warning that the batchRebuildBiblioTables script must be run if the mapping is changed. To test: - Go to Administration > MARC bibliographic frameworks > Any framework > MARC structure > Any field > Edit subfield - ÃThe hint about the batchRebuildBiblioTables will be on "Link" instead of "Koha Link". This is wrong as the link doesn't care about the mappings. - Go to Administration > Koha to MARC mappings - Verify there is no hint - Apply patch - Verify both pages now show an appropriate message Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> This commit message is not completely accurate. See the follow-ups. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 109650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109650&action=edit Bug 26007: (QA follow-up) Add index name to the q parameter The link constructed in MARC-detail is not consistent. It adds an index name but does not show in the query in the search box. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 109651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109651&action=edit Bug 26007: (QA follow-up) Replace wrong link values from sql installer files Field 943$a has link value "130". This does not work; 130 is not a search index. It should be Title-uniform. Note: Only used on a search link in the intranet MARC detail page. In some cases "130" should be replaced by "Title-uniform", but sometimes 130 without quotes had to be replaced. Performed by two sed statements on git grep results. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 109652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109652&action=edit Bug 26007: (QA follow-up) Remove message on marc_subfields_structure Why? Since the combo has been disabled since a few releases. If you want to change this mapping, you should do it on Koha to MARC mappings. This change is no longer per framework, but over all frameworks. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #13)
The manual here needs some attention too !
Link
If you enter a field/subfield here (200b), a link appears after the subfield in the MARC Detail view. This view is present only in the staff client, not the OPAC. If the librarian clicks on the link, a search is done on the database for the field/subfield with the same value. This can be used for 2 main topics :
Hi Marcel, I agree - that's why I patched it (see gitlab link above) ;) There currently doesn't appear to be a preview for the master manual, but you can see the changes applied now it git: https://gitlab.com/koha-community/koha-manual/-/commit/73660a674aaa3431ec9ea... I agree with your last follow-up, but we should stop displaying this as a non-functional pull-down on the configuration page then - it fooled me. Bug 26007: (QA follow-up) Replace wrong link values from sql installer files is missing updates to the .yml files for the en and es-ES based installers. I think this would have been better as a separate bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #20)
(In reply to Marcel de Rooy from comment #13)
I agree with your last follow-up, but we should stop displaying this as a non-functional pull-down on the configuration page then - it fooled me.
Yeah, please remove it on a new report.
Bug 26007: (QA follow-up) Replace wrong link values from sql installer files is missing updates to the .yml files for the en and es-ES based installers. I think this would have been better as a separate bug.
If you prefer, feel free to move this patch to a new report. Could you sign off? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We need a follow-up here still for the .yml en files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #23)
We need a follow-up here still for the .yml en files.
Will add a patch. I remember that I did change it, but I may have changed my sed statements later on and it fell out of the selection due to its new formatting somehow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 109881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109881&action=edit Bug 26007: (QA follow-up) Fix English yml file git grep -l -E "link:\s*\"?[0-9]" | xargs sed -i -e "/link:/ s/130/\"Title-uniform\"/" Only one occurrence without quotes around 130. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- @RM: Please push last patch only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |There are two pages where release notes| |you can change the Koha to | |MARC mappings : | | | |- When | |editing the configuration | |for a MARC subfield | |- On | |Koha administration > | |catalog > Koha to MARC | |mapping | | | |This patch adds a | |warning that the | |batchRebuildBiblioTables | |script must be run if the | |mapping is changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|There are two pages where |In current versions of Koha release notes|you can change the Koha to |you can no longer change |MARC mappings : |the Koha to MARC mappings | |from the frameworks, but |- When |only from the Koha to MARC |editing the configuration |mapping page in |for a MARC subfield |administration. This patch |- On |cleans up the hints on the |Koha administration > |framework page and adds a |catalog > Koha to MARC |well visible note on the |mapping |Koha to MARC mapping page. | |Any changes to the mappings |This patch adds a |require that you run the |warning that the |batchRebuildBiblioTables |batchRebuildBiblioTables |script to fully take |script must be run if the |effect. |mapping is changed. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | --- Comment #28 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Severity|trivial |enhancement --- Comment #29 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org