[Bug 29987] New: Manual credits are not recorded for a register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Bug ID: 29987 Summary: Manual credits are not recorded for a register Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@ptfs-europe.com What I did: - Activated UseRegister - Added a cash register - Made sure it was selected for my login and showed in upper right corner - Went to a sample patron's account (used Nicole and Henry) - Added a manual credit using "Create manual credit" The cash register was not recorded: select * from accountlines; register_id is NULL As this would mean an unexplainable surplus of cash, I think it's a bug? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Credit is credit, it's not a case of money being handed over so we don't currently give the option to select a register on the manual credit form so it wouldn't be recorded. In the cash management sense we're only interested in money changing hands so we only record registers for those cases. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, for me a credit means money exchanging hands. A patron might make a deposit that future fines/fees may be deducted from. Otherwise the option to pay out a credit would not make any sense...? I tihnk at least this needs a little more discussion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Wondering: Maybe we need the payment type pull down on the credits? That way libraries could say it was a cash or other? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We could certainly need the payment type pulldown to go with it.. I can take a look at adding this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136743&action=edit Bug 29987: Add register support to manual credits This patch adds the register and transaction type selection options to the manual credit page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136743|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 136755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136755&action=edit Bug 29987: Add register support to manual credits This patch adds the register and transaction type selection options to the manual credit page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): 1. Followed steps in the bug description to replicate the issue. 2. After applying the patch, repeated these steps to add some new transactions. There are now dropdown lists for transaction type and cash register when adding manual credits. 3. These transactions are now included in the cash summary report for the library, and a cashup can be recorded. Notes: 1. If the EnablePointOfSale system preference is disabled, but UseCashRegisters is enabled, then to get to the cash management area to cashup go to Tools > Cash management > Cash summary for <currentlibrary> (http://127.0.0.1:8081/cgi-bin/koha/pos/registers.pl) 2. I'm assuming that libraries would just use this going forward to manage cash - previous cash manual credits would have already been dealt with in someway (in terms of reconciling), so there is no need to update existing transactions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the recording of release notes| |manual credits for patrons | |so that these transactions | |are now included in the | |cash summary report for a | |library. When adding a | |manual credit, there are | |now fields for choosing the | |transaction type and cash | |register. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #8 from David Nind <david@davidnind.com> --- After testing this, signing off, and adding a draft release note, I noticed that: 1. In the cash summary for the library, the amounts are now included in the income (cash) total (good!). 2. However, they are not included in the bankable column (bad?). 3. In the details for the cash register, for transactions there is a total, but it says "No data available in table" (and the same for the older transactions). 4. If you do a cashup, these transactions are not included (if there are no other cash transactions, then do a cashup the message is "Please confirm that you have removed 0.00 from the cash register and left a float of 0.00."). My query: If you receive cash (say, paying charges in advance) and create a manual credit, then should it be included in items 2-4? I think it should, as when you go to do the banking you want it included in that total so that everything reconciles. However, other manual credits, for example if you write off charges, shouldn't be as you have neither added to or taken anything out of the cash register. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for reviewing David.. you've highlighted perfectly what I feared may be the case. Cashup as it stands makes some assumptions that adding cash to a register should always have an associated debt to offset. I'll try to remind myself how the maths and queries work today to see if this is resolvable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can confirm David's findings in comment#8. Setting to Failed QA for now as I feel that the display on the cash register transactions and summary is not right yet. I do think the payment type option on the credit page is the right way to go, but probably needs some more adjustments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139703&action=edit Bug 29987: Display credit without offsets in transactions This patch adds a row to the transactions table for credits without corresponding offsets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is a somewhat horrible work around for how rowGroup works in datatables.. I'm considering some other approaches as part of converting the table to an ajax driven datatable... perhaps dropping rowGroup and instead triggering Ajax calls to populate the detailed breakdown rows. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139704&action=edit Bug 29987: (follow-up) Fix missing payment type The payment type include has changed since the patch was first written, we now require a 'type' is passed to properly set the field name. This should fix the 'bankable' issue raised. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139703|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139705&action=edit Bug 29987: Display credit without offsets in transactions This patch adds a row to the transactions table for credits without corresponding offsets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to David Nind from comment #8)
After testing this, signing off, and adding a draft release note, I noticed that:
1. In the cash summary for the library, the amounts are now included in the income (cash) total (good!).
Correct, I believe this is as expected
2. However, they are not included in the bankable column (bad?).
Payment type was not being recorded correctly.. that is now fixed in the first follow-up. 'Cash' type transactions should be 'bankable' (I think I have a bug somewhere to make the types included in bankable configurable but for now it's cash only)
3. In the details for the cash register, for transactions there is a total, but it says "No data available in table" (and the same for the older transactions).
This is the second follow up patch.. though I've only implimented it for current transactions so far.. we can copy the logic to old transactions if we're happy it makes sense.
4. If you do a cashup, these transactions are not included (if there are no other cash transactions, then do a cashup the message is "Please confirm that you have removed 0.00 from the cash register and left a float of 0.00.").
I think this should be fixed by the first follow-up above.
My query: If you receive cash (say, paying charges in advance) and create a manual credit, then should it be included in items 2-4?
I think it should, as when you go to do the banking you want it included in that total so that everything reconciles.
However, other manual credits, for example if you write off charges, shouldn't be as you have neither added to or taken anything out of the cash register.
You are correct.. any process by which money actually changes hands at the register should be reported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 pascal.uphaus@gwdg.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pascal.uphaus@gwdg.de Status|Needs Signoff |Failed QA --- Comment #16 from pascal.uphaus@gwdg.de --- I applied the patches and did the testplan described in the first comment. The register_id was still NULL. Is the testplan still up-to-date? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Pascal, thx for testing! Did you restart Plack/Memcached after applying the patch? Sometimes you won't see the change as Plack still has the old version of the files. On a koha-testing-docker environment there is a shortcut to do this: restart_all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Hi, we used a sandbox and unless something went wrong, the services should be restarted when applying a patch. We were screen sharing and I didn't notice anything suspicious that could explain that register_id was still NULL. We double checked on the git log of the sandbox that the 3 patches were applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136755|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141165&action=edit Bug 29987: Add register support to manual credits This patch adds the register and transaction type selection options to the manual credit page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139704|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141166&action=edit Bug 29987: (follow-up) Fix missing payment type The payment type include has changed since the patch was first written, we now require a 'type' is passed to properly set the field name. This should fix the 'bankable' issue raised. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139705|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141167&action=edit Bug 29987: Display credit without offsets in transactions This patch adds a row to the transactions table for credits without corresponding offsets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just a quick rebase and now testing on a sandbox.. I can't replicate any of your issues locally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to pascal.uphaus from comment #16)
I applied the patches and did the testplan described in the first comment. The register_id was still NULL. Is the testplan still up-to-date?
Did you select a register at the point of adding a manual credit.. there is a select box and you can opt to not select anything by default (There's a setting that makes the register required, but that's disabled by default and so not enabled on the sandboxes) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141171&action=edit Bug 29987: Improve validation This patch adds hinting to display the required state of the cash register fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141165|0 |1 is obsolete| | --- Comment #25 from David Nind <david@davidnind.com> --- Created attachment 141469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141469&action=edit Bug 29987: Add register support to manual credits This patch adds the register and transaction type selection options to the manual credit page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141166|0 |1 is obsolete| | --- Comment #26 from David Nind <david@davidnind.com> --- Created attachment 141470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141470&action=edit Bug 29987: (follow-up) Fix missing payment type The payment type include has changed since the patch was first written, we now require a 'type' is passed to properly set the field name. This should fix the 'bankable' issue raised. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141167|0 |1 is obsolete| | --- Comment #27 from David Nind <david@davidnind.com> --- Created attachment 141471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141471&action=edit Bug 29987: Display credit without offsets in transactions This patch adds a row to the transactions table for credits without corresponding offsets Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141171|0 |1 is obsolete| | --- Comment #28 from David Nind <david@davidnind.com> --- Created attachment 141472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141472&action=edit Bug 29987: Improve validation This patch adds hinting to display the required state of the cash register fields. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #29 from David Nind <david@davidnind.com> --- I've retested and signed off. I think things are now working as expected: - Any manual credits that involve cash are now recorded and display correctly when recording a cashup - When creating manual credits, you can now choose the transaction type (not sure how to add transaction types, but just used the cash option) - The cash register (register_id) is recorded correctly in the database End result = when recording cashups for a register, the correct amount is shown for cash transactions. Note that for the transaction history for the cash register, it displays as "No data available in table", but the total income is shown correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141469|0 |1 is obsolete| | Attachment #141470|0 |1 is obsolete| | Attachment #141471|0 |1 is obsolete| | Attachment #141472|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142321&action=edit Bug 29987: Add register support to manual credits This patch adds the register and transaction type selection options to the manual credit page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142322&action=edit Bug 29987: (follow-up) Fix missing payment type The payment type include has changed since the patch was first written, we now require a 'type' is passed to properly set the field name. This should fix the 'bankable' issue raised. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142323&action=edit Bug 29987: Display credit without offsets in transactions This patch adds a row to the transactions table for credits without corresponding offsets Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142324&action=edit Bug 29987: Improve validation This patch adds hinting to display the required state of the cash register fields. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142325&action=edit Bug 29987: (QA follow-up) Remove unused cnt attribute missing a filter Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.08 released in| | --- Comment #36 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com Version(s)|22.11.00, 22.05.08 |22.11.00, 22.05.08, released in| |21.11.15 --- Comment #37 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #38 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org