[Bug 8795] New: Just add the login branch In orderreveive.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 Priority: P5 - low Change sponsored?: --- Bug ID: 8795 Assignee: koha-bugs@lists.koha-community.org Summary: Just add the login branch In orderreveive.tt Severity: enhancement Classification: Unclassified OS: All Reporter: christophe.croullebois@biblibre.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha The homebranch and holdingbranch ddl in item block are not default selected, they just show the first line. With this patch I just put the default choice as the login branch. To test : without patch the first line of the ddl is shown. With the patch the login branch is shown in homebranch and holdingbranch. thx for testing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |christophe.croullebois@bibl |ity.org |ibre.com --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 12370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12370&action=edit proposed patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12370|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13062&action=edit Bug 8795: Adding the login branch as default in orderreceive.tt The homebranch and holdingbranch ddl in item block are not default selected. I just put the default choice as the login branch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Before the patch, orderreceive.pl showed the branches alphabetically. After the patch, it automatically selects the branch I'm logged in to. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: The PrepareItemrecordDisplay routine seems not very clean, a lot of processing is useless. But it is not the goal of this patch. This patch works as expected. So I mark it as Passed QA. note to test: AcqCreateItem = "receive an order" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I would like to get a second QA team sign-off on this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13062|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13670&action=edit Bug 8795: Adding the login branch as default in orderreceive.tt The homebranch and holdingbranch ddl in item block are not default selected. I just put the default choice as the login branch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Before the patch, orderreceive.pl showed the branches alphabetically. After the patch, it automatically selects the branch I'm logged in to. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Complexity of the|--- |Small patch patch| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Still waiting a second QA team member sign off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|jonathan.druart@biblibre.co |m.de.rooy@rijksmuseum.nl |m | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Works as advertised. Although this patch only adds one line, it was quite hard to verify if it works and where it works. The routine PrepareItemrecordDisplay is used only in: acqui/addorderiso2709.pl C4/Serials.pm serials/serials-edit.pl services/itemrecorddisplay.pl (only called via additem.js) But that is not the full picture: Script orderreceive.pl goes via additem.js to itemrecorddisplay.pl using the routine. Script neworderempty.pl also uses the routine that way. Note that this patch therefore DOES also affect AcqCreateItem=ordering ! Have tested that. The patch makes Acquistion behave like Cataloguing where the routine GetBranchesLoop from Branch.pm already did something similar. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13670|0 |1 is obsolete| | --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 14210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14210&action=edit Patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org