[Bug 41084] New: Zotero connector broken by bug 37370
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Bug ID: 41084 Summary: Zotero connector broken by bug 37370 Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Depends on: 37370 This is difficult.. as I said in the comment on bug 37370, we find libraries don't want to visually show utf8 in the export menu, but do want Zotero to work. As such, completely denying the utf8 option, which is the default fallback when no format is passed too, breaks the Zotero browser extension. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37370 [Bug 37370] opac-export.pl can be used even if exporting disabled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Perhaps a possible solution is a second preference to allow Zotero specifically for export.. and use that to trigger an allow on utf8 export even if it's not selected in the UI facing preference? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@openfifth.c |tomascohen@gmail.com |o.uk | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 190775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190775&action=edit Bug 41084: Add EnableZotero system preference This system preference will be used to enable opac-export.pl?format=utf8 regardless of the OpacExportOptions values, specifically for Zotero integration support. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 190776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190776&action=edit Bug 41084: Allow utf8 export format when EnableZotero is enabled When the EnableZotero system preference is enabled, allow the utf8 format in opac-export.pl regardless of the OpacExportOptions settings. This enables Zotero integration by ensuring the required UTF-8 encoded MARC format is always available when the feature is enabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190776|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 190777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190777&action=edit Bug 41084: Allow utf8 export format when EnableZotero is enabled When the EnableZotero system preference is enabled, allow the utf8 format in opac-export.pl regardless of the OpacExportOptions settings. This enables Zotero integration by ensuring the required UTF-8 encoded MARC format is always available when the feature is enabled. To test: 1. Install Zotero (https://www.zotero.org) 2. Install the browser extension (I did in in Chrome, not sure it exists for FF) 3. Perform a search in your koha instance. e.g. http://kohadev.localhost/cgi-bin/koha/opac-search.pl?idx=&q=agrovoc&weight_search=1 4. Open the Zotero extension => SUCCESS: It lists the search results for saving them 5. Choose one and save => FAIL: It says there was an error saving 6. Apply this patches 7. Run: $ ktd --shell k$ updatedatabase 8. Make sure EnableZotero is enabled 9. Repeat 3-5 => SUCCESS: All good this time 10. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190775|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190777|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 190778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190778&action=edit Bug 41084: Add EnableZotero system preference This system preference will be used to enable opac-export.pl?format=utf8 regardless of the OpacExportOptions values, specifically for Zotero integration support. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 190779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190779&action=edit Bug 41084: Allow utf8 export format when EnableZotero is enabled When the EnableZotero system preference is enabled, allow the utf8 format in opac-export.pl regardless of the OpacExportOptions settings. This enables Zotero integration by ensuring the required UTF-8 encoded MARC format is always available when the feature is enabled. To test: 1. Install Zotero (https://www.zotero.org) 2. Install the browser extension (I did in in Chrome, not sure it exists for FF) 3. Perform a search in your koha instance. e.g. http://kohadev.localhost/cgi-bin/koha/opac-search.pl?idx=&q=agrovoc&weight_search=1 4. Open the Zotero extension => SUCCESS: It lists the search results for saving them 5. Choose one and save => FAIL: It says there was an error saving 6. Apply this patches 7. Run: $ ktd --shell k$ updatedatabase 8. Make sure EnableZotero is enabled 9. Repeat 3-5 => SUCCESS: All good this time 10. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- I'm not seeing any error when using the Zotero connector for the browsers I use (I've used Zotero for a while, on and off). For me, it seems to work OK from: - The search results page - Individual bibliographic record pages My set up: - Zotero version: 7.0.30 (the latest) - Browser: Firefox connector - Browser: Chrome connector - There are also connectors for Edge and Safari (bundled with the Zotero Connector for Safari) - Operating system: Ubuntu 22.04 I can test on Windows if that would help. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to David Nind from comment #7)
I'm not seeing any error when using the Zotero connector for the browsers I use (I've used Zotero for a while, on and off).
For me, it seems to work OK from: - The search results page - Individual bibliographic record pages
My set up: - Zotero version: 7.0.30 (the latest) - Browser: Firefox connector - Browser: Chrome connector - There are also connectors for Edge and Safari (bundled with the Zotero Connector for Safari) - Operating system: Ubuntu 22.04
I can test on Windows if that would help.
Have you disabled all export options? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #9 from David Nind <david@davidnind.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #8)
Have you disabled all export options?
I hadn't! If no options are selected for OpacExportOptions, I now get the error. Other testing notes, after the patches, the book details are saved in Zotero no matter what I set. That is, it makes no difference if I set EnableZotero or not or OpacExportOptions or not, or any combination. The only exception is with "Don't enable" and "none selected", there is a Zotero plugin error. The record is still saved into Zotero anyway. 1. If I set - EnableZotero = Enable - OpacExportOptions: All selected ==> Book details saved in Zotero 3. If I set - EnableZotero = Enable - OpacExportOptions: None selected ==> Book details saved in Zotero 4. If I set - EnableZotero = Don't enable - OpacExportOptions: All selected ==> Book details saved in Zotero 5. If I set - EnableZotero = Don't enable - OpacExportOptions: None selected ==> There is an error for the Zotero plugin "An error occurred saving with Library Catalog (Koha). Attempting to save using unAPI instead." ==> Book details saved in Zotero In terms of the description for the EnableZotero system preference, I don't understand what it means. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Lauren Denny <lauren_denny@sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny@sil.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This also seems to be causing t/db_dependent/api/v1/holds.t to fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #10)
This also seems to be causing t/db_dependent/api/v1/holds.t to fail.
Please ignore me, I'm clearly lost. :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190778|0 |1 is obsolete| | Attachment #190779|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 201508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201508&action=edit Bug 41084: Add EnableZotero system preference This system preference will be used to enable opac-export.pl?format=utf8 regardless of the OpacExportOptions values, specifically for Zotero integration support. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 201509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201509&action=edit Bug 41084: Allow utf8 export format when EnableZotero is enabled When the EnableZotero system preference is enabled, allow the utf8 format in opac-export.pl regardless of the OpacExportOptions settings. This enables Zotero integration by ensuring the required UTF-8 encoded MARC format is always available when the feature is enabled. To test: 1. Install Zotero (https://www.zotero.org) 2. Install the browser extension (I did in in Chrome, not sure it exists for FF) 3. Perform a search in your koha instance. e.g. http://kohadev.localhost/cgi-bin/koha/opac-search.pl?idx=&q=agrovoc&weight_search=1 4. Open the Zotero extension => SUCCESS: It lists the search results for saving them 5. Choose one and save => FAIL: It says there was an error saving 6. Apply this patches 7. Run: $ ktd --shell k$ updatedatabase 8. Make sure EnableZotero is enabled 9. Repeat 3-5 => SUCCESS: All good this time 10. Sign off :-D Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 201510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201510&action=edit Bug 41084: Re-format database update for new way of addind system preferences ... also adds say_success. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201508|0 |1 is obsolete| | Attachment #201509|0 |1 is obsolete| | Attachment #201510|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 201996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201996&action=edit Bug 41084: Add EnableZotero system preference This system preference will be used to enable opac-export.pl?format=utf8 regardless of the OpacExportOptions values, specifically for Zotero integration support. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 201997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201997&action=edit Bug 41084: Allow utf8 export format when EnableZotero is enabled When the EnableZotero system preference is enabled, allow the utf8 format in opac-export.pl regardless of the OpacExportOptions settings. This enables Zotero integration by ensuring the required UTF-8 encoded MARC format is always available when the feature is enabled. To test: 1. Install Zotero (https://www.zotero.org) 2. Install the browser extension (I did in in Chrome, not sure it exists for FF) 3. Perform a search in your koha instance. e.g. http://kohadev.localhost/cgi-bin/koha/opac-search.pl?idx=&q=agrovoc&weight_search=1 4. Open the Zotero extension => SUCCESS: It lists the search results for saving them 5. Choose one and save => FAIL: It says there was an error saving 6. Apply this patches 7. Run: $ ktd --shell k$ updatedatabase 8. Make sure EnableZotero is enabled 9. Repeat 3-5 => SUCCESS: All good this time 10. Sign off :-D Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 201998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201998&action=edit Bug 41084: Re-format database update for new way of addind system preferences ... also adds say_success. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 201999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201999&action=edit Bug 41084: (QA follow-up) Add new pref to UsageStats Add the new preference to UsageStats for HEA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k --- Comment #19 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi guys, not blockers but I think this is confusing for someone looking at this for the first time. This is my understanding of the current implementation: 1) Even if EnableZotero is off, if OpacExportOptions contains 'utf8', opac-export.pl?bib=76&format=utf8 will still work 2) EnableZotero only matters when utf8 is NOT in OpacExportOptions - it's a fallback allowing the request to succeed anyway 3) I understand that the default being enabled makes sense. Assuming that if utf8 wasn't in OpacExportOptions, that wasn't a deliberate attempt to block Zotero, so defaulting this to on to establish the new standard behavior makes sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #20 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #21 from David Nind <david@davidnind.com> --- Even though this is now main, running updatedatabase (when testing other bugs) generates: updatedatabase DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_41084.pl [18:45:24]: Bug 41084 - Add EnableZotero system preference Added new system preference 'EnableZotero' Does something need to be fixed with the database update? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #22 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- (In reply to David Nind from comment #21)
Does something need to be fixed with the database update?
Thank you David, I missed removing the atomicupdate, will fix! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41084 --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org