[Bug 15159] New: TestBuilder behaviour on AI values should be tested
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 Bug ID: 15159 Summary: TestBuilder behaviour on AI values should be tested Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: gmcharlt@gmail.com Currently, there is no test on TestBuilder's handling of AI values. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 44648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44648&action=edit Bug 15159: TestBuilder behaviour on AI values should be tested This patch introduces a test for t::lib::TestBuilder to check it doesn't mess with AI values. As it is generating random values based on the defined column type, chances are that it is creating the AI values on its own, instead of letting the DB handle it. This could be problematic of course. This test uses the 'biblio' table by creating two values and checking their biblionumbers are consecutive. To test: - Apply the patch - Run: $ prove t/db_dependent/TestBuilder.t -v => SUCCESS: The new tests are run and: - biblio.biblionumber is detected as an auto-increment column - generated biblionumbers are consecutive - Sign off Regards -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44648|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 44788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44788&action=edit [SIGNED-OFF]Bug 15159: TestBuilder behaviour on AI values should be tested This patch introduces a test for t::lib::TestBuilder to check it doesn't mess with AI values. As it is generating random values based on the defined column type, chances are that it is creating the AI values on its own, instead of letting the DB handle it. This could be problematic of course. This test uses the 'biblio' table by creating two values and checking their biblionumbers are consecutive. To test: - Apply the patch - Run: $ prove t/db_dependent/TestBuilder.t -v => SUCCESS: The new tests are run and: - biblio.biblionumber is detected as an auto-increment column - generated biblionumbers are consecutive - Sign off Regards Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All tests successful. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44788|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44910&action=edit [PASSED QA] Bug 15159: TestBuilder behaviour on AI values should be tested This patch introduces a test for t::lib::TestBuilder to check it doesn't mess with AI values. As it is generating random values based on the defined column type, chances are that it is creating the AI values on its own, instead of letting the DB handle it. This could be problematic of course. This test uses the 'biblio' table by creating two values and checking their biblionumbers are consecutive. To test: - Apply the patch - Run: $ prove t/db_dependent/TestBuilder.t -v => SUCCESS: The new tests are run and: - biblio.biblionumber is detected as an auto-increment column - generated biblionumbers are consecutive - Sign off Regards Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All tests successful. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15159 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org