[Bug 5880] New: C4/Koha.pm : adding two functions GetAutorisedValueByCode and GetKohaImageurlFromAuthorisedValues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5880 Bug #: 5880 Summary: C4/Koha.pm : adding two functions GetAutorisedValueByCode and GetKohaImageurlFromAuthorisedValues Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: chris@bigballofwax.co.nz QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5880 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-16 03:07:07 UTC --- Created attachment 3318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3318 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5880 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5880 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Patch Status|Needs Signoff |Signed Off --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-16 10:37:32 UTC --- Tested on master and works as expected. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5880 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-17 01:45:47 UTC --- Pushed, I do not there are no tests for these new subroutines, you would win much respect and joy and kudos and the people would praise your name, if you had unit tests for any new functions you write :) Please test and mark resolved -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5880 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-03-17 11:00:49 UTC --- Pod says GetAuthorisedValueByCode returns a hashref code returns a scalar. Thats why we need tests -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5880 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-03-17 11:14:24 UTC --- well, we need test, but test can't check pod is lying ;-) (julian is writing a test anyway) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5880 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-17 11:32:29 UTC --- Created attachment 3336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3336 Follow up patch Unit tests are there ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5880 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-17 13:32:35 UTC --- Created attachment 3340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3340 Improved unit tests -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5880 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-17 20:13:28 UTC --- Follow up patches with unit tests pushed. Kudos to Biblibre and Julian! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5880 --- Comment #9 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-03-22 15:25:39 UTC --- Created attachment 3399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3399 Follow-up patch to correct error in pod -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5880 --- Comment #10 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-03-22 15:26:41 UTC --- Corrected the error in the documentation in a supplementary patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5880 --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-24 09:08:31 UTC --- Follow up patch pushed, Thanks Colin -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5880 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5880 --- Comment #12 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-07 10:50:43 UTC --- This bug is mentioned in: Bug 5880 : C4/Koha.pm : adding two functions GetAutorisedValueByCode and GetKohaImageurlFromAuthorisedValues http://lists.koha-community.org/pipermail/koha-patches/2011-March/014075.htm... Bug 5880 : C4/Koha.pm : adding two functions GetAutorisedValueByCode and GetKohaImageurlFromAuthorisedValues http://lists.koha-community.org/pipermail/koha-patches/2011-March/014080.htm... Follow up for bug 5880: Added unit tests for the two new subroutines http://lists.koha-community.org/pipermail/koha-patches/2011-March/014106.htm... Follow up for bug 5880: Improved unit test http://lists.koha-community.org/pipermail/koha-patches/2011-March/014111.htm... Bug 5880: Correct misleading pod in new subroutine http://lists.koha-community.org/pipermail/koha-patches/2011-March/014189.htm... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org