[Bug 16565] New: additional_fields and additional_field_values are not dropped in kohastructure.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 Bug ID: 16565 Summary: additional_fields and additional_field_values are not dropped in kohastructure.sql Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10855 Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 [Bug 10855] Custom fields for subscriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
From the SQL CLI, source the kohastructure.sql file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51717&action=edit Bug 16565: Drop additional_fields and additional_field_values before creating them These 2 tables should be dropped before trying to create them Test plan: source it again => Without this patch you get 2 warnings ERROR 1050 (42S01) at line 3580 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_fields' already exi sts ERROR 1050 (42S01) at line 3596 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_field_values' alrea dy exists => With this patch, you won't get them -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
From the SQL CLI, source the kohastructure.sql file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51717|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 51811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51811&action=edit Bug 16565: Drop additional_fields and additional_field_values before creating them These 2 tables should be dropped before trying to create them Test plan: source it again => Without this patch you get 2 warnings ERROR 1050 (42S01) at line 3580 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_fields' already exi sts ERROR 1050 (42S01) at line 3596 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_field_values' alrea dy exists => With this patch, you won't get them Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
From the SQL CLI, source the kohastructure.sql file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51811|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51944&action=edit Bug 16565: Drop additional_fields and additional_field_values before creating them These 2 tables should be dropped before trying to create them Test plan: source it again => Without this patch you get 2 warnings ERROR 1050 (42S01) at line 3580 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_fields' already exi sts ERROR 1050 (42S01) at line 3596 in file: 'installer/data/mysql/kohastructure.sql': Table 'additional_field_values' alrea dy exists => With this patch, you won't get them Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16565 Bug 16565 depends on bug 10855, which changed state. Bug 10855 Summary: Custom fields for subscriptions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org