[Bug 31185] New: Link authorities automatically doesn't detect duplicate authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Bug ID: 31185 Summary: Link authorities automatically doesn't detect duplicate authorities Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: adolfo.rodriguez@xercode.es QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When cataloging a bibliographic record, the template addbiblio.tt has a code to show that there is more than one local match for the entry point (MULTIPLE_MATCH) but the function LinkBibHeadingsToAuthorities never returns that code. This means that when the authority you are looking for is duplicated and you click the "Link authorities automatically", you obtain the following message "No matching authority found." instead of "More than one local match found. Possibly a duplicate authority!" This gives the false impression that the authority doesn't exist. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 --- Comment #1 from Adolfo <adolfo.rodriguez@xercode.es> --- Created attachment 137860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137860&action=edit Detect duplicate authorities using Link authorities automatically This patch fixes LinkBibHeadingsToAuthorities so it detects duplicate authorities using "Link authorities automatically" To test 1 Make sure the system preference AutoCreateAuthorities is turned to don't generate 2 Create a duplicate authority and check that search in Authorities module returns both. For example, two Personal Name (Smith, John) 3 Create a new record and fill the entry point with the same text of the authorities you just created. For example 100$a Smith, John 4 Click "Link authorities automatically" and you will obtain the following message "No matching authority found." 5 Apply patch, restart services 6 Click "Link authorities automatically" and you will obtain the following message "More than one local match found. Possibly a duplicate authority!" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Don't forget to switch the status to "Needs Signoff", once you have a patch attached for testing! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31231 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Rachael <rachael.laritz@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 --- Comment #3 from Rachael <rachael.laritz@inlibro.com> --- Created attachment 138518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138518&action=edit Bug 31185 - Link authorities automatically doesn't detect duplicate authorities Signed-off-by: Rachael Laritz <rachael.laritz@inlibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137860|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |adolfo.rodriguez@xercode.es |ity.org | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please don't forget to set Assignee! :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139857&action=edit Bug 31185: Link authorities automatically doesn't detect duplicate authorities This patch fixes LinkBibHeadingsToAuthorities so it detects duplicate authorities using "Link authorities automatically" To test 1 Make sure the system preference AutoCreateAuthorities is turned to don't generate 2 Create a duplicate authority and check that search in Authorities module returns both. For example, two Personal Name (Smith, John) 3 Create a new record and fill the entry point with the same text of the authorities you just created. For example 100$a Smith, John 4 Click "Link authorities automatically" and you will obtain the following message "No matching authority found." 5 Apply patch, restart services 6 Click "Link authorities automatically" and you will obtain the following message "More than one local match found. Possibly a duplicate authority!" Signed-off-by: Rachael Laritz <rachael.laritz@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138518|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have added the bug description and test plan to the commit message according to our guidelines. Also happy to sign off on this, but we'll need a unit test covering this change for it to pass QA. Please let us know if we can help with that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Yikes, there are hardly any tests for LinkBibHeadingsToAuthorities at the moment :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'd love to see this one move forward.. but I'm not sure I can pick up adding the tests myself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Agnes Rivers-Moore <arm@hanover.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm@hanover.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 150610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150610&action=edit Bug 31185: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- I added a unit test, but I discovered that if AutoCreateAuthorities is on, we won't report multiple matches. I think we should? Feel free to adjust test expectations if not, but I suspect it reveals a problem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139857|0 |1 is obsolete| | --- Comment #11 from Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> --- Created attachment 150762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150762&action=edit New patch version The test expectations are correct, it should report multiple matches if AutoCreateAuthorities is on as it's an issue must be dealt with no matter the value of that preference. This is an updated version of the patch that reports multiple matches in both scenarios. Thanks for the unit test! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but this doesn't apply: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31185: Unit test error: sha1 information is lacking or useless (t/db_dependent/Biblio.t). error: could not build fake ancestor Patch failed at 0001 Bug 31185: Unit test hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-31185-Unit-test-xmcWMx.patch Please also make sure to include a bug description and a test plan in the commit message when re-submitting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150610|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152507&action=edit Bug 31185: Unit test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152508&action=edit Bug 31185: Link authorities automatically doesn't detect duplicate authorities Signed-off-by: Rachael Laritz <rachael.laritz@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All now working as expected and passing the test Nick wrote (thanks for that Nick). I'm happy to say this seems solid now. I've rebased and am happy to PQA. Note, you might want to look into using git-bz Adolfo, it really helps with uploading the patches etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |pedro.amorim@ptfs-europe.co | |m Resolution|--- |FIXED --- Comment #18 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Doesn't apply on 22.11.x. Not backporting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36938 [Bug 36938] Biblio.t generates warnings -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org