[Bug 35475] New: Untranslatable string in booking modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Bug ID: 35475 Summary: Untranslatable string in booking modal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr, jonathan.druart+koha@gmail.com Depends on: 29002 When booking an item there is an untranslatable string in the modal: "Search for a patron" The calendar was also behaving a little oddly requiring a double click to take the date (just leaving the note here to see if someone else sees that) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Summary|Untranslatable string in |Untranslatable strings in |booking modal |booking modal and JS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 159704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159704&action=edit Bug 35475: Makes strings in booking JS file translatable This makes several strings in the booking specific JS file translatable. To test: * Make an item bookable: * Find a record with items in your catalog or create one * From the details page, switch to the items tab * Mark items as bookable * Add a booking, verify the modal works as expected * Check the bookings tab * Verify the column headings of the bookings table show correctly * Verify the "Biblio level" and "Item" in the calendar show Note: Months don't translate, this will be a separate bug * Cancel a booking, edit a booking... make sure everything works as expected * If you can: Install a translation and verify strings show up in po files as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Inconsistent use of _() and __() in .js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Also I think that the following line content: _("Item") + " " + item.external_id, should be replaced with content: _("Item %s").format(item.external_id), -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159704|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 160284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160284&action=edit Bug 35475: Makes strings in booking JS file translatable This makes several strings in the booking specific JS file translatable. To test: * Make an item bookable: * Find a record with items in your catalog or create one * From the details page, switch to the items tab * Mark items as bookable * Add a booking, verify the modal works as expected * Check the bookings tab * Verify the column headings of the bookings table show correctly * Verify the "Biblio level" and "Item" in the calendar show Note: Months don't translate, this will be a separate bug * Cancel a booking, edit a booking... make sure everything works as expected * If you can: Install a translation and verify strings show up in po files as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 160285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160285&action=edit Bug 35475: Improve concatenated string and fix error in JS file Fixes 2 problems noted in comment#2 and comment#3 on the bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160284|0 |1 is obsolete| | Attachment #160285|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160812&action=edit Bug 35475: Makes strings in booking JS file translatable This makes several strings in the booking specific JS file translatable. To test: * Make an item bookable: * Find a record with items in your catalog or create one * From the details page, switch to the items tab * Mark items as bookable * Add a booking, verify the modal works as expected * Check the bookings tab * Verify the column headings of the bookings table show correctly * Verify the "Biblio level" and "Item" in the calendar show Note: Months don't translate, this will be a separate bug * Cancel a booking, edit a booking... make sure everything works as expected * If you can: Install a translation and verify strings show up in po files as expected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160813&action=edit Bug 35475: Improve concatenated string and fix error in JS file Fixes 2 problems noted in comment#2 and comment#3 on the bug report. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160812|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160848&action=edit Bug 35475: Makes strings in booking JS file translatable This makes several strings in the booking specific JS file translatable. To test: * Make an item bookable: * Find a record with items in your catalog or create one * From the details page, switch to the items tab * Mark items as bookable * Add a booking, verify the modal works as expected * Check the bookings tab * Verify the column headings of the bookings table show correctly * Verify the "Biblio level" and "Item" in the calendar show Note: Months don't translate, this will be a separate bug * Cancel a booking, edit a booking... make sure everything works as expected * If you can: Install a translation and verify strings show up in po files as expected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160813|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160849&action=edit Bug 35475: Improve concatenated string and fix error in JS file Fixes 2 problems noted in comment#2 and comment#3 on the bug report. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Yup, I agree, all looking good here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.02 released in| | --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Missing 23.05.x dependencies, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Bug 35475 depends on bug 29002, which changed state. Bug 29002 Summary: Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org