[Bug 5312] New: XHTML correction in authority summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 Summary: XHTML correction in authority summary Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Staff Client AssignedTo: paul.poulain@biblibre.com ReportedBy: fridolyn.somers@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 When an authority summary contains a "\n",it is replaced by a HTML's "<br>". XHTML new line is "<br \>". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2010-10-19 07:54:11 UTC --- Created attachment 2693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2693 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2010-10-19 07:56:50 UTC --- (Correction of comment #0)
When an authority summary contains a "\n",it is replaced by a HTML's "<br>". XHTML new line is "<br />". Patch is correct.
-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff AssignedTo|paul.poulain@biblibre.com |fridolyn.somers@gmail.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-02 16:00:57 UTC --- needs signoff status forgotten, setting it assigning to Fridolyn, as he sent the patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Does not apply --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-11 18:01:45 UTC --- Change looks good to me but patch is not in a valid format: Patch format detection failed. Fridolyn, could you resend as git patch please? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2693|0 |1 is obsolete| | --- Comment #5 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-08-22 13:15:25 UTC --- Created attachment 5085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5085 Proposed patch (updated) recreated with git format-patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5085|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9997&action=edit BUG 5312 XHTML correction in authority summary -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9997|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9999&action=edit [SIGNED-OFF] BUG5312 XHTML correction in authority summary Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: tiny patch that produces valid XHTML, passes QA of course ! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Passed QA |Pushed to Master Version|rel_3_2 |rel_3_8 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- worth porting to 3.8 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 --- Comment #10 from Fridolyn SOMERS <fridolyn.somers@gmail.com> --- Thanks everyone. I've learned a bit of XHTML since : new line is "<br/>" (no space). Patch is correct. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org