[Bug 34617] New: Patron expiration dates not updated during import when there is no dateexpiry column in the file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 Bug ID: 34617 Summary: Patron expiration dates not updated during import when there is no dateexpiry column in the file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Normally, imports only update included columns, however, if we are asking Koha to calculate expiration dates we should update the value even if it is not passed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154816&action=edit Bug 34617: Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154817&action=edit Bug 34617: Preserve calculated expiration dates if set to update on import whether column included or not To test: 1 - Setup a csv with column headers: surname firstname branchcode categorycode cardnumber dateenrolled 2 - add values Acosta Edna CPL PT 23529001000463 02/01/2013 3 - Set PT catgeory enrollement period to a specific date in the future 4 - Import the file and overwrite patrons and update dateexpiration 5 - Check Edna, note her date is not correct 6 - Apply patch 7 - Repeat 8 - Expiration date is now set as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Note, a workaround is simply to include a dateexpiry column in the file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 Joseph Alway <jbalway@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbalway@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154816|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 154867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154867&action=edit Bug 34617: Unit tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154817|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 154868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154868&action=edit Bug 34617: Preserve calculated expiration dates if set to update on import whether column included or not To test: 1 - Setup a csv with column headers: surname firstname branchcode categorycode cardnumber dateenrolled 2 - add values Acosta Edna CPL PT 23529001000463 02/01/2013 3 - Set PT catgeory enrollement period to a specific date in the future 4 - Import the file and overwrite patrons and update dateexpiration 5 - Check Edna, note her date is not correct 6 - Apply patch 7 - Repeat 8 - Expiration date is now set as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Note that tests failed if I left step 3 of the test plan in place, if I changed back to the default then they pass. prove t/db_dependent/Koha/Patrons/Import.t t/db_dependent/Koha/Patrons/Import.t .. 2/177 # Failed test 'Expiration date is correct with update_dateexpiry = true' # at t/db_dependent/Koha/Patrons/Import.t line 218. # got: '2024-01-31' # expected: '2031-11-28' t/db_dependent/Koha/Patrons/Import.t .. 175/177 Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_1> line 2. Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_1> line 2. # Looks like you failed 1 test of 177. t/db_dependent/Koha/Patrons/Import.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/177 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patrons/Import.t (Wstat: 256 Tests: 177 Failed: 1) Failed test: 60 Non-zero exit status: 1 Files=1, Tests=177, 2 wallclock secs ( 0.03 usr 0.00 sys + 1.75 cusr 0.26 csys = 2.04 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154867|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155066&action=edit Bug 34617: Unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154868|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155067&action=edit Bug 34617: Preserve calculated expiration dates if set to update on import whether column included or not To test: 1 - Setup a csv with column headers: surname firstname branchcode categorycode cardnumber dateenrolled 2 - add values Acosta Edna CPL PT 23529001000463 02/01/2013 3 - Set PT catgeory enrollement period to a specific date in the future 4 - Import the file and overwrite patrons and update dateexpiration 5 - Check Edna, note her date is not correct 6 - Apply patch 7 - Repeat 8 - Expiration date is now set as expected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34621 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org