https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller@bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|3.22 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Maria <mbugz2@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mbugz2@yahoo.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 27918 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116353|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 119341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119341&action=edit Bug 17748: Show due date and availability in item search results This enhancement adds the availability of an item to the item search results (i.e. shows if checked out, available on the shelf, or not available for checkout for some other reason). If checked out, also shows due date in item search results. Both the new availability and due date columns will also show when exporting results to a CSV file. To test: 1) Apply patch and restart services 2) Set up three items. Check out Item A to a borrower. Set Item B to some damaged, notforloan, withdrawn etc status so that it is considered not available. Leave Item C as is, not checked out, and not unavailable status. 3) Go to Search -> Item search. Scroll down and notice the Availability radio options - Ignore, Checked out, and Available. 4) Leave the Ignore option selected and do a search so that all three items show. 5) Confirm the availability and due date columns are showing at the right end of the table. Confirm Item A says Checked out and has a due date. Confirm Item B says Not available. Confirm Item C says available. 6) Export all result to CSV. Confirm the results show in the CSV file as expected. 7) Go to edit your search. Select the 'Checked out' radio option for Availability and submit the search. Confirm only Item A shows in the results (not Items B and C). 8) Go to edit your search. Select the 'Available' radio option for Availability and submit the search. Confirm only Item B shows in the results (not Items A and C). Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- This works well except for sorting: Sorting the results by Availability or by Date due doesn't work. The order changes, but not to the correct order. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Aleisha Amohia from comment #7)

(In reply to Owen Leonard from comment #6)

...

This works well except for sorting: Sorting the results by Availability or by Date due doesn't work. The order changes, but not to the correct order.

I have no idea why this is happening or how to fix it. Any datatables experts know why the filtering and sorting doesn't work for these two columns?

You are not doing anything to sort correctly on those 2 columns. It's an AJAX-based table, the results are not sorted in JS client-side only. You certainly need to modify C4::Items::SearchItems to correctly deal with those 2 columns in the order by clause. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119341|0 |1 is obsolete| | --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 128332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128332&action=edit Bug 17748: Show due date and availability in item search results This enhancement adds the availability of an item to the item search results (i.e. shows if checked out, available on the shelf, or not available for checkout for some other reason). If checked out, also shows due date in item search results. Both the new availability and due date columns will also show when exporting results to a CSV file. To test: 1) Apply patch and restart services 2) Set up three items. Check out Item A to a borrower. Set Item B to some damaged, notforloan, withdrawn etc status so that it is considered not available. Leave Item C as is, not checked out, and not unavailable status. 3) Go to Search -> Item search. Scroll down and notice the Availability radio options - Ignore, Checked out, and Available. 4) Leave the Ignore option selected and do a search so that all three items show. 5) Confirm the availability and due date columns are showing at the right end of the table. Confirm Item A says Checked out and has a due date. Confirm Item B says Not available. Confirm Item C says available. 6) Export all result to CSV. Confirm the results show in the CSV file as expected. 7) Go to edit your search. Select the 'Checked out' radio option for Availability and submit the search. Confirm only Item A shows in the results (not Items B and C). 8) Go to edit your search. Select the 'Available' radio option for Availability and submit the search. Confirm only Item B shows in the results (not Items A and C). Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #11 from Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> --- I was testing, and unfortunately on step 8 the unavailable item (i set the damaged status) also shows up togeter with the available items in the results, with the radio button set to 'available'. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128333|0 |1 is obsolete| | --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 128583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128583&action=edit Bug 17748: (follow-up) Fix sorting on new columns Confirm tests in t/db_dependent/Items.t still pass. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 128591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128591&action=edit Screenshot showing problems I'm seeing a couple of issues with the results, as shown in this screenshot: Is there supposed to be both an "Availability" and "Due date" column? I think this misalignment is why the column search field under "Availability" doesn't work. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #17 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Owen Leonard from comment #15)

Created attachment 128591 [details] Screenshot showing problems

I'm seeing a couple of issues with the results, as shown in this screenshot:

Is there supposed to be both an "Availability" and "Due date" column? I think this misalignment is why the column search field under "Availability" doesn't work.

Woops I had missed one more instance of removing the Availability column. Should be good to test now. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128583|0 |1 is obsolete| | --- Comment #19 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 128646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128646&action=edit Bug 17748: (follow-up) Fix sorting on new columns Confirm tests in t/db_dependent/Items.t still pass. Signed-off-by: Christian <christian.stelzenmueller@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #21 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Looks like this was signed off so will adjust status -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds the |This enhancement adds the release notes|availability of an item to |due date of an item to the |the item search results |item search results. The |(i.e. shows if checked out, |due date column will also |available on the shelf, or |show when exporting results |not available for checkout |to a CSV file. |for some other reason). If | |checked out, also shows due | |date in item search | |results. Both the new | |availability and due date | |columns will also show when | |exporting results to a CSV | |file. | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128646|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 129624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129624&action=edit Bug 17748: (follow-up) Fix sorting on new columns Confirm tests in t/db_dependent/Items.t still pass. Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Added Christian's surname to the sign-off lines, patches still apply cleanly against master. Thx Aleisha for noticing the missed status change! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129623|0 |1 is obsolete| | Attachment #129624|0 |1 is obsolete| | Attachment #129625|0 |1 is obsolete| | Attachment #130154|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130845&action=edit Bug 17748: Show due date and availability in item search results This enhancement adds the availability of an item to the item search results (i.e. shows if checked out or not). If checked out, shows due date in item search results. The due date column will also show when exporting results to a CSV file. To test: 1) Apply patch and restart services 2) Set up two items. Check out Item A to a borrower. Leave Item B as is not checked out, and not unavailable status. 3) Go to Search -> Item search. Scroll down and notice the Availability radio options - Ignore, and Checked out. 4) Leave the Ignore option selected and do a search so that both items show. 5) Confirm the availability and due date columns are showing at the right end of the table. Confirm Item A says Checked out and has a due date. Confirm Item B says available. 6) Export all result to CSV. Confirm the results show in the CSV file as expected. 7) Go to edit your search. Select the 'Checked out' radio option for Availability and submit the search. Confirm only Item A shows in the results (not Item B). Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130847&action=edit Bug 17748: (follow-up) Remove availability column Items can now only be filtered by 'Checked out' or 'not' rather than looking at damaged/itemlost/withdrawn/notforloan status. Removed availability column as Checked out items are made clear by the due date column. Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130849&action=edit Bug 17748: Remove unecessary html filter Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #33 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 131051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131051&action=edit Bug 17748: (follow-up) Fix date due column filter After items search result when entering a term in date due colum filter table is not filtered. Its is because columns from 'Issue' must be added in _SearchItems_build_where_fragment() like it has been added in SearchItems(). Test plan : 1) Perform an item search with some results beeing checked-out 2) In colum 'Date due' enter a number that is contained is some due dates, ie '2022' 3) Table results are filtered with items having search term in due date -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #36 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks perfect. Great thanks to sponsor and contributors ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #38 from Fridolin Somers <fridolin.somers@biblibre.com> --- I made some checkouts before running unit tests and they failed. I added a follow-up to fix that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 --- Comment #39 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42946 -- You are receiving this mail because: You are watching all bug changes.