[Bug 37606] New: Export module should replace double quotes with simple quotes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Bug ID: 37606 Summary: Export module should replace double quotes with simple quotes Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When exporting as csv, the exporter does not check the presence of double quote in the fields. Hence, if there is one double quote, the csv is broken. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Export module should |Framework export module |replace double quotes with |should replace double |simple quotes |quotes with simple quotes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 170199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170199&action=edit Bug 37606 - Fix framework export module to replace double quotes with simple quotes When exporting a framework as csv, the exporter does not check the presence of double quote in the fields. Hence, if there is one double quote, the csv is broken. TEST PLAN: 1 - Change a framework to add a field containing double quote in name 2 - Export it in csv 3 - Create a new framework 4 - Import the csv in the new framework -> every fields after the one containing double quotes should have no subfields 5 - APPLY PATCH 6 - Repeat 2-5 -> everything should be correctly exported -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170199|0 |1 is obsolete| | --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 170200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170200&action=edit Bug 37606 - Fix framework export module to escape double quotes When exporting a framework as csv, the exporter does not check the presence of double quote in the fields. Hence, if there is one double quote, the csv is broken. TEST PLAN: 1 - Change a framework to add a field containing double quote in name 2 - Export it in csv 3 - Create a new framework 4 - Import the csv in the new framework -> every fields after the one containing double quotes should have no subfields 5 - APPLY PATCH 6 - Repeat 2-5 -> everything should be correctly exported -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Framework export module |Framework export module |should replace double |should escape double quotes |quotes with simple quotes | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- NOTE: CSV exports should all use the same lib, I'll try and fix it once I have some time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Sukhmandeep <sukhmandeep.benipal@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sukhmandeep.benipal@inLibro | |.com --- Comment #4 from Sukhmandeep <sukhmandeep.benipal@inLibro.com> --- Hi Baptiste, I'm having some trouble following the test plan. Could you break down the steps a bit more? Also, which framework are we referring to? I'm guessing the MARC bibliographic framework, but I'm not sure. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Hi ! Thanks for paying attention to this patch ! :) For the 1, go in Administration -> MARC bibliographic frameworks, pick any framework by clicking action->marc structure (default framework is fine) and in a field of your choice, add double quotes (check that there are fields with subfields after the modified one by clicking on action->view subfields). Then you go back to the framework list for the 2, click on actions-> export-> csv 3 - click on new framework and fill in the form 4 - on the created framework, click on actions -> import, and pick the generated csv. Then, check the imported framework, the last fields will have no subfields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 --- Comment #6 from Sukhmandeep <sukhmandeep.benipal@inLibro.com> --- I tried to recreate the issue, but the results I obtained do not match those described in the test plan. For the step: 4 - Import the CSV in the new framework Expected Behavior: Every field after the one containing double quotes should have no subfields. Observed Results: - All the fields after the one containing double quotes, including the field with the double quotes, were not present in the new framework. - The fields before the one with the double quotes had no subfields. After applying the patch, everything seems to be working correctly. All fields are now present with their appropriate subfields. Note: I am not sure if the issue can be signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Oh yes sorry, I described the behaviour if you modify a subfield to add a double quote. It is due to the way it is imported. It imports every fields then every subfields. If you break the field, it will break every field after and every subfield. If you break a subfield, it will break every subfield after. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170200|0 |1 is obsolete| | --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 171343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171343&action=edit Bug 37606 - Fix framework export module to escape double quotes When exporting a framework as csv, the exporter does not check the presence of double quote in the fields. Hence, if there is one double quote, the csv is broken. TEST PLAN: 1 - Change a framework to add a field containing double quote in name 2 - Export it in csv 3 - Create a new framework 4 - Import the csv in the new framework -> every fields after the one containing double quotes should be broke. Every other fields should have no subfield 5 - APPLY PATCH 6 - Repeat 2-5 -> everything should be correctly exported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Sukhmandeep <sukhmandeep.benipal@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171343|0 |1 is obsolete| | --- Comment #9 from Sukhmandeep <sukhmandeep.benipal@inLibro.com> --- Created attachment 171344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171344&action=edit Bug 37606 - Fix framework export module to escape double quotes When exporting a framework as csv, the exporter does not check the presence of double quote in the fields. Hence, if there is one double quote, the csv is broken. TEST PLAN: 1 - Change a framework to add a field containing double quote in name 2 - Export it in csv 3 - Create a new framework 4 - Import the csv in the new framework -> every fields after the one containing double quotes should be broke. Every other fields should have no subfield 5 - APPLY PATCH 6 - Repeat 2-5 -> everything should be correctly exported Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Sukhmandeep <sukhmandeep.benipal@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171344|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 172934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172934&action=edit Bug 37606: Fix framework export module to escape double quotes When exporting a framework as csv, the exporter does not check the presence of double quote in the fields. Hence, if there is one double quote, the csv is broken. TEST PLAN: 1 - Change a framework to add a field containing double quote in name 2 - Export it in csv 3 - Create a new framework 4 - Import the csv in the new framework -> every fields after the one containing double quotes should be broke. Every other fields should have no subfield 5 - APPLY PATCH 6 - Repeat 2-5 -> everything should be correctly exported Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |chris@bigballofwax.co.nz |y.org | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37606 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED CC| |jesse@bywatersolutions.com Resolution|--- |FIXED --- Comment #14 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org