[Bug 21703] New: Placing holds in staff is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 Bug ID: 21703 Summary: Placing holds in staff is broken (TT filter) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 13618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The dataurl variable is already escaped, so the uri filter breaks it. To test: - Search for a record in staff - Go to holds - Search for patrons, multiple should be displayed - Pick a patron by clicking on the name - Verify an error is shown and the URL is incorrect -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81375&action=edit Bug 21703: Fix filter on dataurl variable to allow placing holds in staff again The uri filter breaks the dataurl variable in the template and the URL is incorrect with it. To test: - Search for a record in staff - Go to holds - Search for patrons, multiple should be displayed - Pick a patron by clicking on the name - Verify an error is shown and the URL is incorrect - Apply patch - Repeat test above, placing a hold should now work. https://bugs.koha-community.org/show_bug.cgi?id=21413 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- At first glance I'd say the filter should be 'url'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you explain? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am wondering if the & in the URL above is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81375|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81402&action=edit Bug 21703: Fix filter on dataurl variable to allow placing holds in staff again We must not encode & again and use the url filter, instead of uri. To test: - Search for a record in staff - Go to holds - Search for patrons, multiple should be displayed - Pick a patron by clicking on the name - Verify an error is shown and the URL is incorrect - Apply patch - Repeat test above, placing a hold should now work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81402|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81404&action=edit Bug 21703: Fix filter on dataurl variable to allow placing holds in staff again We must not encode & again and use the url filter, instead of uri. To test: - Search for a record in staff - Go to holds - Search for patrons, multiple should be displayed - Pick a patron by clicking on the name - Verify an error is shown and the URL is incorrect - Apply patch - Repeat test above, placing a hold should now work. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tiny change - switching to PQA right away. Thx Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21704 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Downgrading severity a bit as searches with one result will work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Caused by bug 13618 not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21703 Bug 21703 depends on bug 13618, which changed state. Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org