https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |danyonsewell@catalyst.net.n |ity.org |z -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169807|0 |1 is obsolete| | --- Comment #2 from Danyon Sewell <danyonsewell@catalyst.net.nz> --- Created attachment 169808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169808&action=edit Bug 37463: Adding system preference. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Include cover images on |Include cover images from |staff interface check out |Amazon on staff interface |screen |check out screen for | |specific patron categories -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #6 from Danyon Sewell <danyonsewell@catalyst.net.nz> --- Bug 37463: Adding system preference. This patch allows cover images to display in the patron checkout module for selected patron categories but only ones from Amazon for now. Test plan: Step 1 - apply this patch Step 2 - Make sure AmazonCoverImages syspref is set to "show" step 3 - Search for the CoverImagesCategories syspref and enable it for a specific patron category (choose the category that your patron account is) step 4 - checkout an item to your patron account step 5 - in the patron checkouts page, click the "show checkouts" button, you should see the items cover image there, as long as there is one available from Amazon Sponsored by: Pymble Ladies College -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |roman.dolny@jezuici.pl --- Comment #7 from Roman Dolny <roman.dolny@jezuici.pl> --- Applying: Bug 37463: Adding system preference. .git/rebase-apply/patch:92: trailing whitespace. + '.01.LZZZZZZZ.jpg" title="Amazon cover image"><img src="https://images-na.ssl-images-amazon.com/images/P/' .git/rebase-apply/patch:93: trailing whitespace. + oObj.isbn .git/rebase-apply/patch:116: trailing whitespace. error: sha1 information is lacking or useless (installer/data/mysql/atomicupdate/bug_37463-add_SCOCoverImagesCategories_syspref.pl). error: could not build fake ancestor Patch failed at 0001 Bug 37463: Adding system preference. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170492|0 |1 is obsolete| | --- Comment #8 from Danyon Sewell <danyonsewell@catalyst.net.nz> --- Created attachment 170623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170623&action=edit Bug 37463: Show Amazon cover images in checkouts table for selected patron categories This patch allows cover images to display in the patron checkout module for selected patron categories but only ones from Amazon for now. Test plan: Step 1 - apply this patch Step 2 - Make sure AmazonCoverImages syspref is set to "show" step 3 - Search for the CoverImagesCategories syspref and enable it for a specific patron category (choose the category that your patron account is) step 4 - checkout an item to your patron account step 5 - in the patron checkouts page, click the "show checkouts" button, you should see the items cover image there, as long as there is one available from Amazon -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170623|0 |1 is obsolete| | --- Comment #9 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 170686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170686&action=edit Bug 37463: Show Amazon cover images in checkouts table for selected patron categories This patch allows cover images to display in the patron checkout module for selected patron categories but only ones from Amazon for now. Test plan: Step 1 - apply this patch Step 2 - Make sure AmazonCoverImages syspref is set to "show" step 3 - Search for the CoverImagesCategories syspref and enable it for a specific patron category (choose the category that your patron account is) step 4 - checkout an item to your patron account step 5 - in the patron checkouts page, click the "show checkouts" button, you should see the items cover image there, as long as there is one available from Amazon Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wainuiwitikapark@catalyst.n |danyonsewell@catalyst.net.n |et.nz |z -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|danyonsewell@catalyst.net.n |wainuiwitikapark@catalyst.n |z |et.nz Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177462|0 |1 is obsolete| | --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Created attachment 177606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177606&action=edit Bug 37463: Show Amazon cover images in checkouts table for selected patron categories This patch allows cover images to display in the patron checkout module for selected patron categories but only ones from Amazon for now. Test plan: Step 1 - apply this patch Step 2 - Make sure AmazonCoverImages syspref is set to "show" step 3 - Search for the CoverImagesCategories syspref and enable it for a specific patron category (choose the category that your patron account is) step 4 - checkout an item to your patron account step 5 - in the patron checkouts page, click the "show checkouts" button, you should see the items cover image there, as long as there is one available from Amazon Sponsored by: Pymble Ladies College -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189820|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 190260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190260&action=edit Bug 37463: Show Amazon cover images in checkouts table for selected patron categories This patch allows cover images to display in the patron checkout module for selected patron categories but only ones from Amazon for now. Test plan: Step 1 - apply this patch Step 2 - Make sure AmazonCoverImages syspref is set to "show" step 3 - Search for the CoverImagesCategories syspref and enable it for a specific patron category (choose the category that your patron account is) step 4 - checkout an item to your patron account step 5 - in the patron checkouts page, click the "show checkouts" button, you should see the items cover image there, as long as there is one available from Amazon Sponsored by: Pymble Ladies College Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 --- Comment #17 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- (In reply to David Nind from comment #16)

Where there is no Amazon cover image, the patron's checkouts table just shows the text "Image from Amazon.com".

Maybe either: - show nothing or - just the "No cover image available", without the "Image from Amazon.com" text.

Kia ora David, I've had a look into this and when there is no image, it's usually because it is a 1px by 1px image being returned from Amazon which we have added in to the code to deal with. However, because it is dynamically fetching the height and width, the first few times the page is refreshed, the dimensions of all the images (whether there is a proper image available or not, is 0 by 0). When you refresh a few times, it picks up the actual dimensions of the image and then "Image from Amazon.com" is no longer displayed. So in summary, what you said has been implemented, but it doesn't seem to be working as expected from the start. Ngā mihi, Wainui -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement lets you release notes| |show cover images (Amazon | |only at the moment) for | |selected patron categories | |on a patron's checkouts | |table in the staff | |interface. | | | |The patron categories that | |the cover images show for | |are set using the new | |system preference | |`CoverImagesCategories`. --- Comment #19 from David Nind <david@davidnind.com> --- (In reply to Wainui Witika-Park from comment #17)

When you refresh a few times, it picks up the actual dimensions of the image and then "Image from Amazon.com" is no longer displayed.

Thanks Wainui - it does indeed do that! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 --- Comment #20 from Jennifer Sutton <jennifersutton@catalyst.net.nz> --- Created attachment 201343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201343&action=edit Bug 37463: Show Amazon cover images in checkouts table for selected patron categories This patch allows cover images to display in the patron checkout module for selected patron categories but only ones from Amazon for now. Test plan: Step 1 - apply this patch Step 2 - Make sure AmazonCoverImages syspref is set to "show" step 3 - Search for the CoverImagesCategories syspref and enable it for a specific patron category (choose the category that your patron account is) step 4 - checkout an item to your patron account step 5 - in the patron checkouts page, click the "show checkouts" button, you should see the items cover image there, as long as there is one available from Amazon Sponsored by: Pymble Ladies College Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37463 --- Comment #21 from David Nind <david@davidnind.com> --- Created attachment 201399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201399&action=edit Bug 37463: Show Amazon cover images in checkouts table for selected patron categories This patch allows cover images to display in the patron checkout module for selected patron categories but only ones from Amazon for now. Test plan: Step 1 - apply this patch Step 2 - Make sure AmazonCoverImages syspref is set to "show" step 3 - Search for the CoverImagesCategories syspref and enable it for a specific patron category (choose the category that your patron account is) step 4 - checkout an item to your patron account step 5 - in the patron checkouts page, click the "show checkouts" button, you should see the items cover image there, as long as there is one available from Amazon Sponsored by: Pymble Ladies College Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.